Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ca9feaa-90c9-93fc-38e0-3c41d51dc845@amd.com>
Date:   Mon, 7 Nov 2022 12:33:50 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v3 2/8] Documentation: amd-pstate: add EPP profiles
 introduction
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>, rafael.j.wysocki@intel.com,
        ray.huang@amd.com, viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221107175705.2207842-1-Perry.Yuan@amd.com>
 <20221107175705.2207842-3-Perry.Yuan@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20221107175705.2207842-3-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2NDVURMMjNJbXdLaC91SE1BSDh4RzRWS0tFMTZ3bWxoNjU0dVY4NmlLWTJn?=
 =?utf-8?B?eGVDNWQvemc5VmdkUm1JYzRPL1c3eUZoTWF6cG9QTXhnTklRNDkyaWVWYVl0?=
 =?utf-8?B?Q1VHc2RWdE1aOE9pb25xdWhlc3ZZZEwyaDhodGp5eGxiTFh2OEo2TDhycVZa?=
 =?utf-8?B?dTB6c21GQ1dUYmdkNW8ySVRwb01nemx6TTJQbm1xTjFPTXU3N2ZUVWFDdnV5?=
 =?utf-8?B?eHUzWjMvbjJGbzBDaFo0ZEEvQnNhNnRSYzM1dytaWlYzKzQ4R1ZucXFJR1FS?=
 =?utf-8?B?REJYcHhnYkl2QnR2V0c5d05iQXhBQVJRUGpvRjlTWUUxSXJreHg1eU1pVXFJ?=
 =?utf-8?B?WHRGcWg5U2dUS3JNakovMkhidFNEbVBIdzhZMEZ1NFdGZURTTUxnN0llSkpC?=
 =?utf-8?B?OXZaRjQ1Y2NTSno4Z2RWdThzdUpxM0JhcnJRbWdrdlR5VDFnNjJnNjBueGdX?=
 =?utf-8?B?cFlsV3NKZm1pQi83c096bXE3NGZrZDFtZFpjcjVHd0RIczVaN3pBZVdNenBS?=
 =?utf-8?B?UHpIRlpvZ3dhdTEvQk9ZNEFXZ0duQVpIendJRGdlS0RCTWFHN2RscCtMTW03?=
 =?utf-8?B?UkZiRTczSG1YM1lrYmhXZVJIYmF2N1JyVU8yQmRlLytqM2dJMEo2V240ei9B?=
 =?utf-8?B?dVlVWUhFbGRBaENSZHRDcmZkUXBNYU9Qb1B1TXJlbllSb21QTXFaYXdCeW51?=
 =?utf-8?B?N1FDNlZ3a2lIbndpNjAyUFFIR2hycE5HaFB1WDd1LzZDeFg0WUptZ2ZlRldj?=
 =?utf-8?B?eXZ2QXUwVzRNcGI2VVNtTGF5eno2Vm92My9VaStyL1hyNEdtZmY5bXRDSzlq?=
 =?utf-8?B?MjRPcDFrcFZzL3ZsWFpSaHlRaGJGWlFkYkhUTzVnRHBxaXlKcXRFYXJEamw2?=
 =?utf-8?B?bnJ5TXNOYnZHVG9NWTIydnJUbW9OMzFtc0FFVHgzQi9EUDE5b0IyblZjOE55?=
 =?utf-8?B?dTdiWVdPcUIycWYxd0VMYkJhMi9JNWFDUkNZVFloZ3U0T3h0aTAwOW5ZSTQy?=
 =?utf-8?B?c29vUm5LT0RMU3dwQXRMeFJmdTJ4UG9LcERWd2VsMGROUWlqMkpYajgyWDR3?=
 =?utf-8?B?UkN2ZXJqcjZWaSthMkwwbDh4eVIrT2lPaFlqQ01OdHFWWjBybVQ4S2dmbFdG?=
 =?utf-8?B?MEY5Rms5ekpsWXlMekRYK0haUHk3TFlZSE9MMk9jTEY3a1JJd3FXdEdvWUJH?=
 =?utf-8?B?TEF4dmx3Qmk5dXhJdU9DeGkwYW9RcHkvdWROLzFxQ0xxenBDTit0eVRGYVIx?=
 =?utf-8?B?b1ZoSHhKMFNsYjU5M2cvcmVCOTlZVkpjcFMrZ2U0eVBUL1VIZEZQTXJLVEZx?=
 =?utf-8?B?RW02RkdFNk1LcEIrdHpzendZNjB3QkJpN29Hd0QzSVRHdmx1S3JxdWd5bklx?=
 =?utf-8?B?MFU1a1hhOWQxaXJrWW5OenRlcUlUUmNYbDlMZ1FJWFpBdFNiMUNqVktIT3VE?=
 =?utf-8?B?dEpxYnhZWGFhTy9jTzgwME1kQUE3anJxOW1KaGhBbVFBWEZoNUo1Wkw1MFY2?=
 =?utf-8?B?NjdtaEpBY3NNdklOYzlyeTNUWk92eVZoWitsM1krcEVxVC82OGVkeG9nUVN1?=
 =?utf-8?B?ZHluNUk4R3QwTHpIS2tINk1qSllBUmx2ZE1IWDNmc3dNYmxFU3dXRHZPcFUx?=
 =?utf-8?B?aUgrSS9oaEg5YkZVV2s3Q1czTlhWRWJpb2swc1FTdHo5L2dkWWxuK2xXVVln?=
 =?utf-8?B?WlVwcXJIN1R5WDVqS1VVZE00emZCOWg2SU5yaE9XVGFsMjdNMm9wQUN0SWNJ?=
 =?utf-8?B?YTVnWTVZOGh2ZnU3RG1DclhOeG9Qd0xsRHV6OHRwKyt3MkEwRmZhYTVzRldO?=
 =?utf-8?B?TzVNa1Q5YTJJMlR0dnRQaTgybUtYeXQ1b09vNThyYmhrZU1zNjJPekoyZzQ4?=
 =?utf-8?B?S21WbTJ2cyttTUlwOE90ekFhTWNGRmt2dXcwRUZET05qZTBTSHdVZjBiR2dN?=
 =?utf-8?B?dlljZHdYaFdoVzVrUnJiemltUVNhRm50Z2RpK3FiQVJoczZnWGZYSHZmTnR1?=
 =?utf-8?B?ZHgxRElSMEx1VW5iQXdWYy8rcmVNbklCYm5Kc3VjTFVZYWtuL05QRUZMcU5v?=
 =?utf-8?B?VUgrWnc0WmM4RXNhY1pWeHIyR3ZBSjZHMkUrTTdtZllSK3hZTVZmMExieVNp?=
 =?utf-8?Q?3xUx24ODVKvR4HeZgRmchqP5P?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 070fedeb-7f7f-438c-1edf-08dac0ee9ffb
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 18:33:54.6706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OFqTDUsYy1uVY4luDQAg9wOkNeVTOXcXFkHCeoWrpazff7QQKwDfUYt/LKw+IzLota95oW+tCn0KRk7T9YS7Nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6363
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 11:56, Perry Yuan wrote:
> The patch add AMD pstate EPP feature introduction and what EPP
> preference supported for AMD processors.
> 
> User can get supported list from
> energy_performance_available_preferences attribute file, or update
> current profile to energy_performance_preference file
> 
> 1) See all EPP profiles
> $ sudo cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_available_preferences
> default performance balance_performance balance_power power
> 
> 2) Check current EPP profile
> $ sudo cat /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference
> performance
> 
> 3) Set new EPP profile
> $ sudo bash -c "echo power > /sys/devices/system/cpu/cpu0/cpufreq/energy_performance_preference"
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 8f3d30c5a0d8..78c6525d5a49 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -262,6 +262,25 @@ lowest non-linear performance in `AMD CPPC Performance Capability
>   <perf_cap_>`_.)
>   This attribute is read-only.
>   > +``energy_performance_available_preferences``
> +
> +All the supported EPP preference could be selected, List of the strings that
> +can be set to the ``energy_performance_preference`` attribute
> +those different profiles represent different energy vs efficiency hints provided
> +to low-level firmware
> +however, the ``default`` represents the epp value is set by platform firmware
> +This attribute is read-only.

My proposal at rewording it.

A list of all the supported EPP preferences that could be used for 
``energy_performance_preference` on this system.
These profiles represent different hints that are provided
to the low-level firmware about the user's desired energy vs efficiency 
tradeoff.  ``default`` represents the epp value is set by platform 
firmware. This attribute is read-only.


> +
> +``energy_performance_preference``
> +
> +The current energy performance preference can be read from this attribute.
> +and user can change current preference according to energy or performance needs
> +Please get all support profiles list from
> +``energy_performance_available_preferences`` attribute, all the profiles are
> +integer values defined between 0 to 255 when EPP feature is enabled by platform
> +firmware, if EPP feature is disabled, driver will ignore the written value
> +This attribute is read-write.
> +
>   Other performance and frequency values can be read back from
>   ``/sys/devices/system/cpu/cpuX/acpi_cppc/``, see :ref:`cppc_sysfs`.
>