Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2397639rwb; Mon, 7 Nov 2022 12:48:57 -0800 (PST) X-Google-Smtp-Source: AMsMyM6qU/uVd6LrnuIgUhA8m3hEMGcNeDUV4DU9vH2qpDv3bAS2XTlx8CobeUkLKu+XFuSTIJqX X-Received: by 2002:aa7:dd57:0:b0:453:2d35:70bb with SMTP id o23-20020aa7dd57000000b004532d3570bbmr52789387edw.26.1667854137010; Mon, 07 Nov 2022 12:48:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667854137; cv=none; d=google.com; s=arc-20160816; b=PIxt0iAiHv5iPap+ojL/+zGa1bpYRHY+0InY+GIPkFfRxO0M2sEArRhDbJdnaQR+vv uMIBH0mLbRT71pqU7gShUWicHxIC3QUSqFPw8kqrzdCfTlsKrMO6lFgC6PJoWl9+Rv0c 11088wAm0A3sz/cTOw4VaVGi9ljwrSVjkib/fDPA+nKCyb7sekw6PydlOxZcJGpQ/SDO u9RfJljMFehsHO8/GsQd4rD/ghqbUG22XkacV6VK/9x6Dh8ymPqXc3LkHkWhbP+IY5Zs 9fj522+VM99h//SCCf/yVWByuNHkBJthTuIW6abSSHhnaL4uf1o+W9bCoMuRQnDA5cQ0 KzzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=TguTsLw05wrr79/DGrT65aR2O18gVheFcV7+/gdkrpk=; b=cX9p0pTJE0A2f+IAe1uie1+lWkGacWFu8b+GR9EZDSMiMkg+Aza1DwgaeTc+LgVJjA xBjXpPnt0m/q4nNcS0OJXcxRpvsmK0Zw9wEAEQWShJ7WCcgkFnKjaOISqydol90XKH8p m+0qWKct2cTyT6oGuroftMgb/fdiaYx1Pbd2FSEcmDUYiy+zdbpvHbv5w9HarFsOAhj2 Zu7tPVfgoeBdiPOYE+iYQzwbwyir6noMq66Ep04Gt5i+n2DlSPxTKdP43Ch4h5GJmZMY 2LouWBkCc3mQB4g+U1YXZ5oMbsS0MVuFIr0ACtxb3HXw/X8Cnrw+oaarbJzwxlMHH/6K 5LYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="to0/8UgU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb36-20020a170907162400b007940226fd21si11597141ejc.903.2022.11.07.12.48.31; Mon, 07 Nov 2022 12:48:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="to0/8UgU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232641AbiKGU3I (ORCPT + 92 others); Mon, 7 Nov 2022 15:29:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232942AbiKGU3D (ORCPT ); Mon, 7 Nov 2022 15:29:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF01426AE5; Mon, 7 Nov 2022 12:28:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4DB38612F3; Mon, 7 Nov 2022 20:28:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75190C433D6; Mon, 7 Nov 2022 20:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667852935; bh=yvpUUnOPYhg2U+DkWMtEWcYfKBAQIgETZ3DrNN9r0mY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=to0/8UgUzeTStHPDDlxQoR6tBFjNif8uBLMwr5Bu+rBtdWEp/o/XeDU6X9Icks+Zk XkqUVcIOzjuOd6N7lYmThOqVGCR1Xxkr8ZX175A/8aHDeoGGEDdU6mEwLE0jtQt21M Dllv9WtoHjwMFalUN5XluPhdyQalFXaO+u3brBeHG3vMebOVeMRPGC10p/vLVTdAJW 4teCPHxU9rYWT0e08mQFwpgH+zQ05PIHOa7c8Smdlpa+7sy23yEANoI7Rn0Rbw9yP4 7VLNOZxtowMkDXJx/AYX65a0HUlQMghUMEx2FjFmM6ed4nFihXwQVg83CU32gEB1EC dk8xlEQqhigng== Date: Mon, 7 Nov 2022 14:28:53 -0600 From: Bjorn Helgaas To: Manivannan Sadhasivam Cc: kishon@kernel.org, lpieralisi@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kw@linux.com, robh@kernel.org, vidyas@nvidia.com, vigneshr@ti.com Subject: Re: [PATCH v4 0/5] PCI: endpoint: Rework the EPC to EPF notification Message-ID: <20221107202853.GA416802@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221025145101.116393-1-manivannan.sadhasivam@linaro.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2022 at 08:20:56PM +0530, Manivannan Sadhasivam wrote: > Hello, > > During the review of the patch that fixes DBI access in PCI EP, Rob > suggested [1] using a fixed interface for passing the events from EPC to > EPF instead of the in-kernel notifiers. > Manivannan Sadhasivam (5): > PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ > PCI: tegra194: Move dw_pcie_ep_linkup() to threaded IRQ handler > PCI: endpoint: Use a separate lock for protecting epc->pci_epf list > PCI: endpoint: Use callback mechanism for passing events from EPC to > EPF > PCI: endpoint: Use link_up() callback in place of LINK_UP notifier > > drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- > drivers/pci/controller/dwc/pcie-tegra194.c | 9 ++++- > drivers/pci/endpoint/functions/pci-epf-test.c | 38 ++++++------------- > drivers/pci/endpoint/pci-epc-core.c | 32 ++++++++++++---- > include/linux/pci-epc.h | 10 +---- > include/linux/pci-epf.h | 19 ++++++---- > 6 files changed, 59 insertions(+), 51 deletions(-) Doesn't apply cleanly on v6.1-rc1. Does it depend on something else?