Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Mon, 07 Nov 2022 20:27:59 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   sarha@kapsi.fi
Message-ID: <0c84acf54ab7db9210cede8ca210438c4c902324@kapsi.fi>
To:     "Paul Cercueil" <paul@crapouillou.net>,
        "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
        "Maxime Ripard" <mripard@kernel.org>,
        "Thomas Zimmermann" <tzimmermann@suse.de>,
        "David Airlie" <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        "Jyri Sarha" <jyri.sarha@iki.fi>,
        "Tomi Valkeinen" <tomba@kernel.org>
References: undefined <20221107175106.360578-1-paul@crapouillou.net>
 <20221107175256.360839-1-paul@crapouillou.net>
Subject: Re: [PATCH 21/26] drm: tilcdc: Remove #ifdef guards for PM
 related functions
Precedence: bulk

November 7, 2022 at 7:52 PM, "Paul Cercueil" <paul@crapouillou.net mailto=
:paul@crapouillou.net?to=3D%22Paul%20Cercueil%22%20%3Cpaul%40crapouillou.=
net%3E > wrote:

>=20
>=20Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handl=
e
> the .suspend/.resume callbacks.
>=20
>=20These macros allow the suspend and resume functions to be automatical=
ly
> dropped by the compiler when CONFIG_SUSPEND is disabled, without having
> to use #ifdef guards.
>=20
>=20This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
>=20
>=20Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Acked-by: Jyri Sarha <jyri.sarha=C4=B1@iki.fi>

> ---
> Cc: Jyri Sarha <jyri.sarha@iki.fi>
> Cc: Tomi Valkeinen <tomba@kernel.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>=20
>=20diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/ti=
lcdc/tilcdc_drv.c
> index f72755b8ea14..cd5bdc2f803a 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -496,7 +496,6 @@ static const struct drm_driver tilcdc_driver =3D {
> * Power management:
> */
>=20
>=20-#ifdef CONFIG_PM_SLEEP
> static int tilcdc_pm_suspend(struct device *dev)
> {
>  struct drm_device *ddev =3D dev_get_drvdata(dev);
> @@ -518,11 +517,9 @@ static int tilcdc_pm_resume(struct device *dev)
>  pinctrl_pm_select_default_state(dev);
>  return drm_mode_config_helper_resume(ddev);
> }
> -#endif
>=20
>=20-static const struct dev_pm_ops tilcdc_pm_ops =3D {
> - SET_SYSTEM_SLEEP_PM_OPS(tilcdc_pm_suspend, tilcdc_pm_resume)
> -};
> +static DEFINE_SIMPLE_DEV_PM_OPS(tilcdc_pm_ops,
> + tilcdc_pm_suspend, tilcdc_pm_resume);
>=20
>=20/*
> * Platform driver:
> @@ -597,7 +594,7 @@ static struct platform_driver tilcdc_platform_drive=
r =3D {
>  .remove =3D tilcdc_pdev_remove,
>  .driver =3D {
>  .name =3D "tilcdc",
> - .pm =3D &tilcdc_pm_ops,
> + .pm =3D pm_sleep_ptr(&tilcdc_pm_ops),
>  .of_match_table =3D tilcdc_of_match,
>  },
> };
> --=20
>=202.35.1
>