Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7caf2d6a-3be9-4261-9e92-db55fe161f7e@seco.com>
Date:   Mon, 7 Nov 2022 15:50:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH net-next v2 08/11] of: property: Add device link support
 for PCS
Content-Language: en-US
To:     Vladimir Oltean <olteanv@gmail.com>, Rob Herring <robh@kernel.org>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Frank Rowand <frowand.list@gmail.com>,
        Saravana Kannan <saravanak@google.com>,
        devicetree@vger.kernel.org
References: <20221103210650.2325784-1-sean.anderson@seco.com>
 <20221103210650.2325784-9-sean.anderson@seco.com>
 <20221107201010.GA1525628-robh@kernel.org>
 <20221107202223.ihdk4ubbqpro5w5y@skbuf>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20221107202223.ihdk4ubbqpro5w5y@skbuf>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dC9kSjJLVnQ0Ri9rakQ5NzhBQTFHYitHR3I0dGEyeTdQQ2thU2lBV0Fpd2dK?=
 =?utf-8?B?YStXUTMwQTRiUDNldXlRYTRVS2Z1bG5lZWZkRmM0UWpsVUVzbHRjQnhQK2pD?=
 =?utf-8?B?M3g5K0VYOUxDaFhVV1FvR0wyVlNCeFl6YS81RjFaYWpWZlZPRXRvZklmWlFu?=
 =?utf-8?B?QXRMSTg5L3VrYmFIaGZLSXFESFd4YlNpVFBRWGVJK1g5ZTlqbmNtRDdEU0lZ?=
 =?utf-8?B?MUVKVzFndHBLNDBOQUdHMy96c3BjRHVGYk9ZTjhnQTJsbWY0WFlqWmp3dWc5?=
 =?utf-8?B?ZGxBenpPNkM1WG1ZSDJGT3BkbTlHTFZuemRwTzQ5K1FsRTF2NW9NWWQ2eS9T?=
 =?utf-8?B?QWU4ZE1odVNNZ0hUYlZyeE9hMTEyb2txc2MzMlI0ZkowUEhoVzN6WU5zRlo0?=
 =?utf-8?B?aDl2SVc5eTh3VEZ0UVN0RHA4dWpYSWxDYmRSTHhtcXdyN3d6alV1LzFDNHk4?=
 =?utf-8?B?TFBZcVc0YTBYL2NSemQyZllKaTVkUWVJcm4yby90MHRNV0dIc1VVZk1VTk5a?=
 =?utf-8?B?R2pWU09Ed0h6Y1JlWkJjb0ZKb1FscU5YaTViM3dBb1FTcitQc2xyVXpWVExP?=
 =?utf-8?B?UTVDS1QyeG5YYzlycDBGUXZOcGkzck9YbVZHREpEL0Y1YVpCM3dqK25nWWd6?=
 =?utf-8?B?Uml1TzNNQ0QzK1RETDdSOUNmSFU5NWJmclRiYnNpMndVRUJzU1BkdmN2bmZs?=
 =?utf-8?B?b0QwMENnRkZsNzl5THVrNHlDOTVKQUYrNjJkRkF1SjRrY3RwR1Vsb1BEU1hN?=
 =?utf-8?B?WjJtczJ0OEpRYmFoOEY5YkJvd0hweVIzMXZoRXpoSzZJcHlpOXV5MW9EQWpJ?=
 =?utf-8?B?cDJud1ZobFdkRGVNRFNxenhUUHkyVzNrc0V3Y0Y1eG5EZFU0YnJHYVdGc2xP?=
 =?utf-8?B?Z25obHhMK2JnYWprdlFSVXVucjFXaVhEYlJFS3BPeUZWcDB4ODRxbDNRRHpx?=
 =?utf-8?B?aUxhMng3aThYMlBnanlMVDhXdzVjRlFBbkN0bjlOVFZsNytlUytHQ1d6RFJN?=
 =?utf-8?B?eVN3Q2pwQXlPTk9ZMkpEeVhRc3ZxZ3d4amtubzIvNVNrN3hhOWR1UlBVQTdT?=
 =?utf-8?B?eW5oYXM3RStCcEo2R1R2TjVMQWxTS1ErWTBoMkxZdjZyYm9Ldno2enVyZkYv?=
 =?utf-8?B?TnpNeVhFUFg0T2Y3dktvajlpa1ZVTzFVcG0xbCt6anpNNzVsM2FTaCtCbTFE?=
 =?utf-8?B?ZDRjWmNzM3JXT0ZGNktnWm9PTjVJTGloWlNjYTNuUXZyR2RIQXBrRFRCMjhM?=
 =?utf-8?B?VFRvS25sT0RvT3NTY1RQMzVWVk9XQktGa2RUbGg4cmZ0bDFPZDd1Vlo4NDRZ?=
 =?utf-8?B?T3J4MHJsUThRUXRtSzdDa3p6ZTE4SUQwUW5ueURPQ0VtVS90MVNBOW42L3NP?=
 =?utf-8?B?bUlHaktPOFQ5Y3owZjdMWXRheUY5d04xc3FUajJaTW9QRm8rRmRrMDY3Qnpu?=
 =?utf-8?B?OC90QldCbFYzb2RVeDl3cjBZaUNoZW1HMXROTmx6Mk1wUU5RejNsenlzSWhu?=
 =?utf-8?B?ZW4ycDVERVpHVEluaFl5eFYybFc1U05Vb2dmbTF5ZkthSDhhMnRDTHhBU0tW?=
 =?utf-8?B?aVVkbmh3dXB2L2VBZ0NXRFFqQUtuaU9DUlQxZGU4c2owcDB1ckhGZkRYb0FM?=
 =?utf-8?B?RVkvQXFpRzZoenQ3TDlPclFNNlZTN0dlUmQ4a3lBcmhqY3N1cVo3aUtISzZw?=
 =?utf-8?B?ejFNNkJkaHNZckNYa0hhNUFoK1M4TkJ2TmJ6cUpjYU5KOGowTkxNWFByN1RN?=
 =?utf-8?B?dzRRWUxLK2wwSVdzb1NrOEl2Sk5VcDFGbWlibjZ6Z1V3ZWs0Yno4Y1o0UEYv?=
 =?utf-8?B?NDdHMnplSXlVOUlVZGZDWWVYZ2ZxMCtvbk1QUURraFc1UHVrR2g0RXd2OFFk?=
 =?utf-8?B?WUhwOHFLL1NNY3ozM3Nncy9lT0tMOURjT3AwTWlJMFMwdisrQXo4aGtlckhK?=
 =?utf-8?B?Q25maXF2blZydHBPSU5hemNyTmRQWkg4WFJBQmhNZW1EcUhjeDRjVWdneHV4?=
 =?utf-8?B?WGt2cnhNYXIxTitSRVQwMUI0VW1WS08zTmsyODEyVE5WTjlEUS95Rmt4Q2pq?=
 =?utf-8?B?MEF4dHA3NjJVajNFUGtmU1pYNWFpMmZCcWEvcVpkUjhnUFRYazRScUxqREVu?=
 =?utf-8?Q?HejQ2RlU1rmo9KKH9L7np3zGO?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 106d962f-e441-4f95-fe11-08dac101bc3c
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 20:50:42.6088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IL2WQymvfXxwfCVEA0HCmGHB/xa+KQ9xh1SaqRsyLiIB7RZpvU9roZ0B61MsPROaj5ye6NEQqVylLF5xERNsYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7337
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/22 15:22, Vladimir Oltean wrote:
> On Mon, Nov 07, 2022 at 02:10:10PM -0600, Rob Herring wrote:
>> On Thu, Nov 03, 2022 at 05:06:47PM -0400, Sean Anderson wrote:
>> > This adds device link support for PCS devices. Both the recommended
>> > pcs-handle and the deprecated pcsphy-handle properties are supported.
>> > This should provide better probe ordering.
>> > 
>> > Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> > ---
>> > 
>> > (no changes since v1)
>> > 
>> >  drivers/of/property.c | 4 ++++
>> >  1 file changed, 4 insertions(+)
>> 
>> Seems like no dependency on the rest of the series, so I can take this 
>> patch?
> 
> Is fw_devlink well-behaved these days, so as to not break (forever defer)
> the probing of the device having the pcs-handle, if no driver probed on
> the referenced PCS? Because the latter is what will happen if no one
> picks up Sean's patches to probe PCS devices in the usual device model
> way, I think.

Last time [1], Saravana suggested to move this to the end of the series to
avoid such problems. FWIW, I just tried booting a LS1046A with the
following patches applied

01/11 (compatibles) 05/11 (device) 08/11 (link) 09/11 (consumer)
=================== ============== ============ ================
Y                   N              Y            N
Y                   Y              Y            Y
Y                   Y              Y            N
N                   Y              Y            N
N                   N              Y            N

and all interfaces probed each time. So maybe it is safe to pick
this patch.

--Sean

[1] https://lore.kernel.org/netdev/CAGETcx97ijCpVyOqCfnrDuGh+SahQCC-3QrJta5HOscUkJQdEw@mail.gmail.com/