Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f3fb0b66-66bb-b39b-8d45-f5c4105e2076@quicinc.com>
Date:   Mon, 7 Nov 2022 15:19:43 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v3 3/5] clk: qcom: Add QDU1000 and QRU1000 GCC support
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
CC:     Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Taniya Das <quic_tdas@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221026190441.4002212-1-quic_molvera@quicinc.com>
 <20221026190441.4002212-4-quic_molvera@quicinc.com>
 <20221107173237.xkeigtihoes3vsux@builder.lan>
From:   Melody Olvera <quic_molvera@quicinc.com>
In-Reply-To: <20221107173237.xkeigtihoes3vsux@builder.lan>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/7/2022 9:32 AM, Bjorn Andersson wrote:
> On Wed, Oct 26, 2022 at 12:04:39PM -0700, Melody Olvera wrote:
>> diff --git a/drivers/clk/qcom/gcc-qdu1000.c b/drivers/clk/qcom/gcc-qdu1000.c
>> new file mode 100644
>> index 000000000000..7bd8ebf0ddb5
>> --- /dev/null
>> +++ b/drivers/clk/qcom/gcc-qdu1000.c
>> @@ -0,0 +1,2645 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/module.h>
>> +#include <linux/of_device.h>
>> +#include <linux/regmap.h>
>> +
>> +#include <dt-bindings/clock/qcom,gcc-qdu1000.h>
>> +
>> +#include "clk-alpha-pll.h"
>> +#include "clk-branch.h"
>> +#include "clk-rcg.h"
>> +#include "clk-regmap.h"
>> +#include "clk-regmap-divider.h"
>> +#include "clk-regmap-mux.h"
>> +#include "clk-regmap-phy-mux.h"
>> +#include "reset.h"
>> +
>> +enum {
>> +	P_BI_TCXO,
>> +	P_GCC_GPLL0_OUT_EVEN,
>> +	P_GCC_GPLL0_OUT_MAIN,
>> +	P_GCC_GPLL1_OUT_MAIN,
>> +	P_GCC_GPLL2_OUT_MAIN,
>> +	P_GCC_GPLL3_OUT_MAIN,
>> +	P_GCC_GPLL4_OUT_MAIN,
>> +	P_GCC_GPLL5_OUT_MAIN,
>> +	P_GCC_GPLL6_OUT_MAIN,
>> +	P_GCC_GPLL7_OUT_MAIN,
>> +	P_GCC_GPLL8_OUT_MAIN,
>> +	P_PCIE_0_PHY_AUX_CLK,
>> +	P_PCIE_0_PIPE_CLK,
>> +	P_SLEEP_CLK,
>> +	P_USB3_PHY_WRAPPER_GCC_USB30_PIPE_CLK,
>> +};
> [..]
>> +static const struct clk_parent_data gcc_parent_data_1[] = {
>> +	{ .index = P_BI_TCXO },
>> +	{ .hw = &gcc_gpll0.clkr.hw },
>> +	{ .index = P_SLEEP_CLK },
> .index here refers to the index in the clocks property in DT.
>
> I think it's okay to reuse the parent-enum, but the entries within must
> then match the order defined in the DT binding. So you need to ensure
> that the first N entires in the enum matches the binding.
>
> Perhaps it's cleaner to just carry a separate enum for the clocks order,
> as we've done in the other drivers?
>
> If nothing else it makes it clear that one number space is arbitrary and
> internal to the driver and the other is ABI.

Yeah that makes plenty of sense. Will update the driver with a separate enum.

>
>> +	{ .hw = &gcc_gpll0_out_even.clkr.hw },
>> +};
>> +
> [..]
>> +static struct clk_regmap_mux gcc_pcie_0_phy_aux_clk_src = {
>> +	.reg = 0x9d080,
>> +	.shift = 0,
>> +	.width = 2,
>> +	.parent_map = gcc_parent_map_6,
>> +	.clkr = {
>> +		.hw.init = &(const struct clk_init_data){
> Sorry for being picky, but I do like when there's a space between the
> ')' and '{' in these lines...

No worries. Will fix.

>
>> +			.name = "gcc_pcie_0_phy_aux_clk_src",
>> +			.parent_data = gcc_parent_data_6,
>> +			.num_parents = ARRAY_SIZE(gcc_parent_data_6),
>> +			.ops = &clk_regmap_mux_closest_ops,
>> +		},
>> +	},
>> +};
>
Thanks,
Melody