Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9da9bf85-fcaf-78ac-85f2-584a17a21af9@intel.com>
Date:   Mon, 7 Nov 2022 16:04:07 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.1
Subject: Re: [PATCH v3 1/5] selftests/resctrl: Fix set up schemata with 100%
 allocation on first run in MBM test
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20221101094341.3383073-1-tan.shaopeng@jp.fujitsu.com>
 <20221101094341.3383073-2-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20221101094341.3383073-2-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0hLa2tXOUUvOW5qWFF4VklJd0w5aGNEelJtMGJMWmhpWHAxRmVudlhlNzBN?=
 =?utf-8?B?eDBTZ081V0hldXlHdUp3RGdTelRhanlMYjVLT2JqbVk1VTZ6KzZzSmlpT29Q?=
 =?utf-8?B?K3BjWmNQWk93MlZSWnZqK0Zja3hHTVBHUkJyYkJiUDhMa1EzRjMvd1krSEJl?=
 =?utf-8?B?WWRHWlRzRFZtaG1mU0lEWG05ZCtEY1ZZNmVaZ1Z5U3EwOHVpM1ppTzJrV1JX?=
 =?utf-8?B?Z1BEVjMydTdoVk1DcS9RK3Qyak5EV01WOXNHM0xtZ1g1RnZZWkNRblBQSlR3?=
 =?utf-8?B?UFlOZ3pyUkRIZEVBaHE0VnV4eUYxMWswZjZZa3NuNXRxVm9qSEpkaXVDQTdO?=
 =?utf-8?B?U3VqaUNsVExFNXBsa25EdnMwRzg1NHh0ZU9FUjcwMFRyQzFSaWVrSFhFN2RX?=
 =?utf-8?B?dXFPSXQrK2RSOU1kM0VRZVRPRnpJeGlaSWlDRjNlU25JYmVmNktxUjVTc0ZN?=
 =?utf-8?B?MWVjQmdLbVhMZFRYZHM1dnljNzRoalg0VjVSWWhjM0F1RERLQ0V4cVp2Y0lP?=
 =?utf-8?B?cDZkelprUWpyNzd6YXQzNHczM2hVU3B1Q1BTSVVYdEI1cWx1Nk1oaTgzNisx?=
 =?utf-8?B?NVk0K2ZZWCtaZFg0bXYzcGhVWUIxRjBHczBRTmNjOGNPMU13RFdIdW8xbUdF?=
 =?utf-8?B?VHlRMVFpNGtEQzFYUitNQXR2ZUZFREhqTGI3cnF2QnZadW1WaE1nM3d2VWd4?=
 =?utf-8?B?K3NzeTEyUlNXSHlMTFU4aDhTcmVKTVhCT2VkRDI4UGNLdlp3ejc2NExGNFJF?=
 =?utf-8?B?bisxeURVNUdmZVpwNGV2L2lSVDZVSExNK1hEazFHaVg5SmQwdnV3V0Yrdi9W?=
 =?utf-8?B?QXBwVjFsTmt5SnQ0UHQ4UkptWUtKeG5wdUxkczVETTJwaDhFZndHT1pOc1Bl?=
 =?utf-8?B?V1NMaVFVTHF4ZG1xbUVWSHpzVFBIR3YxMmNxMVZ5VjhUS1dUbGttNE1jeExh?=
 =?utf-8?B?V3NXTVZ4dGt3Uk1DTEtRRjc5VkNIQk9lL0dXQUFuTUNpUXFROFdkakorRTUr?=
 =?utf-8?B?YnpXVnRVZW5RT1UwMDBIMmExS3hXZkJtUDl2NnYvZHZYaTk0QVFxMHlzSEpS?=
 =?utf-8?B?T2hpa00xa0Fkb2hVN3dqZVdOdTNVUGZkMnEwUlROblpKWFBMaFlSU2JxSm5B?=
 =?utf-8?B?NllUWVphdlAyWmI0L3JQZDJwY1JMNU1hS0diNjNkeDdsY2FuemgwM1cwU3dw?=
 =?utf-8?B?ZVAzMkxTdVVkajJoN3RrNW9UdE9BYmpKL29oVW1sUnFsbTBHdmNZNElZRFY0?=
 =?utf-8?B?bGplUlZBVHlyYVBGLzBMRnB5SEI5VzRJQ2tyc0hNY0taWjc5TVY5OVJYcDJ5?=
 =?utf-8?B?aElXVCtqaDdMdlRHWFBUUkJhYkM2MFpuWkJQbXJXV05zM3VJeDlsUkFySTRG?=
 =?utf-8?B?UWJPdWI3WTZ4RXg2cVR6eUdZUDJiNU5wOVdBOVdEZzNPSStsb1MxckEwbmtT?=
 =?utf-8?B?RXBxTFB1bjV5cDV1Z3FBYmFwRGVLTFVGWkVSQTBnQVE1QmtIdW5YRkRkQ0tz?=
 =?utf-8?B?d3VYbDd4Q2VTQTNvbkJqSEE1bGlvWUNPVVlKZW5zaWpCOWZ5V2M3Wmp0OXBL?=
 =?utf-8?B?N2lvOTFjeFpXUWRPMFU4T1JlUjdiRmJwbFc5eVdIYXljR1d3cnA5UmpiN0Uy?=
 =?utf-8?B?K2VWM21rR3dNUGZzS1p2dU16U05ZTHUxS0ZjeXVRc0ZKNFZZWEFUUXJSRUl1?=
 =?utf-8?B?UllxVlNwMVd6UnJVTWp2cWp1VHJUZlFPZ1lyUm5uTnplLzd3cVc3TllhOTJD?=
 =?utf-8?B?QUpYa2tJSll5cEk4NXdXR1kvcndiVTRFbnp3MWwrd2trcDN6VDVWYTlIK0Jq?=
 =?utf-8?B?S0JaWnNOODg3Y0JRWDNIOUREcjFyM0RpR1NhbnhUK0FYNldTNHNsU0xyNUd0?=
 =?utf-8?B?MkVkZmREbHd6NEMvcjZyOVAvWHR5bXltK0RlUStuSnRSWmgwUVl4SERUeTZI?=
 =?utf-8?B?QUVhN0lYWktrczVEZzdSbnVoV0lXUS92L3ZzU3RxNkFLQVQzMml2V3kxQ3VH?=
 =?utf-8?B?Skw1a3Yvc1g4UnFrcDVIenI2dEdmRkowN1ZJTVMyL0hLOWRSTDFOV1F0YVB6?=
 =?utf-8?B?OHorVkVCUkRSUjdxYzFWT2JYQmx1NXE0dTZYQStoa21TMU1tc2VoNmJIcFBZ?=
 =?utf-8?B?MWE4dmNMTTVTb3pvNHZGZXl5eWlXajdHb3NobDN2eG1zK2hQRG5xWG5kWW85?=
 =?utf-8?B?T1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dff18273-eaf4-41b7-cb4c-08dac11cc2b3
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 00:04:09.7716
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +CHHZZn7KnyeNOPbDTyZOauUE1a1GSe/hDOYH4TBcD8k5VoLmO5wXfNYnf9vIZNo2TZph47vrP1+nDllTTBbvr384Qbb1U1xusEnx3r5CFs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5007
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 11/1/2022 2:43 AM, Shaopeng Tan wrote:
> There is a comment "Set up shemata with 100% allocation on the first run"
> in function mbm_setup(), but there is an increment bug and the condition
> "num_of_runs == 0" will never be met and write_schemata() will never be
> called to set schemata to 100%. Even if write_schemata() is called in MBM
> test, since it is not supported for MBM test it does not set the schemata.
> This is currently fine because resctrl_val_parm->mum_resctrlfs is always 1
> and umount/mount will be run in each test to set the schemata to 100%.
> 
> To support the usage when MBM test does not unmount/remount resctrl
> filesystem before the test starts, fix to call write_schemata() and
> set schemata properly when the function is called for the first time.
> 
> Also, remove static local variable 'num_of_runs' because this is not
> needed as there is resctrl_val_param->num_of_runs which should be used
> instead like in cat_setup().
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>

Thank you very much.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette