Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Rawat, Arnav" <arnavr3@illinois.edu>
To:     "ike.pan@canonical.com" <ike.pan@canonical.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>
CC:     "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Rawat, Arnav" <arnavr3@illinois.edu>
Subject: [PATCH] platform/x86: ideapad-laptop: Fix fn-lock LED on Yoga 14ITL5
  laptops
Thread-Topic: [PATCH] platform/x86: ideapad-laptop: Fix fn-lock LED on Yoga
 14ITL5  laptops
Thread-Index: AQHY8wAv76cQY3rRy0iDoZ7VASP7KQ==
Date:   Mon, 7 Nov 2022 23:25:13 +0000
Message-ID: <4785687.31r3eYUQgx@fedora>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bkrzjHx9WqPvVqmmYE418fnyavc5zBNIetj/UwkKsQ2MOAjwtFr89i/avY2J?=
 =?us-ascii?Q?WdBnBbudu1oFvnU3FRVXUB79Tz9nQIYHDeZhCdiz8468h3cM+kkn/EA3FLBK?=
 =?us-ascii?Q?PabuqOIi9LVwfBSLviKNqNneiAX51RBAg5ZQcb+Zh01RUR9iEIUGfs8X27Xr?=
 =?us-ascii?Q?2jgiKVI3er5o4ukbf7ppMtyGmUuoMbqTMTJqhgv7EhHCsLM6lNyoVY5EFN0z?=
 =?us-ascii?Q?qnwp6egSG5UtJpwGZsjfzwuxlnrLstWifwcbilWa8DNcTgbfVgt3hsy13N4O?=
 =?us-ascii?Q?lRvSlOPeK/ci5oWSz1VXmEi7zireZM0yY2TeSAdD5AOFzYHHMhi5i7u0xx0i?=
 =?us-ascii?Q?Sm1PQ6ohapSgmOwgI5LWsyHHKOeBEoKd3XLffalZ+ZOWZ1sx7sio/aLAR1/i?=
 =?us-ascii?Q?B3FEnqw8M77rgsk2uqGRj1jaxSVCa0mPyLwJeB67Ede1wv3SZW89v7ylCP77?=
 =?us-ascii?Q?Cc5xECvu01m1vK0s7DV3XmIVCGAv0BDDbwzSRCJ3vH1m4xM0Lu78Y7tVu3LD?=
 =?us-ascii?Q?ynMw9PSONfD83480LLf19PuKiUZ4K1UMBwMUmPzx6fry2k+jHqJgb+M7T/d6?=
 =?us-ascii?Q?pYV8uySk9Pdbh0M8AI1gfhwSnINvEVU7J0VMFi12dCbKQ2CHvz8+RKnwvSop?=
 =?us-ascii?Q?CwnXVeemPtcm1sjbPfPg/Go3/TPpvZcd/cfqwceWYFO2BjjU6pGKdamoWpcW?=
 =?us-ascii?Q?0Ro1OgaNGtDjPod/Xp5GNHDrYsIeqzkNnRMKKZk76O+NJsI3sI0XWDTKUNa5?=
 =?us-ascii?Q?AUjIClNbywsZSN/RvLFoW67X0Uuiw6nL1yE7EgJxx5bvRJ9e2RpFxltx7Vkl?=
 =?us-ascii?Q?yd0yEY15T+lNi5uJt+gv/jPrDMDemSzSXXrVFPx7scpxIryqqyJAf00V+wkE?=
 =?us-ascii?Q?dFBuxOaMGQ3Yl0mDYJvJWY2wSFaEKvxD19f77STEW/JJj8Vve4idazVpuT3a?=
 =?us-ascii?Q?BI9GQa/zjZlXtumP4y7ZuVuH3jh3vFvB3UXsN9/OQXgqT6CprpLjdrq+vOjQ?=
 =?us-ascii?Q?9AhzvWxjQPeBrol/h6+ceLiRN6ErCB+GScAIeYal26GEkgwnv09bHjjSKxgD?=
 =?us-ascii?Q?V494AkO4m0UsvDHr1TJ/JGC5ssVN2ledBU4hSDSGnjnWyn0sAgbh3FWPkc9j?=
 =?us-ascii?Q?pWA/cRFS5sb7BL6AlFjv6sGT0z5yxrl7HJ5WjuVYegM5k4RyltZw2zf0/+MG?=
 =?us-ascii?Q?OZgFC8GFqoq1DkRm4aZNpBUNXXIlGoeOUGJl3hV458BbJq6USdVETvNOji3b?=
 =?us-ascii?Q?QFth3njYIgz7Dm0Oz4cz1J4KOBZXoEwUrqoRHcgHiQowFBbTjMTqNwHxvolN?=
 =?us-ascii?Q?s/wzgTdZGxlEqJT1bYI0WGnw7t0trbdkfULPvrPhThG2aeGLBR9JbJyK6Se8?=
 =?us-ascii?Q?RxyPShhLeJ3Q+pqcBBHQK+PLgM1tACce5Ke4CXV0SR9tyBp+1cS8VJcWIWAC?=
 =?us-ascii?Q?Rj4f2QcVExDzUPec2SO6Fu0QwEI2mgWs5NnNHrHXhmndMVrGYEMH7v8w0R1T?=
 =?us-ascii?Q?wAlJvz5PeI4OZVaHMSn7icFQoNJmkRG3Qfz9sikUGIy96Ltk6Csb//QWPeNk?=
 =?us-ascii?Q?nLDeFrdJL8NehGOqLGBHGSa050ogS4CINewZANxA?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B075C22E410A5345A660EDCEEEDB2788@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: illinois.edu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5919.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf1ebfa6-2812-458a-d19c-08dac117527c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 23:25:13.8354
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 44467e6f-462c-4ea2-823f-7800de5434e3
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wNHZg2A6Go5FlCoFeZ9gI1nAmnegydrFgPK9CxZkaD5zxiEVR4SIvL44TLSouDCAKezgZ8wLEaves8xta56drQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7518
X-Proofpoint-GUID: M3csJso8DdF9xg2Ar0X21gCfvy5iQJgN
X-Proofpoint-ORIG-GUID: M3csJso8DdF9xg2Ar0X21gCfvy5iQJgN
X-Spam-Details: rule=cautious_plus_nq_notspam policy=cautious_plus_nq score=0 bulkscore=0
 phishscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0
 adultscore=0 malwarescore=0 mlxlogscore=999 clxscore=1011 mlxscore=0
 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2210170000 definitions=main-2211070175
X-Spam-Score: 0
X-Spam-OrigSender: arnavr3@illinois.edu
X-Spam-Bar: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From 5bce4f5860d54e125715d896f144add831d19483 Mon Sep 17 00:00:00 2001=0A=
From: Arnav Rawat <arnavr3@illinois.edu>=0A=
Date: Mon, 7 Nov 2022 17:12:41 -0600=0A=
Subject: [PATCH] platform/x86: ideapad-laptop: Fix fn-lock LED on Yoga 14IT=
L5=0A=
 laptops=0A=
=0A=
The commit 3ae86d2d4704796ee658a34245cb86e68c40c5d7: Fix Legion 5 Fnlock LE=
D=0A=
set the WMI id for the fn-lock event on some Legion 5 laptops. However,=0A=
the same WMI ID is also sent on some Yoga laptops. Here, setting the fn-loc=
k=0A=
state is not valid behavior, and causes the ec to spam interrupts until the=
=0A=
laptop is rebooted, so include a check for this line of laptops.=0A=
=0A=
Signed-off-by: Arnav Rawat <arnavr3@illinois.edu>=0A=
---=0A=
 drivers/platform/x86/ideapad-laptop.c | 2 +-=0A=
 1 file changed, 1 insertion(+), 1 deletion(-)=0A=
=0A=
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/=
=0A=
ideapad-laptop.c=0A=
index abd0c81d62c4..f529410d7015 100644=0A=
--- a/drivers/platform/x86/ideapad-laptop.c=0A=
+++ b/drivers/platform/x86/ideapad-laptop.c=0A=
@@ -1501,7 +1501,7 @@ static void ideapad_wmi_notify(u32 value, void *conte=
xt)=0A=
 		ideapad_input_report(priv, value);=0A=
 		break;=0A=
 	case 208:=0A=
-		if (!eval_hals(priv->adev->handle, &result)) {=0A=
+		if (!eval_hals(priv->adev->handle, &result) && =0A=
strcmp(dmi_get_system_info(DMI_PRODUCT_NAME), "82BG")) {=0A=
 			bool state =3D test_bit(HALS_FNLOCK_STATE_BIT, =0A=
&result);=0A=
 =0A=
 			exec_sals(priv->adev->handle, state ? =0A=
SALS_FNLOCK_ON : SALS_FNLOCK_OFF);=0A=
-- =0A=
2.37.3=0A=
=0A=