Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     James Smart <james.smart@broadcom.com>,
        Ram Vegesna <ram.vegesna@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, Kees Cook <keescook@chromium.org>,
        Sami Tolvanen <samitolvanen@google.com>, llvm@lists.linux.dev,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH] scsi: elx: libefc: Fix second parameter type in state
 callbacks
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1r0yejgcv.fsf@ca-mkp.ca.oracle.com>
References: <20221102161906.2781508-1-nathan@kernel.org>
Date:   Mon, 07 Nov 2022 22:05:36 -0500
In-Reply-To: <20221102161906.2781508-1-nathan@kernel.org> (Nathan Chancellor's
        message of "Wed, 2 Nov 2022 09:19:06 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KnIdRYWlxZQl9t+Q3HcfptU08N7Zrr2myf5/j4qNk2uqOVY0I4AvR5Ye964c?=
 =?us-ascii?Q?RhSuUpXa44B+zX94N5Q/QOXE/h3Gxh/32NDqTW2UHaeWmGjZTjZcnH9RWR/Q?=
 =?us-ascii?Q?kSUamy7wXMmYa+yvk3Zr7imfptvfZ6KectZ+0Zz8dAMfbU1bH2tD8H98fvNb?=
 =?us-ascii?Q?In/cAwG0RUCROi7tH/+bX4mIjCwGylz20idcXDUoZLLipXUKWzumCQIp/Qm5?=
 =?us-ascii?Q?4X3xZ3WVyYjcN+/lZlxyB3gZSkSPLDZS/yOd9FLcGh5nVs4Vg/N2W8z0LE5U?=
 =?us-ascii?Q?gn7jO7svm2nv/cy0vJFQaiMDytdl2CeABjOfNi9JdligKLt254MhOZ99SxGZ?=
 =?us-ascii?Q?ZnC1hnp+FCoiTcotLuq2Lhd3s3mDdlZIxc/4zLjNXXt2HsuLyjE3cXa34doi?=
 =?us-ascii?Q?EZwwhWk/TJSjAt7RiMhtY3WdiSNdO0oFcLackMLv8VnCfAXJoRJcAjdebWFw?=
 =?us-ascii?Q?zMTbam+FbY7XUeRnd6W2y6Ut+dSDj+Nx+LFSBMFMeemkfFHsv5YXTRfm7mx+?=
 =?us-ascii?Q?zQjaTjYAe0RNklB/f4tfU2lcC2VSdZvILafvji3kO79cHcuGp5aPrkKy0tUm?=
 =?us-ascii?Q?mUA1f/JeiLNJ6LYYIPtJ7oySInZ7JuCL3LODo5j4/hy4Cx1ZvL0eRHaljx3O?=
 =?us-ascii?Q?nG1siy5jRJjBD5gX2gTtkOPqsMTUVCLYxYKX896Iz8QNYzHuOPXALnZrFoOS?=
 =?us-ascii?Q?73AHtxOtgKJyOTon/aK25KdVOvxYWrhBGegJA24FoJx63xLBLqJPtFSSx8vH?=
 =?us-ascii?Q?a/cW+O+ztNo/I6QC6UAO3QtSJizGg55pRTpxBgXTbMN0ftgv5HTAP7NHxmKZ?=
 =?us-ascii?Q?NScLGH7S8MheLDYJYKyCN3GZV3ZESzhakuTeTglJLWaf+ijdbDRWgpTF4RIA?=
 =?us-ascii?Q?LOZr38tUfhwUwgEv5jVwmQ6QK0LPD6/L0Ak1m08bpXp2nWz7WoWx3SNnx+ma?=
 =?us-ascii?Q?A7tQe9gkqmHhKSdV4rDHUJX3jOxwqIB0rF9K+ig9gQ9PW/jdkVSKADaqAjHN?=
 =?us-ascii?Q?54r6571po2KO54uWv6TaE3ZCUc/o6N2CyDmKo1Aec1vrzTNy7hepihKuC8hF?=
 =?us-ascii?Q?4oSYVVA/rQTRbPp3mpUr8HMKFVIYtdNkPdrPZbtYsg2PKZMKhgY0R3lpjd6U?=
 =?us-ascii?Q?k2448Ry1POFLC/eGUKkEkNb1H2Njx9oVL8Qs426cNZAqJItqVfF90MTFgIO6?=
 =?us-ascii?Q?Ylrvm6gAIj63mfi5cLsuxPPl8A+qXYQiSrSnfxDrPnGNTybouSbQ/Wo2EqDR?=
 =?us-ascii?Q?genLkbelv10N5QhXZ7HSV2i+LooZV9mphyW9/R9N65AFQjxhr8ELD5Ws/Hwk?=
 =?us-ascii?Q?Scu5vwiL15VQOSwYZBJkHJ0LqnUjSiE3MlztvC276/ZSzI14ZUTVB+nGWawP?=
 =?us-ascii?Q?RgLw3dqn9+LpF0ei60ZTxRXYPvud7/n8ok8kpLZiPjcOrz1moJ7mzRUawpV4?=
 =?us-ascii?Q?IObrfFrEHEv+KGM523GSZLB78Q8P0XvTssWh7CvETtG2XN5FgBzaER+0V1Rr?=
 =?us-ascii?Q?GByLH4WwqFD/fBm2CdKM4Ec0API0ovYXwaeCw4FR8RURXFZemhHMwanGcqRB?=
 =?us-ascii?Q?Juo4JabdiwSUIdnz1iiGimTV7dTnj3E5t5aHHoMGLsrp4Z4YWcIOtGPrHaxj?=
 =?us-ascii?Q?bA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01ff9a8d-ecac-4c67-4290-08dac1361d5a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 03:05:39.3070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /jY5ws2tH6a81GqFUevKsbDE1vmZ4hE3N/kIh6nM5kBWKGeS0JMcRpZ5jxvZipBTQh2G/zblybV2J9q7DWTGPGltls9G1T7UkcuKGtZqhYQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4710
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_11,2022-11-07_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211080014
X-Proofpoint-GUID: JOrFgzFlA4NqNcBRKmlYT1jX9th2M3Qi
X-Proofpoint-ORIG-GUID: JOrFgzFlA4NqNcBRKmlYT1jX9th2M3Qi
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Nathan,

> With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
> indirect call targets are validated against the expected function
> pointer prototype to make sure the call target is valid to help
> mitigate ROP attacks. If they are not identical, there is a failure at
> run time, which manifests as either a kernel panic or thread getting
> killed. A proposed warning in clang aims to catch these at compile
> time, which reveals:

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering