Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Khalid Aziz <khalid@gonehiking.org>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: BusLogic: remove variable adapter_count
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq135aukv3q.fsf@ca-mkp.ca.oracle.com>
References: <20221031160512.872153-1-colin.i.king@gmail.com>
Date:   Mon, 07 Nov 2022 22:01:35 -0500
In-Reply-To: <20221031160512.872153-1-colin.i.king@gmail.com> (Colin Ian
        King's message of "Mon, 31 Oct 2022 16:05:12 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K3ILN9GGnC7Jth4qvIi0jj12hC2fYblRy1JYXjerFjvgoaYnlkxKy0Dl1ITw?=
 =?us-ascii?Q?Frm9L1wEG7T26AMK8a80kleUIWppdHBPLzL4qQTkjPjweOyJ6dh2zu6ga/hd?=
 =?us-ascii?Q?cLq6jaHvkETeWY6xnoYRvebRx+zqiTVgoezhNo7agpP+pVoaOtupry/a21ul?=
 =?us-ascii?Q?6SABnyuDPNz2dSOVcphGQf481AUMlI2S4HRui1CFopsBah1TnpnFVCfK7l7O?=
 =?us-ascii?Q?vBXMSXi6WNoyTmblIUXvw5xVwVKXobe/SWabPznBXl1CEuCB6VwiP2Cn7hBL?=
 =?us-ascii?Q?abJzL+2hHNjyJUDVO8WnoJAI2U5Ma9MrcC40jMsky7amFFPjBnmye8ofsduc?=
 =?us-ascii?Q?K8UiyJXsQMfClg0kr9P9VMiTlbJR7cQBv2sTYbSfchQPTNSAsGuTGonTTCUS?=
 =?us-ascii?Q?5syJ7o9FPy82TgG9KbrAx5wWIhnbSkZJRha1mXx/anAlidhBgwUDEi820JWo?=
 =?us-ascii?Q?AhTaIP6GQcAgzJg5bYcrivywkZkzTm+NU5qC5QPH8w0A8S4FaZwayiB6N5Qa?=
 =?us-ascii?Q?f5d/EIIH3sdjG1ipSL7tRrHFZHoFg/3iRVYqSEsAzIUG/zWNDjv6yHnNmMC0?=
 =?us-ascii?Q?URlCqer/FSvcz8PFhuJIPHpdJEjCKj/1FstOgftWb/VELMGEbsr4iflff2PI?=
 =?us-ascii?Q?Yrr9TzQ8bverC+9XmMi/iSMgjvXF4alBemflipUpxH9nyw7ov5FKzIZeK4EA?=
 =?us-ascii?Q?LtxARhfgD2RzExx17GPy+9SIJSx/2WozmDA5j3ZXuxcw2vdLOMfbSB411VA3?=
 =?us-ascii?Q?713D1mGNcz/IWntwvi7ol6xOrbrTBYhlNwwiPklZL2uTEkuzZEkAYH7OgZ37?=
 =?us-ascii?Q?OlB163VQ084TJ8guM/g1ATSEdZ2vtJzgrLfnKnpuju/j/p+F4JVcu5VUoLv8?=
 =?us-ascii?Q?G7xfOuToxZPk8t4OVRIqu3mVA5lpFpR3FAI0daU8twB2jvoH3RUtfveFwf0m?=
 =?us-ascii?Q?1zy3NdAHVaM7xGnACHJvqOo9VkBZB9nABMj8ifPatHWP5y2P5HjYjfk+zGCb?=
 =?us-ascii?Q?GVyjkd3xC3zWL2qEKXmw/o4ieUFeSL5SgIUsRUiQrMj1/+2J//3D9Bi72oar?=
 =?us-ascii?Q?DqF0bde/gw3SUUS/BQjGE1E2aLqZ1YiwWSLujpgdXsP0SGqPbbT5AXFwQ8MH?=
 =?us-ascii?Q?fKd9G9Gs+0fJgt0pZrc1iIKQ+A3HC5Cev2gCo3+j+gswSmNYQshnnzesnM3H?=
 =?us-ascii?Q?oqw2NxuQ6Rwa3WyrOl++nCt4Qp6FsfoLMsl3JF1xLw9xAelMYmM0WklAshNT?=
 =?us-ascii?Q?W+q/JpHKh1f7wKNfwZXdhanHyFQOpS7V+MIVe9F1WJr16SAlYMBPf+wFBddS?=
 =?us-ascii?Q?ji7h1Ou7fzbAw3pnuyavmDRxiX6hlwBwabbql2WjzeQsYgkSq/1zyM6GaKat?=
 =?us-ascii?Q?IkPXoanC9NK6SjaOrk/8EtTrj3XrVFgNtJkIIY6a0gThoW7P8SuMNNO8PX4d?=
 =?us-ascii?Q?OTBhQcTCM6ZGGbx9cw5GboETGTtNPt6gnmFnNHwsWrdVMQzvXKHi+UOncU0Y?=
 =?us-ascii?Q?kkNTphh7hgfr85H4o2b/aKdsDdDVdjcP0z4h35Vq18yPhcC5hyayxOeJCioW?=
 =?us-ascii?Q?cvSMpRwynlNxXHzpBjDKTlIKsYeFqtKxEfu4wuINcZ/Jtf8O+CN7w/BKr7io?=
 =?us-ascii?Q?aA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d97c2302-451c-41f2-c4b2-08dac1358d9f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 03:01:38.2956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7QLEc612gZjB+/8Y1ycMJg3zQmfassmusFuGpKBLBf7taKnYVBGCuaAdcjgCcjfaEzPGPjmMCnMAoZZkVqwjkEaYfTD32REb8d9/2v50D+A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4710
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_11,2022-11-07_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 adultscore=0 malwarescore=0 mlxlogscore=881 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211080014
X-Proofpoint-ORIG-GUID: LLICBT5aCUeaiCmDvl2Xnv5RRNoxuHZe
X-Proofpoint-GUID: LLICBT5aCUeaiCmDvl2Xnv5RRNoxuHZe
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Colin,

> Variable adapter_count is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering