Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2860571rwb; Mon, 7 Nov 2022 19:47:36 -0800 (PST) X-Google-Smtp-Source: AMsMyM7wD80XcnnzefvzyHYpWTwWb9mPOA9TkcuvatTMgBEJNfNRhVTpk0uMr/aw7IplRF8bgfwG X-Received: by 2002:a65:6d8a:0:b0:43c:9fcc:cb24 with SMTP id bc10-20020a656d8a000000b0043c9fcccb24mr46791523pgb.477.1667879256242; Mon, 07 Nov 2022 19:47:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667879256; cv=none; d=google.com; s=arc-20160816; b=V5hTWCu2giHBnknFRnEJKcrXiY9c33UMon473CYgC+dVO6E/k87KRZzI2dZIi/zzA6 vzSGpM6z1F1g2m5kCeBqHOSeaXkaonpGftQF02AqwKMakzO0L1DwVYsyhfBLMDnZJ1H1 z2n3acLaP96rQzWkfXNJtc/bkMSIh9H8UwuJoYfhML2qPrhK1j/q5NLjgX0B80NxsTHL NhP5wx8KkXFwgxZdQYBuUoT8R6ExL2vZf57jWy5T/+VM0btglN8FdPQ5H7OTHafVAoCz 9NLxyL14ZBy1hzRUSF3exzFOJTw9yvngaonFlb910l0AM4WBy9XuBioGvwF8uKH5e9FP IK6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=aWkAlq3VuN4D/ZKgFmCky9R9Ed6Pzf98RTYU5qijBIg=; b=Z3zo49PvbrXPJd7EiFL+dNyUP/nT6eNV/G12rMxUP8kZTDIEZddDvDYl+72XSbhz7M Vy/jc32QE8lhL3VvRati5JAlyhKoCKyBWLdxg+peRw5BnEYSlUlrQX6+So9zNscWr934 TXm7NdG530ozkFExorosPTNqwcg3SOuHkzk8ddKxL1fUshZEsdq1Y1a2SuaRY+eRiAKa zP4as4FtjlQ/lAdeRaZ02UX1sLEqO2xNqPQbXn7/S13XvOFVqdrBUuTdQ9OmFG0o7Ntm cko2KjcjoBVnJOH7vwFoq+NUgu1OSO8TFQHG0MZsJK11JumwxHySnv/10vqOdbpwnOMV 2ltQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=acKb8tRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nl10-20020a17090b384a00b00212eb5485afsi16068187pjb.77.2022.11.07.19.47.25; Mon, 07 Nov 2022 19:47:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=acKb8tRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232676AbiKHDGt (ORCPT + 91 others); Mon, 7 Nov 2022 22:06:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbiKHDGc (ORCPT ); Mon, 7 Nov 2022 22:06:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 836B5303E6 for ; Mon, 7 Nov 2022 19:06:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C1314B8091C for ; Tue, 8 Nov 2022 03:06:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FBE1C433D6; Tue, 8 Nov 2022 03:06:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667876788; bh=QF78iOGcajcnk4Z9GZuE7IjkV7FmrSLX0pW9ceH+Kl8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=acKb8tRhXB8nu+hrly0zCkR3DiQc2b3rI9oVBOwQ4FMxtJEgKciwbkKRbY9sE2A1t tY9A5NF5vey63bOrykf001ThaeMyLjXuJKRbF5dysP+j8t4OVZqM5yr+JxqSmTUvZ7 WluwTKS0iJEAlINpIOyRVuIT7xFAw4L+x5WTKMosIBFdyVWGkMcwtuSL6lpoad2ZQW I55lCvkZDzrs/BlvIbPTbjBQ98fI4Ra5A2ibDaqUOyD/82dMHkJ5MoJi+UStjkYazl mD8iEEfkceGTh2hoR9c+CNQe24T4zqxqSI7fIGnwk54W+MY7dozCbJiT6hKdX1a1yi fOVmfYfwjbvNw== Message-ID: Date: Tue, 8 Nov 2022 11:06:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2] erofs: fix general protection fault when reading fragment Content-Language: en-US To: Yue Hu , xiang@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, syzbot+3faecbfd845a895c04cb@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, zhangwen@coolpad.com, Yue Hu References: <20221021085325.25788-1-zbestahu@gmail.com> From: Chao Yu In-Reply-To: <20221021085325.25788-1-zbestahu@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/10/21 16:53, Yue Hu wrote: > From: Yue Hu > > As syzbot reported [1], the fragment feature sb flag is not set, so > packed_inode != NULL needs to be checked in z_erofs_read_fragment(). > > [1] https://lore.kernel.org/all/0000000000002e7a8905eb841ddd@google.com/ > > Reported-by: syzbot+3faecbfd845a895c04cb@syzkaller.appspotmail.com > Fixes: 08a0c9ef3e7e ("erofs: support on-disk compressed fragments data") > Signed-off-by: Yue Hu Reviewed-by: Chao Yu Thanks,