Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52f848ad-fc12-c360-bb91-c1d9cd14853f@meta.com>
Date:   Mon, 7 Nov 2022 22:38:31 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH] selftests/bpf: Fix test_progs compilation failure in
 32-bit arch
Content-Language: en-US
To:     Yang Jihong <yangjihong1@huawei.com>, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
        song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
        kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
        jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org,
        sunyucong@gmail.com, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221108015857.132457-1-yangjihong1@huawei.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20221108015857.132457-1-yangjihong1@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akhBVTJLQVlpc3JaemVHMkcxYlhDa1M1VlRFeXFJMjZJVFJLcGFEa29SQXda?=
 =?utf-8?B?dDgxT3d2dWVKS2pacE1MaitjVG9EdmtaS2dJQ0JaKzNjU0dlRXRiS0xmdlY3?=
 =?utf-8?B?Tk9IaWdDdE9FMkNoRVI2MHdod2Z3WjhpeGhlYjJNWHhXMVF4ODZaS0M4V3ZR?=
 =?utf-8?B?THBzaVU2Q1JRbHRwNDhGOXprd0QyMm1UQnRoZnFhYldESGJVRXNiS1dqc2F0?=
 =?utf-8?B?cENuSnpOWFlQQ3UybWF4b0ZsK2VVUDc3dVZuZlFGSlpPM0JvRXErQ2FnbDlR?=
 =?utf-8?B?eWNZcVVETEI5WXdBU2dwWkRJTzZpemtydzVPRlZwUDR5QTFmR2xUTnVJbkJR?=
 =?utf-8?B?RXFzRHA4bS9nRFFwU056Zk4valhpSnRvSGk1RHBKWFFMY2Yvd2ZyVGc5bFZT?=
 =?utf-8?B?TkEyVDhTZS9Kdkc3ZE1TNnVPWndPbUgwQUk2MWduWXo3bDArMHFtSHBSY1Bq?=
 =?utf-8?B?MVJtVC9ISEJHWU1MdTN6SHZHbmxPSEZiQmJxUGExRFJzdEx2a2xuV2dxQ3Mx?=
 =?utf-8?B?TFh6enVTMHBwT2E1M1NiLy9ZMFJ2UUxCS0hoUmt3UmJmVjVsT0NmYUx3c2dI?=
 =?utf-8?B?MjcyVmdmSnB1MlMzUU5VNXlmY2Iyc1ZyVm95MGFldkcvQlhrRE5IU0kweThw?=
 =?utf-8?B?VEJOSWYzdVRXMHNtb0M4N2paeFpHSTh3d3NSUFN5SHdUSXB0VmhYRG8yUkhi?=
 =?utf-8?B?czBKdlNmb09MdGhCdDg4RCswU0IxdXBnRXp6bmtCLytvRHRvMTlKN0k2cFo3?=
 =?utf-8?B?N1gwUCtXMm9JZGxuNlBJMUthZDdBaGU2Z09IVkZEdm84dm1pUE1UVXBaTXJt?=
 =?utf-8?B?T3FhTTdrcVg2eldhTHpycXV2UkZ4amRqL2JjYThDcGMzWEhNT2lTS0dpdFlG?=
 =?utf-8?B?cGdzRGtjQVl6ZDdhK2RSNU44am5WRkY1ajhHOXpIcGM3T0FTRERtY0pmUHcy?=
 =?utf-8?B?QXc5QUwzZWxDd2gzeVZlRk1JcFJLTDllT0luT2w0Wm1YejVyc0lDZzBiOUZW?=
 =?utf-8?B?dHNZUWlhdmRBWU55WVQ4VDV3UWZjdGM0QXU4OHhzZ2liNE1JeGYzVE0wZVQv?=
 =?utf-8?B?bGcweFRmeHdkeUk0cVdrWitPY3BEVXkrRGVtbXVwT1NWNVlBZTdwVGc1bWxk?=
 =?utf-8?B?QlV1LzAvSXgvWjhSbUhoMVBJV0pXbUFjZ3lod2M1SVlreENIWjExTXZ1Y1A2?=
 =?utf-8?B?ekV2NWJZN3FRVEVOZFRwaGtENDBDbmtUVUdiRkU4Tld2a3daYUVUYkhWUzBR?=
 =?utf-8?B?YXpWZFRheDlzYlVzcHl4bmdyUFBTbjNGcTlVdkJVN2hQb1k4SzFVK2paQzcx?=
 =?utf-8?B?N21VSm5wemJQVzFxN3g1Yk9LbWpNVHlPNGRCakRRM0drK2xxZjQ1RDMxMXNK?=
 =?utf-8?B?SFVOTTNMOWF3Qjh6aVhwVER6cW80TW9JTVh4OEtITUVEZWR0WFVkZkoyT1dM?=
 =?utf-8?B?SXYza0RwajEyV1RqY3NpRVFxdXFJc08yaThVeHVzYUZRa1NmT01sT1N0WitK?=
 =?utf-8?B?c28vU2pxbW5zVlk3TExXWnFSMGNKcW1mU1hYT0wwaVZDRlpwSWJ4QStPUFVM?=
 =?utf-8?B?dE5uY05mWWhwcUtxL1lMYVdkWDg5NTBFU29GTTNuN2UxSzZhQzVmdVpDVXoy?=
 =?utf-8?B?dG5VWUxzdmpFSVp0cmtOVDFjdS9JUWdVOWRFb0J5andCOFN6bUxKUit2eU1C?=
 =?utf-8?B?V1hYTTVMYmtBbUV4UUNqb29lV09OT3gzL0RLbnZ0YWtUbWVYNUFJTEdmMVh1?=
 =?utf-8?B?Z0dhZzRpZnZDQ2xmVi9td2J1UEY3TldmdUdKSlJ0SEppamZob2JZbXlmeXB5?=
 =?utf-8?B?eXhYejFRYmZnSnlCL2U5N3doZ2Y5aE1MTk83NFdPblVISzA5ZCt0VTFhZHdH?=
 =?utf-8?B?ckRLYzd5eEcvQWVLWUxyejZla28xaW8zL2NnQ0duVmNyZmwwL0FHd1hsVDNC?=
 =?utf-8?B?NEg2VC8zdXR0THg3SjRobE01MkZmbE0rUXFZS2VnNkppbDlGUWNEaS9xQTQ2?=
 =?utf-8?B?RVMrV0lRZ3BrTjZnRDdQWTZzV25BRHRmZGdId0ZwVFU4Zlg3Q2h6WVB6RVdM?=
 =?utf-8?B?OTV5YXFoU1AzQ0p2S1BjREZzbDVySWVVY3BMSEdZOHQ3T3o1cWVlbW5NNXBD?=
 =?utf-8?B?VTFweGNBbHpydk1VdUlhSGdCcklGRHJUeTcrcUQ2SHhHeU5Eb1R2UXNtZDEv?=
 =?utf-8?B?ZlE9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9b06fcf-4efb-4a8a-19ff-08dac153dbed
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 06:38:34.3791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D8SgBSiYPldhZqJZJKAkm9v5+tXabaJb2dBMRzIa6/ky+Z+2JyF87cnzgEYnd/AW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2660
X-Proofpoint-GUID: NHgpkUM3xQ5uTHwJSnf785nOl-kTj9Zs
X-Proofpoint-ORIG-GUID: NHgpkUM3xQ5uTHwJSnf785nOl-kTj9Zs
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_11,2022-11-07_02,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/7/22 5:58 PM, Yang Jihong wrote:
> test_progs fails to be compiled in the 32-bit arch, log is as follows:
> 
>    test_progs.c:1013:52: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
>     1013 |                 sprintf(buf, "MSG_TEST_LOG (cnt: %ld, last: %d)",
>          |                                                  ~~^
>          |                                                    |
>          |                                                    long int
>          |                                                  %d
>     1014 |                         strlen(msg->test_log.log_buf),
>          |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                         |
>          |                         size_t {aka unsigned int}
> 
> Fix it.
> 
> Fixes: 91b2c0afd00c ("selftests/bpf: Add parallelism to test_progs")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

Acked-by: Yonghong Song <yhs@fb.com>