Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b714ad78-4689-ad0b-9316-efcc1665f6bf@huawei.com>
Date:   Tue, 8 Nov 2022 15:46:32 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: vmlinux.lds.h: Bug report: unable to handle page fault when start
 the virtual machine with qemu
To:     Ard Biesheuvel <ardb@kernel.org>
References: <cbbd3548-880c-d2ca-1b67-5bb93b291d5f@huawei.com>
 <CAMj1kXESRP9RvhPC5Wgg38BqyCn5ANv7+X9Ezyx5MXNNvEZ1kA@mail.gmail.com>
From:   xiafukun <xiafukun@huawei.com>
CC:     <arnd@arndb.de>, <keescook@chromium.org>, <nathan@kernel.org>,
        <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <yusongping@huawei.com>, <zhaowenhui8@huawei.com>
In-Reply-To: <CAMj1kXESRP9RvhPC5Wgg38BqyCn5ANv7+X9Ezyx5MXNNvEZ1kA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thank you for your reply.
We tested your changes to this patch and did fix the issue. Following the
solution you provided, we recompile the kernel and successfully start the
virtual machine.

在 2022/11/8 0:00, Ard Biesheuvel 写道:
> 
> That patch looks incorrect to me. Without CONFIG_SMP, the PERCPU
> sections are not instantiated, and the only copy of those variables is
> created in the ordinary .data/.bss sections
> 
> Does the change below fix the issue for you?
> 
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -347,6 +347,7 @@
>  #define DATA_DATA                                                      \
>         *(.xiptext)                                                     \
>         *(DATA_MAIN)                                                    \
> +       *(.data..decrypted)                                             \
>         *(.ref.data)                                                    \
>         *(.data..shared_aligned) /* percpu related */                   \
>         MEM_KEEP(init.data*)                                            \
> @@ -995,7 +996,6 @@
>  #ifdef CONFIG_AMD_MEM_ENCRYPT
>  #define PERCPU_DECRYPTED_SECTION                                       \
>         . = ALIGN(PAGE_SIZE);                                           \
> -       *(.data..decrypted)                                             \
>         *(.data..percpu..decrypted)                                     \
>         . = ALIGN(PAGE_SIZE);
>  #else