Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3229737rwb; Tue, 8 Nov 2022 02:01:44 -0800 (PST) X-Google-Smtp-Source: AMsMyM4cZZtkbhoKzZOYGRwZM5PwXoLDL6cJ/AVY3Kvy5uhoHLGcKCYBbmhSRisokenlE8sG1ikf X-Received: by 2002:a17:902:ef95:b0:186:8376:2084 with SMTP id iz21-20020a170902ef9500b0018683762084mr54287562plb.48.1667901704745; Tue, 08 Nov 2022 02:01:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667901704; cv=none; d=google.com; s=arc-20160816; b=xgJ0ZmN8TnTMPdzQl9i+0442NcyohpSriGDLtHhyGgKLWnXRRXN4rIS6bPfo+lM8Yw /M0ZADwZSZkBEHuSh/jAS9kx3nBNqwZoy9qaT6aHunf0BbxCjjE6Mqmqm8tRYchWE7XH Z8zeZcFYedB+krEPWl5GVyE+2UUjQfL0Qh6S5tQlgY5Hv9S+rGwWxEKFk9lmjaQ4K2xh 9TWk7DgnTiHrL1g5Xd0XJhcd8FSpEXw4hDINgLCMRPxpTrvB3buJfRyvbwo2v7wC1ffu DUWbIWEiNEYNCWAcp3aXWotC6ZHrTMom3QYrAqunnFNrNFtzPgQ8IPfUQInt0Uv7S+/R GPhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=nwGH3xncezy8aE+xydBamp1X2UzAG0+D2pQxSdjT3Go=; b=kMGW/5ulyHvDmJZvRk89OSQ5mbEERZxzMl3fhVSp/wJGqOZG0Tx7pyW6HW0AmWhdyp CXiu9VcLqhHrIIgXEmH+LV/2G8Nshn60QZ7NhJYRLSMkJZcyncKS6V1SBSqgC/8/H7+7 SJdKXBgMDlvoQ4SURaXSXE7Nka7j5zWH28feYa4aVFsQ83I97U/6tdHCGtZkg6ZYSSwr +nl9HW6qrdYXH0KKcNJIegABnpymwDztubQP+bfH30RkZ1o5SGWN7U7sG+JA+hg8y0+E nbsdvBZjI1eIDaOB5+vBJ4yhC2lLXjKYycJ+sq540Q42Hs70gDQ/qKZA/PkwGwmfDGlp 1sJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PguF6LnL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az6-20020a056a02004600b004703815aa10si14596094pgb.721.2022.11.08.02.01.32; Tue, 08 Nov 2022 02:01:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PguF6LnL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233805AbiKHJkw (ORCPT + 91 others); Tue, 8 Nov 2022 04:40:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233831AbiKHJki (ORCPT ); Tue, 8 Nov 2022 04:40:38 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41FDB317E9 for ; Tue, 8 Nov 2022 01:40:36 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id t10so20297887ljj.0 for ; Tue, 08 Nov 2022 01:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nwGH3xncezy8aE+xydBamp1X2UzAG0+D2pQxSdjT3Go=; b=PguF6LnLRQ/cpoVLZlxFFNefduNiIZHPgBoSTGmze3dAN+AliIFf9pQcwZzBAdrJs+ bT4oyiQjoIIApKKZOQWKdEqeMyMEW3JoLlrVuHXITZgB0NkyBzyEGfyBz/CPJBBSqZXi KNj22sWWhCl2xPc0pPLBw0D/wR1jp2xksw1JazMlcvaHQTS0eAbELD3pwm/Ob7EcxfNS O0k8jjEUg2eOCJvJgyGpDm7NVALcKS/4qOhxrLMlosDiZrSmoEtx0eIeVRXcSB7jtY8r uOCvGB64HPdapt+WCwWGecQctc1t0p+Wt8JHyRfbRFa//ys8PO6jHc5Ocsq1hrynOebU 7VQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nwGH3xncezy8aE+xydBamp1X2UzAG0+D2pQxSdjT3Go=; b=Knqz/mkwNiNkENaoahC6gFcjfMVdgMqrUpJa7hiF+j24PY6wRAnvXXyzp6d6Aae6YU B4ubpk8NxFWwBpMjkfdlRF6y60HjYFB5iJdjUpspjU97XCyhOm35QWnuJxl+IX7OJB2T /GrTm+W2AIH0Oe8ENi2yQKdopRbkhSsOnszNUsSe05cWGBFefKf/E1uMLkpD34eGfde0 ro7uBOg8QXNbZC4biUf1m6tGZUS5cuwArojToE6kFmyeNmLNNALxZ4Ter6OfBsWLNYeS 74BZOjSAAlkttWFHXfgbENIcxg8Nn+EEAIHkjdTh1VHh1nvUMJ7Hq4zDkRTmeai7vVpQ CI6A== X-Gm-Message-State: ACrzQf2kOviKCtxrPGkIQc0QbLrt4psTWKmzoWW3chSwr2eYLJMgripa aG/Gs6ouLHAp8ovYr6P9zLm92g== X-Received: by 2002:a2e:978a:0:b0:277:107:725f with SMTP id y10-20020a2e978a000000b002770107725fmr17989655lji.417.1667900434663; Tue, 08 Nov 2022 01:40:34 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id u28-20020a2eb81c000000b0026dc7b59d8esm1658719ljo.22.2022.11.08.01.40.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 01:40:34 -0800 (PST) Message-ID: <5791ab49-debf-53d6-f076-0e46c4f392ea@linaro.org> Date: Tue, 8 Nov 2022 10:40:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: Coverity: gpmc_is_valid_waitpin(): Control flow issues Content-Language: en-US To: "Niedermayr, BENEDIKT" , "rogerq@kernel.org" , "keescook@chromium.org" Cc: "gustavo@embeddedor.com" , "tony@atomide.com" , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "linux-hardening@vger.kernel.org" References: <202211041233.4D45359E7@keescook> <7cdf3d14-3f1b-7cd4-e8b9-e94b5359bf82@kernel.org> <57664014384bae015d593a7c6c6b7715fda3e89d.camel@siemens.com> From: Krzysztof Kozlowski In-Reply-To: <57664014384bae015d593a7c6c6b7715fda3e89d.camel@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/2022 09:15, Niedermayr, BENEDIKT wrote: >>> Another alternative with less churn is to leave them as u32 >>> but make GPMC_WAITPIN_INVALID set to a large positive number. >> Ok, I will fix that. >> Do I need to send a new fix-patch on top the current patch series? >> Or should I just send only the bugfix-patch for the coverity-bot? >> > Sorry, another Question: > Is it somehow possible to check locally if the bugfix actually fixed the bug, before I submit the patch? I think only if you have Coverity somewhere in your company set for testing kernel... Best regards, Krzysztof