Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fd9ee5df-0b9d-59c1-92c6-4874312aae1c@linaro.org>
Date:   Tue, 8 Nov 2022 12:28:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v1 5/7] ARM: dts: hpe: Add UDC nodes
Content-Language: en-US
To:     richard.yu@hpe.com, verdun@hpe.com, nick.hawkins@hpe.com,
        gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
        balbi@kernel.org, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20221103160625.15574-1-richard.yu@hpe.com>
 <20221103160625.15574-6-richard.yu@hpe.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221103160625.15574-6-richard.yu@hpe.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/11/2022 17:06, richard.yu@hpe.com wrote:
> From: Richard Yu <richard.yu@hpe.com>
> 
> Add support for the USB drivers on HPE GXP SoC.
> 
> Signed-off-by: Richard Yu <richard.yu@hpe.com>
> ---
>  arch/arm/boot/dts/hpe-gxp.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..60f2d3b15d90 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -59,6 +59,36 @@
>  			ranges = <0x0 0xc0000000 0x30000000>;
>  			dma-ranges;
>  
> +			vuhc0: vuhc@80400000 {
> +				compatible = "hpe,gxp-vuhc", "syscon";
> +				reg = <0x80400000 0x80>;
> +			};
> +
> +			udc_system_controller: system-controller@80400800 {
> +				compatible = "hpe,gxp-udcg", "syscon";
> +				reg = <0x80400800 0x200>;
> +			};
> +
> +			gadget0: udc@80401000 {
> +				compatible = "hpe,gxp-udc";
> +				reg = <0x80401000 0x1000>;
> +				interrupts = <13>;
> +				interrupt-parent = <&vic1>;
> +				vdevnum = <0>;
> +				fepnum = <7>;
> +				hpe,syscon-phandle = <&udc_system_controller>;
> +			};
> +
> +			gadget1: udc@80402000 {
> +				compatible = "hpe,gxp-udc";
> +				reg = <0x80402000 0x1000>;
> +				interrupts = <13>;
> +				interrupt-parent = <&vic1>;
> +				vdevnum = <1>;
> +				fepnum = <7>;
> +				hpe,syscon-phandle = <&udc_system_controller>;

Based on your bindings explanation, UDC should be rather the device
with multiple children representing actual devices.

Best regards,
Krzysztof