Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "hare@suse.de" <hare@suse.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v1 0/2] UFS Advanced RPMB
Thread-Topic: [RFC PATCH v1 0/2] UFS Advanced RPMB
Thread-Index: AQHY8qpuI/QP6FW+6keQsjCzPOix+q4099XQ
Date:   Tue, 8 Nov 2022 12:37:31 +0000
Message-ID: <DM6PR04MB6575D9DA640DE6BD0313758DFC3F9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221107131038.201724-1-beanhuo@iokpp.de>
In-Reply-To: <20221107131038.201724-1-beanhuo@iokpp.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G5gEkmQxZXyrxYA1XvIQ7AuD+2yINejSvgfOcSmxYSAwVNHnZQuLAOESTXjd?=
 =?us-ascii?Q?yIi/OQ/GNRBiI4ahZ5UUUWa+prj+PCOM29oO1hZ+uGqphWlduihsbXyk6wOr?=
 =?us-ascii?Q?vCEo23dK2bVV3mVvvovQ3757ZpqfO7gRUntck7KAwFhxKOPKualXSy7InOq1?=
 =?us-ascii?Q?PVJhVIYA7gKRd1t2Rp546NBXCYtVYQphmpIaxCyy9tB1jFu7rX6RofE0XTBj?=
 =?us-ascii?Q?ZnOkqgUW9WTSlC51f5XnMqGDnE5glcFHjuasR+07a95z6JXLSUvc7Gf4+H0A?=
 =?us-ascii?Q?cedvWIWQErP9g0ahMXhXlbrhOOolkK0GAr8VPuuNv+U6CdmGqvEST+j7E9F6?=
 =?us-ascii?Q?RlCOtVpyI5mfV+tnC5p/7KgCUurMZAn+8n/gG3FlANuLqPiJM8iBy2QP97Ip?=
 =?us-ascii?Q?xladHeduPkrkz4d7BW12Yr2hoWno3AOUJqQICtlKdlGxmSVORaKTxq0IuSRy?=
 =?us-ascii?Q?gHZhQ2hZgdb7vkqp3Olbz9oSFJgU9bDlPh7J7tWS1VWwjbWeBOi3+DjV8pBX?=
 =?us-ascii?Q?qcGni4PNYe3wVutDMH+hcBrm6H79VgmW/zSo2YpXiUWvzeJW2N3Fl0T0NjNO?=
 =?us-ascii?Q?YNEGyArvwTPqIe7pP69O3rGMhEhvswkGwHnLKnM+Jk8VOKmcKZYMcgmy5Qab?=
 =?us-ascii?Q?vYKJ6/b3qorx7+12kmYBFTNuu9ssr94Bk2sREuWGbC1jo8OFerZd0DazvSSA?=
 =?us-ascii?Q?rb/eJQO1CKOrgoPQinlhaCqywbVrPWzGvddL6nHSXhbWac9tj2cW4O/+9Sdf?=
 =?us-ascii?Q?FgpHUvpoIi7rSpgN1Rldtay2l6jQqWF4/GnxoHgRjYC6xe/znzlpVZnHeT54?=
 =?us-ascii?Q?ydEg+BIuRrUBf5yY6UUDrE9Wn2Izun6nC9w8TSPhzC6vurICFDVykuVYX/VD?=
 =?us-ascii?Q?qcWaCn8E2DIDlvU4y3AY2ZsT4SNLs55G6jtBrzRby5YTmH0OXiDzAbTFXB+L?=
 =?us-ascii?Q?xfPjY5Xhx3El8ss3IOxIXH4ZpYP/B1SuW98JTN8tzdvJTCQ3CltVrIP5BCx8?=
 =?us-ascii?Q?FEPvC5Ef6iuqlVekmCQtT0KaaquFeqv38KS+EAdWP3n8LKL41xaUQtHajX8j?=
 =?us-ascii?Q?O1jj5WbZXDqKpEm6L6zI6yJBNjj7eBU/8znVNZdBk/NineoEqJf1SPP0CnNL?=
 =?us-ascii?Q?A0aJhNlqfAL/9b9QwviqAORGBZjICQ2gBO0ZsBDJRcus+4Icc2VJfT1wJmi+?=
 =?us-ascii?Q?rNNgy7+f+oLo9eMi8jjz0mqz2rDVeTXjJhjtL6nsGjElqE7+ue7TOfsLLJO+?=
 =?us-ascii?Q?WWsqCnLpg+mPEaK8S+y+07wjtEvOW5uzaSkgqkCpNG+AnchoGz+HUxwVh6/y?=
 =?us-ascii?Q?gEOwPSvFuf695Zji1wJRfhBCW2ocs/EkEdndmqBevSDK7fzO1dVzL3MKVvoB?=
 =?us-ascii?Q?z4V/wkwCgNth+dknqjQf7AA6wdPutIZt1H9+SEJOWDdcmPkDBf3wyNwy8YwI?=
 =?us-ascii?Q?PFM2Dg8T962+0E+Kw9VWtnHU9ISLolRPhyysKCKepTs28wfmX1hnGMnSHALu?=
 =?us-ascii?Q?WuwEyiWHolxfaa1A27ptYBAb7/d+HyYFoB8KTXa5q026oCBpduByrL5r8o/K?=
 =?us-ascii?Q?ydvzd2S/Y1I1hQeyEHcOvWnadXHhnvCFm74SVRjq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 032db309-a53e-4c8e-8577-08dac186014e
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 12:37:31.7411
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IH7ssQzPV5KaevfOx5+ixMvMuxr2PEuCYZWxqepTVTU7kVdgp8MoVXts6JqyKsHsbC1HHCEPeYm2Eg6MSHS+9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5906
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,
> In UFS 4.0, it introduced advanced RPMB, which can significantly improve
> RPMB's command performance, enhancing its atomic operation. We don't
> know which implementation will please everyone, mark this advanced RPMB
> patch as RFC. Any suggestions to make the patch a master patch are welcom=
e.
>=20
> Based on suggestions and feedback from Hannes Reinecke and Bart, we can
> use job_bsg->request and job_bsg->reply to pass EHS packets without chang=
ing
> the BSG V4 structure and BSG core.
Can you share the reference to this mail thread, or was it a privet discuss=
ion?

Thanks,
Avri

>So we push RFC patch just to start
> Advanced RPMB mainlining
>=20
> Bean Huo (2):
>   ufs: core: Advanced RPMB detection
>   ufs: core: Add advanced RPMB support in ufs_bsg
>=20
>  drivers/ufs/core/ufs_bsg.c       | 115 +++++++++++++---------
>  drivers/ufs/core/ufshcd.c        | 161 ++++++++++++++++++++++++-------
>  include/uapi/scsi/scsi_bsg_ufs.h |  30 +++++-
>  include/ufs/ufs.h                |   3 +
>  include/ufs/ufshcd.h             |   5 +
>  5 files changed, 233 insertions(+), 81 deletions(-)
>=20
> --
> 2.25.1