Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <937e019a-f911-8fcb-6f0f-d23188ced89c@nvidia.com>
Date:   Tue, 8 Nov 2022 21:16:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp_create()
Content-Language: en-US
To:     YueHaibing <yuehaibing@huawei.com>, borisp@nvidia.com,
        saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        lkayal@nvidia.com, tariqt@nvidia.com
Cc:     netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221108130411.6932-1-yuehaibing@huawei.com>
From:   Mark Zhang <markzhang@nvidia.com>
In-Reply-To: <20221108130411.6932-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXRDbExsS0dmd3VCaGl0d0hZQS95NTRZT20zbVdzQk05YllJWVNMN1ZHMnE4?=
 =?utf-8?B?MFUxUkxPeWxsVStrb3ZSWmlyV0N4MEQ4ekltZWV1Vzg3MWtXS0tYS1FOVUdi?=
 =?utf-8?B?MU9JL3ZTZGhrczhKeDIxR0t6dmR1NXQ4cVlxdk44OTRmaEk1Q2kwSENJVUYx?=
 =?utf-8?B?L09tZnUzV2VSNFlzdzNiL2RMMTJNL094TW1UU3VmNjZhdzBMSUxNZkZDY1Nl?=
 =?utf-8?B?Y0xxaEU3Tnl2WXZPYWFpcWxJdjVxSytTNFMzRXF2ZGZCYVN0M0pRUEpmVVU5?=
 =?utf-8?B?azhYODk0eENSa21IbHgvQ1dVcjh2U1VEVi9XS2E1aWg4YUQ3YmxpOWlUK21I?=
 =?utf-8?B?b1FhWWd5elVNSWU2Ry9hbjQ5eHlVTy9DcnhmZ0xRaDZFRXpkSXF4cGdSWHB3?=
 =?utf-8?B?SmdhdUl4MFMvbWxMejg0OUp5Rlc0eVFzc0RZQWNpc0IwRnkvcFJ6bWl5QTFx?=
 =?utf-8?B?Yyt5MnBpNXdrblBHbXhqYWR5Sk1IMXo1NS92ZWo4NDFYOGZodERDWUtUNWV1?=
 =?utf-8?B?bW0ycEFZTzFPREJDMEpWMHBrQnQrZWZsN29kWkh4T0ZnYXNxSms1N0NOSFJt?=
 =?utf-8?B?WEZmRVBVRDgzNGkrVklRMXBaQWhZZ2JkWDJzbSs5WXYwd3Jxd3JhV3kwbW0x?=
 =?utf-8?B?d0h3dW5nUmpQUk1PK3pPeUFQL3J1YTUzNFQ2SmNSYVZjeCtycVF2SFFjNXJn?=
 =?utf-8?B?Nk02TWVZVXRkcWxodU9OeHI1QWZFbmg1SDBTZ1pJOTR3Q1VsbzcyeTI0NDdT?=
 =?utf-8?B?dHdiUHpGdmZhSVdYSlpuWSs1WVF0T2V5NW91cmhrTGw1WVdZZ1lrT1ZqSGsr?=
 =?utf-8?B?NHg4akErV1d2bThNZ00vSFBaL21tWG1qeXVEaTZDZmlFYWFxM044QlhBRk92?=
 =?utf-8?B?VU41RHhEV0NVU2pCU2FHeUNLYk9qd2E0OWVhNldwbEZXQXlOYmgvQzgxeWpK?=
 =?utf-8?B?dFZvUldFV2dVSDFVK3d2OUhIMStWRW1EUnRqT2JJZnU4a1pIRXA2SEJKTytP?=
 =?utf-8?B?MVVtaCtHK054SXVIQlFyWEtjKzBCZ3BrL1JhMW9oZzB4NndyYUpiK2c0T0do?=
 =?utf-8?B?a2tzZS90bVpQT200SnVUU3NPMXBrY0Q1aHFObkwxMmN0dDZYazZleGdpcmEz?=
 =?utf-8?B?K29KTGsyYTNibHI0UWFQT1VYZVpzY1Q5NnRyNXdUZ0Z6ZnZnRWxsMmU2NllW?=
 =?utf-8?B?WmFhM3R4NUFIamlKRWlQYUR1RUJXUmQ0MCtwMXA5UDdhZTZSWXgwbXZvT1lw?=
 =?utf-8?B?bC9Id3F4SEc1bU9HODRtTjBnSE1XRkp5eXdoVWs0eXRKZ2NmYVNaRHhuK21L?=
 =?utf-8?B?QytZL2JiYy84TGFGTkh0TjE5bWJkU3Y4WEpsdkZ6cjR2N1lpM3VVY3FwK05j?=
 =?utf-8?B?VFRScmNjMjRtQm9VdjZtT00yUzlGZ0o5OUdnKy93bEp2Wk9ENmphK3FCZVhD?=
 =?utf-8?B?VXBicWd6Z2RtQUsxSHAvZ1VNS2cxSG14M0pwUDVqZlpWcXhhMjZ1cWE3RkMv?=
 =?utf-8?B?WHduanZxWmJzamI1eEduWTdneDR2a3M1WVlybFVDNTRCemNJdVl5NTZYK3JJ?=
 =?utf-8?B?U09MaFBVUUZUM2FpTXpDVGx2enBKME9hc3NSY0FzTmVpRHlsV0tpUWFsbTFh?=
 =?utf-8?B?UXBaVGxPQTRiWk1mZlluWXErYi9uc0N6YTlzUmwrMGl6VCt1OXlIQWlhSGwr?=
 =?utf-8?B?YllsKzFObTArMGtobjZWYmVDd1dmNTJKSzE2TGtJbmJENkRFUUd2TnhKY3Q1?=
 =?utf-8?B?NVJFZjRWbHVFN3cxYmJrd2dveVdLbzlDU3VNNGw0MXdCc0tML096Z04wVGN3?=
 =?utf-8?B?eThORC9YV2g3QmtDNFBZNGpXc2hBUUZwYzNqUDBhZFJnNkhIdlROOThJOHhH?=
 =?utf-8?B?c2lRSGJGY0FmVVFXNVp1RjFtZ3grN3NvS0ZzeDJtTXRML0ZrNTNPcURJZjNo?=
 =?utf-8?B?cWQvNWdVbXhmYUgxc1pFdld2MWpPVnNKdHR3K1hOVzBGOFhpcWU5L0tqSDFu?=
 =?utf-8?B?MHllVkF6d00rbzErL1dpWHNEOVl2K1M4S3pSS3pHOGpzTStPZEx3RjYzaWNQ?=
 =?utf-8?B?TUF3TzNuc0xJQU9WMTh5bkIzemUzZ1hPeW9ma09KRSs1YzdYMTJFdnlmSlAx?=
 =?utf-8?Q?8l/4zmB1tFfVQVbTIzikGTi39?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70499f10-97ff-4d4b-80b3-08dac18b6f72
X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1366.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 13:16:24.4330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s4ZN8ZESOmK15s2cu5mxczXTC7TRzbL8OusO30fm4a7qiEU/vkmUMLCBlx2a5BUfgQU7k2ENrkqcegDFWH4HWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6412
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/8/2022 9:04 PM, YueHaibing wrote:
> 'accel_tcp' is allocated by kzalloc(), which should freed by kvfree().

'accel_tcp' is allocated by kvzalloc()

> 
> Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> index 285d32d2fd08..7843c60d5b99 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
> @@ -397,7 +397,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
>   err_destroy_tables:
>   	while (--i >= 0)
>   		accel_fs_tcp_destroy_table(fs, i);
> -	kfree(accel_tcp);
> +	kvfree(accel_tcp);
>   	mlx5e_fs_set_accel_tcp(fs, NULL);
>   	return err;
>   }

Need to fix mlx5e_accel_fs_tcp_destroy() as well?