Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7db36fb7bbd9f079c117931a2de72aa78baf0578.camel@gmail.com>
Subject: Re: [PATCH bpf] selftests/bpf: Fix casting error when
 cross-compiling test_verifier for 32-bit platforms
From:   Eduard Zingerman <eddyz87@gmail.com>
To:     Pu Lehui <pulehui@huaweicloud.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Pu Lehui <pulehui@huawei.com>
Date:   Tue, 08 Nov 2022 14:29:45 +0200
In-Reply-To: <20221108121945.4104644-1-pulehui@huaweicloud.com>
References: <20221108121945.4104644-1-pulehui@huaweicloud.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-11-08 at 20:19 +0800, Pu Lehui wrote:
> From: Pu Lehui <pulehui@huawei.com>
>=20
> When cross-compiling test_verifier for 32-bit platforms, the casting erro=
r is shown below:
>=20
> test_verifier.c:1263:27: error: cast from pointer to integer of different=
 size [-Werror=3Dpointer-to-int-cast]
>  1263 |  info.xlated_prog_insns =3D (__u64)*buf;
>       |                           ^
> cc1: all warnings being treated as errors
>=20
> Fix it by adding zero-extension for it.

Looks good, sorry missed this case when coding this function...

>=20
> Fixes: 933ff53191eb ("selftests/bpf: specify expected instructions in tes=
t_verifier tests")
> Signed-off-by: Pu Lehui <pulehui@huawei.com>
> ---
>  tools/testing/selftests/bpf/test_verifier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/=
selftests/bpf/test_verifier.c
> index 2dbcbf363c18..b605a70d4f6b 100644
> --- a/tools/testing/selftests/bpf/test_verifier.c
> +++ b/tools/testing/selftests/bpf/test_verifier.c
> @@ -1260,7 +1260,7 @@ static int get_xlated_program(int fd_prog, struct b=
pf_insn **buf, int *cnt)
> =20
>  	bzero(&info, sizeof(info));
>  	info.xlated_prog_len =3D xlated_prog_len;
> -	info.xlated_prog_insns =3D (__u64)*buf;
> +	info.xlated_prog_insns =3D (__u64)(unsigned long)*buf;
>  	if (bpf_obj_get_info_by_fd(fd_prog, &info, &info_len)) {
>  		perror("second bpf_obj_get_info_by_fd failed");
>  		goto out_free_buf;