Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Nov 2022 14:17:03 +0100
From:   Thierry Reding <treding@nvidia.com>
To:     Ninad Malwade <nmalwade@nvidia.com>
Cc:     jonathanh@nvidia.com, linux@roeck-us.net, jdelvare@suse.com,
        nicolinc@nvidia.com, rkasirajan@nvidia.com,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH] ina3221: add support for summation channel control
Message-ID: <Y2pWzx13km4qJfHe@orome>
References: <20221108045243.24143-1-nmalwade@nvidia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="kiqTF7bkm4/b9cRJ"
Content-Disposition: inline
In-Reply-To: <20221108045243.24143-1-nmalwade@nvidia.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?unnw5bs6Nu79kxcwaXazA1YNLbMiUIc6jLRNP2r/DGg0HxXiCR5x32gHpQXy?=
 =?us-ascii?Q?sNZOJfK9B65MYD3zNjkxUbjKSeY4XAldnSBMBqCmr9/z4T/KWtOsIdi2Bsde?=
 =?us-ascii?Q?R17bbP7EIWTPzCc9C/xJGKQCF+Jmje77eAc2cSBx5/z1wsUJbc2/uj/GZ1KC?=
 =?us-ascii?Q?DkdAlUuqCv8VUkjHF0LZyRrhHB4S36cc8FaPaYwIhe3sV1iETPqjWQEKQoNX?=
 =?us-ascii?Q?xGprzkDX2QEo3BPUBIEp9Z2b5i5ASd731FFtzE6CD2qvDjOAb1EhSJs83m7v?=
 =?us-ascii?Q?CjMi0NaIra9qv/2g5vcraRf99ssfSwNkH+L59tYg4Ct/E1Ro4vzTT9p60dDC?=
 =?us-ascii?Q?2JRUtcpeU2o/MW8TomAO5ko4tbQKz7L/baE0MSIhyiQ+bDtys+oa7s0HUflC?=
 =?us-ascii?Q?/vT/kxWsVskqubY9WBBbzlcIiCbOViKHlJOmPxwRpa4NF1Gxnbn9eE0zMdIt?=
 =?us-ascii?Q?xHxZJjcffYrALQjdHkTm7DA0PUvuq+xHBp4CY29END1U4S6nBq/IGe63aylo?=
 =?us-ascii?Q?WnV2M0+U3P0+EeMO59iJ+y0krb6p1KtKWKJyXKGg31cRoLh2aKj8M6YBcHma?=
 =?us-ascii?Q?UTXCaL9uvBYSaAX9Yiqzvfm3Ae35i+KL1jhzhgjoR8307ux616ukmVk5MIcf?=
 =?us-ascii?Q?bWnHfD7je4RXmJU/fP36d4G+MJsQixUbHeTv2Nu0kgMB99emRyb7h7d0sADA?=
 =?us-ascii?Q?ugoJ3XZEqQjwt0J5ZSnkCoD6dlMqBRzWIht18Cm0fyutHSmAG9Lx4LVdHsZ9?=
 =?us-ascii?Q?WuM5OHk39HTdO9Vw3KulL7J1oS6bimatAMcsb51xYS64RI6iacUMk6PewggQ?=
 =?us-ascii?Q?1dd4xGnwV1ptD6Yu48E2cSOxO+hcdFtys5FCsHMdOV47PoeoAJKwx11sqZkd?=
 =?us-ascii?Q?+M02FcKFSGzUX5MnZVNGFHo0/0KUZ7dzZ1y3B5Ns2sGyZTnPerM/PiLFVFni?=
 =?us-ascii?Q?bmfxXRdlDYslynqTR+S2o8rsyQk9KBYNr47W9sctmyyQFwgX9h8vbIlepmo1?=
 =?us-ascii?Q?ydRqsSPpeJlskrZ73rA+jnxGA0POFlfTjzQVpnzJIUWuPJiFVYGkuB7g9x0+?=
 =?us-ascii?Q?1+a4LHwVFBHp9t5EAQHFFjOCmnxhpX+CdUIKT6uKE7yPoCxY1cQsd43Rtyzd?=
 =?us-ascii?Q?Q+ufx7dqbCh9Mr4raX7409TC2RNr/Q0YROjDSdklP3VfM9hpyjA2GcMGp1Zb?=
 =?us-ascii?Q?wPyxkJCPXzhgPPFAzf0mtSfHxS+MZFSlqyz50DUKPMYO+6lCKP0WEgyHDnJV?=
 =?us-ascii?Q?bzMFoAcxknm+gFRbDetFAam1YxleSePgSv696UCEo0RrHHNrX55GY+d4uRax?=
 =?us-ascii?Q?qs02MKyD42O+okp6qWVVg4QPC6yGjZuV8pzS7pZRVt6HJ4KeK5UII9cf91PI?=
 =?us-ascii?Q?nM7oDmRexa4q2hN65X3vT7kX4qCD+xoOLbzcRQU3Wmcr1hOCo1ugHKYbJdKa?=
 =?us-ascii?Q?VsGh/eRhzjQbx55ikRER509nqj0ufp4gl24/v5nsunfpmkEipvCzDYHfsWog?=
 =?us-ascii?Q?1xfyF2oQdO98cJ8oU16NAn+Kj+4cE/rl68eGsMaPSORR5gKeELtZtSn/F8ir?=
 =?us-ascii?Q?d+F9rHLxZclt0My6Kd8n+MOQCyh193f9fiNLeGirqT7Eboytje9rxslnLIG0?=
 =?us-ascii?Q?iwRAayDDaiKuFihLrk4Y86OHsnPOIA3256/2+QBYX2uu?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23efc104-e51a-4caa-3769-08dac18b8ad6
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5413.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 13:17:10.1818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IMUhfVLTeaVPAZXwF63f7CivJfNLEuZGV4lf5QVKQKQ0lYGbGB5h3aXfuehhHGfya9B1R9Oms5FWO3Ns8hkRtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6909
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--kiqTF7bkm4/b9cRJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 08, 2022 at 12:52:43PM +0800, Ninad Malwade wrote:
> Add support to initialize summation channel control via kernel device
> tree property "summation-bypass". The channel which has this property
> is excluded from channel summation.
>=20
> Signed-off-by: Ninad Malwade <nmalwade@nvidia.com>
> ---
>  .../devicetree/bindings/hwmon/ina3221.txt          |  2 ++
>  drivers/hwmon/ina3221.c                            | 14 ++++++++++++--
>  2 files changed, 14 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/hwmon/ina3221.txt b/Docume=
ntation/devicetree/bindings/hwmon/ina3221.txt
> index fa63b6171407..c6e8e6aafcce 100644
> --- a/Documentation/devicetree/bindings/hwmon/ina3221.txt
> +++ b/Documentation/devicetree/bindings/hwmon/ina3221.txt
> @@ -29,6 +29,7 @@ Texas Instruments INA3221 Device Tree Bindings
>    Optional properties:
>    - label: Name of the input source
>    - shunt-resistor-micro-ohms: Shunt resistor value in micro-Ohm
> +  - summation-bypass: exclude from channel summation.
> =20
>  Example:
> =20
> @@ -41,6 +42,7 @@ ina3221@40 {
>  	input@0 {
>  		reg =3D <0x0>;
>  		status =3D "disabled";
> +		summation-bypass;
>  	};
>  	input@1 {
>  		reg =3D <0x1>;
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index 2a57f4b60c29..ba0d6da06947 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -104,6 +104,7 @@ struct ina3221_input {
>  	const char *label;
>  	int shunt_resistor;
>  	bool disconnected;
> +	bool summation_bypass;
>  };
> =20
>  /**
> @@ -125,6 +126,7 @@ struct ina3221_data {
>  	struct mutex lock;
>  	u32 reg_config;
>  	int summation_shunt_resistor;
> +	u32 summation_channel_control;
> =20
>  	bool single_shot;
>  };
> @@ -154,7 +156,8 @@ static inline int ina3221_summation_shunt_resistor(st=
ruct ina3221_data *ina)
>  	int i, shunt_resistor =3D 0;
> =20
>  	for (i =3D 0; i < INA3221_NUM_CHANNELS; i++) {
> -		if (input[i].disconnected || !input[i].shunt_resistor)
> +		if (input[i].disconnected || !input[i].shunt_resistor ||
> +		    input[i].summation_bypass)
>  			continue;
>  		if (!shunt_resistor) {
>  			/* Found the reference shunt resistor value */
> @@ -786,6 +789,9 @@ static int ina3221_probe_child_from_dt(struct device =
*dev,
>  	/* Save the connected input label if available */
>  	of_property_read_string(child, "label", &input->label);
> =20
> +	/* summation channel control */
> +	input->summation_bypass =3D of_property_read_bool(child, "summation-byp=
ass");
> +
>  	/* Overwrite default shunt resistor value optionally */
>  	if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val)) {
>  		if (val < 1 || val > INT_MAX) {
> @@ -873,6 +879,10 @@ static int ina3221_probe(struct i2c_client *client)
> =20
>  	/* Initialize summation_shunt_resistor for summation channel control */
>  	ina->summation_shunt_resistor =3D ina3221_summation_shunt_resistor(ina);
> +	for (i =3D 0; i < INA3221_NUM_CHANNELS; i++) {
> +		if (!ina->inputs[i].summation_bypass)
> +			ina->summation_channel_control |=3D (BIT(14 - i));

No need for the outer parentheses. Otherwise looks good, so with those
parentheses dropped, this is:

Reviewed-by: Thierry Reding <treding@nvidia.com>

--kiqTF7bkm4/b9cRJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNqVs8ACgkQ3SOs138+
s6F4+g//ZemXwIwPbxIesp3zJzQOOyx12y3JHFNa5sCNri/y9XcMdl3U2jDJmZ1J
aJrjVRmEWWSE9fJpvIU2DKQLWTWSyV3XqfDCbBAqaZ5+5qj1q/gqmzFoowgVkVyH
qg/6QnJzxFvqq0XFAbwJURkD8SktVoRWkPW3sCpbLNDdpQL4/STHq8FeamGiNw0B
vscXStNQfkX9Ukb4pZaLr240qpOjxRE720j5UYsXt7t8OkZVbcVfwMFWCOATGFhk
CyU/S30wNkKQmmlLdAR7CTustFKRXr45S4is41aW/fNjvn6YiR6b4QnPc1v9yX2L
xJqm0zzaJC0JwocdRRxIgtQxhCjfacdWDAUBuzzveCuMTflNRqWSZWKjDoHYWiUY
h//AgrlRXm+tcDTxkVun5b34K5AaQwJXLz5SJwCyibQuijW81J4gj+dC+536sZcK
z6VW9KgaARVCcdjsZcCuaddyMBethc1VbBzKOm/k2BzWwshl7Sksbii8T2j08jDi
vSLtIFhXH3Iwd7E8i2HkewsmD+9Dt2sB9SiMCL8Q+uGyIhIBYjZsPCWDmvdyR0te
HooIOOR+ysh5W6kj0DOM4TPBpgHGP/gSDjPJRrJt6DATDjZo5wrzegddMetvKVr4
jTJWJuqdedeqMwKHARkgPTIcSMBiUqSeeWM85041FFbKQvl+G5w=
=baxH
-----END PGP SIGNATURE-----

--kiqTF7bkm4/b9cRJ--