Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "hare@suse.de" <hare@suse.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v1 1/2] ufs: core: Advanced RPMB detection
Thread-Topic: [RFC PATCH v1 1/2] ufs: core: Advanced RPMB detection
Thread-Index: AQHY8qptSXvFlqlwnEWjfKOYjvP9p641Bisg
Date:   Tue, 8 Nov 2022 13:40:07 +0000
Message-ID: <DM6PR04MB6575145B168BB80F3D2910A7FC3F9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221107131038.201724-1-beanhuo@iokpp.de>
 <20221107131038.201724-2-beanhuo@iokpp.de>
In-Reply-To: <20221107131038.201724-2-beanhuo@iokpp.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZWE04QCvd2lFLcvn+L8tTVHyJ9thP4bjWbzmB1qeZlhDukCLlbWsRtXD4mS2?=
 =?us-ascii?Q?8UtM2Ab4wbXj/oa0r6zD7ipSCKghK2R13TPGDKIL95hWCR62yc/467TIQkpA?=
 =?us-ascii?Q?DDcymj+ZA1iz2kggZ6BWNNDcF6WMmqldtl0CJJuSGO2X9oFyzZP0To1VxEmq?=
 =?us-ascii?Q?IawHXtcLzqfZsI3d4TGGWtxLS0VlD0Ic5FbyN8FV3PAT+ESqSasJWlzrGwIM?=
 =?us-ascii?Q?AGqnnhhbw290FFN5L62XM1i5hs73ffFmvgcw1iU3e9viD4Z6ZctrkMY5kTrw?=
 =?us-ascii?Q?ztwmhOEaoTrnyu5xTh03QdyYCMGxATx3F7vZzdSKfao/3XOi/PIPDnsPspPt?=
 =?us-ascii?Q?tIcaMLGLiG+xOUGvdCSZ4gpXFy5oQdyCLAwkbzU85hqBF1USdV9y9x5HQ7Cw?=
 =?us-ascii?Q?LmA7YRCupBIGhlaM8wbtVLyMrwasUwnb2x2jOijZ+0fH8YBkO00r8X74+Lp0?=
 =?us-ascii?Q?Y4UL/Z6PIQcx6jEXnDLhOUIi+Dymf7FAzO/JH6/Hf5E6aSIQWdNwOlHhnjBh?=
 =?us-ascii?Q?CeP/Disqmy7Gqqq6BkraSYIe8uuDO/UKKMSP2tH/7TTQmnp7E+DavUIqMrpQ?=
 =?us-ascii?Q?vo7AoY5BfIFqSCklSItRBya2sw3ZaZhJODGtZLINXgIhBB8pUWfWbBe7NFRq?=
 =?us-ascii?Q?rpD4apxxT8IUrZ6kyAJ6FwJt5GOTtrrQpmBM5BOywb1cBzo6J1rwwvhlk+9j?=
 =?us-ascii?Q?lq7l6ThteMhdNDFPHEqW1CrXaFS4jkEOf7L/sJi5thiW3i3yNLnZaXOMPO5E?=
 =?us-ascii?Q?ZS1L+HQbT0KCx5DZ6g9O3qQP0CKXvp9WLdLYD5XR6LBEOfYnPLiy2BraQ9eo?=
 =?us-ascii?Q?B4krgont8RatPJkSsNKvXbXvMgz5jaQ7WBudg1vADWRimGDgz3k6krsR8yva?=
 =?us-ascii?Q?oYX5UCG6/rmRO2XjMNXdvFeJAuogVpwrMT6+f984KUT5iuXUFFxERwFlCRtA?=
 =?us-ascii?Q?ovEuqlx/Y2T4zjo+zykM76MbxjhxoewXTIeWJ1qZlDqAlKWpT2J1XarSjnoP?=
 =?us-ascii?Q?I8GWQu5nGeYb5auPGjFoKxONHsj0EZjaWJMb/BxQB6LUVfLQGLoQ0esfsKmq?=
 =?us-ascii?Q?MC+ETMvLSBZBsYM3q9PA4OYqHBFnGFgvPQe5c+KGA9FW7+TM9xIYMYe017Y8?=
 =?us-ascii?Q?t8BAssCjg2oBZoSteq0LnoEzE/seN7G44+jWfggj4FauFiThX+0B3Qh4JUP8?=
 =?us-ascii?Q?wC+mYfzPkAnsS1/rh0MYvfQmXQbzJ6LMQQpVfopzBHYfwNjWNRT8X2lNUAAw?=
 =?us-ascii?Q?Fd+KrpWqtM/Xdcy93m2PIV4U48vLKCwWHLn4pM1QgMFBsR2jbixdXenxGkfD?=
 =?us-ascii?Q?ZyPqj/W1b9iZ76V0ssVZt35xGi4L/EPDFhy4F8tscoNkjYUWTvUpbkIBwM0R?=
 =?us-ascii?Q?FymyegscXQ9XxSjTsPeCB26uWz60jRzGR87agg0WvdnQt1X7q9uFq7wWspqp?=
 =?us-ascii?Q?9rQaiM/zP1Au9t+IcNUM/ZXmZLRA8TNwCAaDsaxZg3Dsu/wbmgdIGioEboQi?=
 =?us-ascii?Q?7FXxvEhR6oFYe3B7KM/xWthpa6Qj2ezPeI6GctJEK5L9Wl/G/9O6mTdI+qCc?=
 =?us-ascii?Q?fjV9HRQ/YwscYAqQsJeqV1igi4eu/LRMB7zqBcRR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73ef1483-baaf-4172-af05-08dac18ec029
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 13:40:07.9664
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8MiDSiqk1uukS2KBYQM5EeI0Z7TqRVUNJWPKLOso9/AUXgHUAvPhr9P15/lY4I0waQ3mOr2xl3u9Tlvr0vTRjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5475
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Bean Huo <beanhuo@micron.com>
>=20
> Check UFS Advanced RPMB LU enablement during ufshcd_lu_init().
>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
>  drivers/ufs/core/ufshcd.c | 4 ++++
>  include/ufs/ufs.h         | 3 +++
>  2 files changed, 7 insertions(+)
>=20
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> ee73d7036133..d49e7a0b82ca 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -4940,6 +4940,10 @@ static void ufshcd_lu_init(struct ufs_hba *hba,
> struct scsi_device *sdev)
>             desc_buf[UNIT_DESC_PARAM_LU_WR_PROTECT] =3D=3D
> UFS_LU_POWER_ON_WP)
>                 hba->dev_info.is_lu_power_on_wp =3D true;
>=20
> +       if (desc_buf[UNIT_DESC_PARAM_UNIT_INDEX] =3D=3D UFS_RPMB_UNIT &&
Please remind me why do we need both UFS_RPMB_UNIT and UFS_UPIU_RPMB_WLUN ?

> +           desc_buf[UNIT_DESC_PARAM_RPMB_REGION_EN] & 1 << 4)
(1 << 4) or BIT(4) ?

> +                       hba->dev_info.b_advanced_rpmb_en =3D true;
> +
>         kfree(desc_buf);
>  set_qdepth:
>         /*
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
> 1bba3fead2ce..2e617ab87750 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -199,6 +199,7 @@ enum unit_desc_param {
>         UNIT_DESC_PARAM_PSA_SENSITIVE           =3D 0x7,
>         UNIT_DESC_PARAM_MEM_TYPE                =3D 0x8,
>         UNIT_DESC_PARAM_DATA_RELIABILITY        =3D 0x9,
> +       UNIT_DESC_PARAM_RPMB_REGION_EN          =3D 0x9,
This is awkward.  Better to define it, or -=20
Maybe it's time for rpmb to have its own unit descriptor - it surely deserv=
e it.
=20
Thanks,
Avri

>         UNIT_DESC_PARAM_LOGICAL_BLK_SIZE        =3D 0xA,
>         UNIT_DESC_PARAM_LOGICAL_BLK_COUNT       =3D 0xB,
>         UNIT_DESC_PARAM_ERASE_BLK_SIZE          =3D 0x13,
> @@ -601,6 +602,8 @@ struct ufs_dev_info {
>=20
>         bool    b_rpm_dev_flush_capable;
>         u8      b_presrv_uspc_en;
> +
> +       bool    b_advanced_rpmb_en;
>  };
>=20
>  /*
> --
> 2.25.1