Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62a98c8e-c471-dc02-58f4-63dd1361f92c@oracle.com>
Date:   Tue, 8 Nov 2022 18:54:56 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] selftests: cgroup: Fix unsigned comparison with less than
 zero
Content-Language: en-US
To:     YueHaibing <yuehaibing@huawei.com>, tj@kernel.org,
        lizefan.x@bytedance.com, hannes@cmpxchg.org, shuah@kernel.org,
        yosryahmed@google.com, roman.gushchin@linux.dev,
        shakeelb@google.com, rientjes@google.com, akpm@linux-foundation.org
Cc:     cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221105110611.28920-1-yuehaibing@huawei.com>
From:   Kamalesh Babulal <kamalesh.babulal@oracle.com>
In-Reply-To: <20221105110611.28920-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUxRbjdkTk9iQ2ZUeVNZcG5NMUV3Y25HWFJuVVNOY2h0bDJ0MUVkQmJERzM5?=
 =?utf-8?B?Mml5TElkelVmalBiRjB6RVp3ejJIMjBXYnozcUNybVBsNDJ4Z0tmREZkS2Ez?=
 =?utf-8?B?Mm5BN1ZRNTkzdEE1L3lKZjNKK3N1emoveS9oRGNndVBUK251VXNITWZvWEZm?=
 =?utf-8?B?ckNvQWpJNVNidEFlK0lxb01mZVhwY1I0S3pONkZxZE5WODRBTFpvQ1JMd2xK?=
 =?utf-8?B?QjJIbzlpbllvZjBmc2t4Z2RJZnNxNFFOdHczeHBFZWppZDYwcTJiWUdwbFZF?=
 =?utf-8?B?MjNUREZ4Y3E0V1krTFVlRlZ2RElDbmhzUk55TjM4K2R6SHJRcWNFV0drK01o?=
 =?utf-8?B?V0o4OElOamxBSytJVlVDMStkWHh3U0Q4Q0ZoS1MvYjFSbjBlM1VlWHZhWktr?=
 =?utf-8?B?M2htZllHOU5ORGRwZk1NMXkrWnZiQWtnaEhuTHd4aCtUUXV4Zm9IZVRqNHlj?=
 =?utf-8?B?bWlGNDg0VGlEbUJ4Zzlqc016V2k5WW1nVXMraVhwSWxGdDVQKzdoMnhIS3Z5?=
 =?utf-8?B?V2Z3ZVRTT01rOERxYnhuSFBqMFhIR1lDOTFoTk81dVJQNm1GNXIrQ09ZOVRE?=
 =?utf-8?B?SEV6aUJ2WXRGL3FGTURWSVhkRlY4MGFqaGFwV0UzR0wvWmpCc3FZeXEyTUh6?=
 =?utf-8?B?aXFFbW5razBQQWd5N3VodmNEdUFlYWJhelZVWGxsdlEvMW9oZmNlcG9aNGJW?=
 =?utf-8?B?amMzeVBLdlNDeGhEMWIraUxONnpPNmR4ZjgvdU85YnpJUHdUWHN1cGFraHBs?=
 =?utf-8?B?My9odlZJQ1ZMdUdScXpQSkhGMDQ4UU00a1l6VXRTYUJMQ3FDVWNEVTdaNVZI?=
 =?utf-8?B?SFlnMXRhSnRWUkVRSmRxMWs5MUl1MU5lK0xFZm9iUmVmZDNXdGsrUkIzczRl?=
 =?utf-8?B?T04yZ2xCc2Q1OTV2NVhSUmRoMWxXYW41aVdCTUxuUTI5Z1djS0M1bDBCamtT?=
 =?utf-8?B?OWtENU4zdndpL0tmWGx0eXVMbkdSejV4TzRlZWlqMG5YVldQeDExSHFJYlYx?=
 =?utf-8?B?My84SHdZQlVXYXZ2M2FoNjIvc2FVQWNyWFVaVzM5MDJMMDkwcHJRUWRjcEV1?=
 =?utf-8?B?ajFsb01yUVRBZElEenlmRTFvaktQdy9peGxSUXoyVXRxaTMwcmk1eG1OZnZX?=
 =?utf-8?B?akJ6NC9pR3F4R2NucGsxRzg0NS9sMUhvV0UzVFRyMmljNWJvd3J3RURLVURx?=
 =?utf-8?B?cjFVdVM3NDFsRUgvdFIxS1I0Sk8xS2xKYjM5TmlMRk5hRnBuaFVFaHpYOHBP?=
 =?utf-8?B?VDZXVHYyTnNFUnVSNFhsVWlRTmphNkdXVnBpQm1FbktPMXBlSUNrZmJiVy9z?=
 =?utf-8?B?RktTU3RXalJrNkdyKzdncU9SM1VRNHIyUjhIKzFRN0lSdnhQYm9XRjNBWmxw?=
 =?utf-8?B?NGVRbGphNVJHT0RKVzduZ3BjamJqRXNSdEpGcm5hcVhIaEJsVWN3ZUZ0bVBS?=
 =?utf-8?B?b0lTWEMxdGxHaFZXWHVscFRPSllBNWx6N0IxcDZoVTRiQmxYdmtpRndQOW0v?=
 =?utf-8?B?SmdqNWVJcmgzdWJBNE5qLzZLU1ZDMi9XYzlPQ3RaY201UG1HOGZtSzhGRm5P?=
 =?utf-8?B?cGNoZWR0RHdKMVVwVnNVa0txM0ZLSThEVXVOeHJnc3U5V2NXYlZ5N1BmNmRM?=
 =?utf-8?B?TTNtSE94azdQUVdJbXM0QlQweFA5SzJmV1hoeDlzYVNkRHk4V1dyb2YxOURm?=
 =?utf-8?B?VUhrY1dtUEVLT01iSjBiNUZwdVAyS2d2ZHZaRmJWVU5MSkVibnA4NEZVU2hw?=
 =?utf-8?B?NWxRY3ZOd21PTWVDYVRNblJoNXl5QWFkOUN2MXV1VjZmUG04bms3akdCOW9Z?=
 =?utf-8?B?dG5uLzJlbURWZ01EK2VJZXlvTk82S2FLSnUrcUxWeU1FdWd0YlF4Y284RDhi?=
 =?utf-8?B?cGVJWVd4OGlUb2ZqRFpSRXBac0FIK3BIZHhTd0ZHc1pMc1pRM09wa04yekpO?=
 =?utf-8?B?RXRsWE5FRUdBNDJSU3FOSzZ2RVFyM0FheWRlOHBoZ25NUUZxbHI1elpWLzFS?=
 =?utf-8?B?M0IwUWVrR1FxcWk2enl0eFJUempub2EyVFZrYUUreXI4bzVkVXdvaUdnN2xR?=
 =?utf-8?B?eHJjcmkvK2s3R3pJQnVLdFNsMUFIWGRwcnE3MjVLUXZpK2hBSml1dytGYk9V?=
 =?utf-8?B?eWRQWVoyRWZNYmRtNlFJVXFaUHNzTzlOaUJvYWg1TGVWbFFjcjFKUkE0MmZG?=
 =?utf-8?B?Tnc9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2afebf2c-d7ea-40be-b4fb-08dac18ca6e5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3001.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 13:25:06.9906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ntiqI5ZgfSCPI0nevjHmzhvRLvEDtmYfb1uUKJ2IgFSPJu5zaPU30YPAyEbcBNqxwiEYf0tZpUV3p4onQViEQwXqJOI09EgITC0vbZJJBDM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6966
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_11,2022-11-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211080079
X-Proofpoint-GUID: 5MfQY1do0RYYZYJ47yzrEKqh7RC6LdwQ
X-Proofpoint-ORIG-GUID: 5MfQY1do0RYYZYJ47yzrEKqh7RC6LdwQ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/5/22 16:36, YueHaibing wrote:
> 'size' is unsigned, it never less than zero.
> 
> Fixes: 6c26df84e1f2 ("selftests: cgroup: return -errno from cg_read()/cg_write() on failure")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>

> ---
>  tools/testing/selftests/cgroup/cgroup_util.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/cgroup/cgroup_util.c b/tools/testing/selftests/cgroup/cgroup_util.c
> index 4c52cc6f2f9c..e8bbbdb77e0d 100644
> --- a/tools/testing/selftests/cgroup/cgroup_util.c
> +++ b/tools/testing/selftests/cgroup/cgroup_util.c
> @@ -555,6 +555,7 @@ int proc_mount_contains(const char *option)
>  ssize_t proc_read_text(int pid, bool thread, const char *item, char *buf, size_t size)
>  {
>  	char path[PATH_MAX];
> +	ssize_t ret;
>  
>  	if (!pid)
>  		snprintf(path, sizeof(path), "/proc/%s/%s",
> @@ -562,8 +563,8 @@ ssize_t proc_read_text(int pid, bool thread, const char *item, char *buf, size_t
>  	else
>  		snprintf(path, sizeof(path), "/proc/%d/%s", pid, item);
>  
> -	size = read_text(path, buf, size);
> -	return size < 0 ? -1 : size;
> +	ret = read_text(path, buf, size);
> +	return ret < 0 ? -1 : ret;
>  }
>  
>  int proc_read_strstr(int pid, bool thread, const char *item, const char *needle)

-- 
Thanks,
Kamalesh