Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <57eb6611-3e4e-2a4c-69b1-c6f0c1eafe92@meta.com>
Date:   Tue, 8 Nov 2022 06:45:56 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: [PATCH bpf] selftests/bpf: Fix casting error when cross-compiling
 test_verifier for 32-bit platforms
Content-Language: en-US
To:     Pu Lehui <pulehui@huaweicloud.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Eduard Zingerman <eddyz87@gmail.com>,
        Pu Lehui <pulehui@huawei.com>
References: <20221108121945.4104644-1-pulehui@huaweicloud.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20221108121945.4104644-1-pulehui@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEdsVGNXTngvRnN1N0g5UHhsc0R6V1JacENXV1FFdUNwNnh3WDhOTG9aN0lm?=
 =?utf-8?B?ZGJsN0lCcWxybmljdEM4VFJmZzlESlpJSDc2ZWY3bU1MRGdCcHMyMG1jUlh6?=
 =?utf-8?B?dnVvNmJKM1dZRE5yLzZzNFIzSGtaVFRocWxYUXRBWmdvY2tjakNldDE5YW4w?=
 =?utf-8?B?MnRxU1lKSk5RZEh4V0xKRmJvSFl1NDlBZkpKUklGTU0vd2JmZzdiT05oakVU?=
 =?utf-8?B?dTFhcUc3WUJJK0NpU1JnK1FIekg1T25QTHcyeFBxQVBkR2Q4SFFjdWJCeHdB?=
 =?utf-8?B?NzE1NWMvTHJwUHlCWWxtVEp3OFd0cktsTzRBUWs4bElpK3RvMnJoRjh6bEpU?=
 =?utf-8?B?dEkvUzFES3VwZVVIT3hjN2pYa29YN1ZhOURYWVdWTHJQU3kxYVJic0dRTzcz?=
 =?utf-8?B?emtJNDJuLzg1cEZwbENYWnc1aWVwYVgvbmswMFA0WW9kY3pUTHE2RkxOc3Bo?=
 =?utf-8?B?akVkL3VicTBraFhXTGNHUjRXaElhRmZBSXlRSVcyVG5uTUN1elYrZGx5S3Rs?=
 =?utf-8?B?MXN0VlI2dHByRUtVdXdMWG9hNjJ2dUJZMm1KZDdER21YZlN0SlV5WkJ5bVR6?=
 =?utf-8?B?Qlo5blZ3WjhxZ1JNYVJBRE5NalR1TWwzMWxDMlpTcjdXQ2Mxd1NHWXVaWERh?=
 =?utf-8?B?SWxjOW1ySDFCOVJjWGhsRlpUd1RZL0R3c2JxQnl3cjZrRTVRcTdvVEZLL1pa?=
 =?utf-8?B?QmtiRnBSKzA0UWxWQlMvVHlkdXNKQmVkbEFhYXIrSXR6a3o1bFJ5dTU1V0Vn?=
 =?utf-8?B?cDYxd3Y4RkNzNDRxVnRiSWZkNDZIcUc3blRoM255RXhNdVNjUjk2M3VScURp?=
 =?utf-8?B?aU9EVTRsZzdIWnZvdG9xOHBhLys5czlPOEFwdCtkZmdheEVDcDUxV1J2SllM?=
 =?utf-8?B?V0E5STNRb1N0L3QxYS95UDNxUlRXeUQxNnZwQWpZVWNwU0MvdW1jaWttMExX?=
 =?utf-8?B?RUtJR3BjNzUydEpaUWIxNzd3RHFuQ25WMnQ2TXlkY0pRTmZUSFpEdkZaVjZK?=
 =?utf-8?B?NkhRTTlVZnhUZ1gvMGRVNlBOSCtiM1dmVTQvNGJVWC9qem1xYlI1c1dIN1Rj?=
 =?utf-8?B?b1RTaHk1SzRsRE1HdHRpbm1CaVhsaDZXTjFLWEJJZG5oK2dOZzAzQ3Z6cnp3?=
 =?utf-8?B?bkFuZmpjQjJVUWVDUytTWFZtT3hwbDE1U0NJSE02UDk1blN2eWlFV09PcnZ3?=
 =?utf-8?B?b2w2WHJiVHErZnZlUC9IRVo0L2FEWFlaZ1FqVG9TbldPai9memJTL0J4YWlv?=
 =?utf-8?B?SHNyWnV6V040U0t1RU5hN3N1OFdIcTdRS0pCSGVHTVErOTBlelBXeUdMbHZj?=
 =?utf-8?B?WUE3dHZBWUcwaGVlWFB5UEpBSkpOckNNVzJZV2NoSitSL2J3V09zazlnZTlW?=
 =?utf-8?B?MXNDYkc2NDA0LzRPR3VnOWpaVm0rQ3RXclBrQnFsMXk3VU9XdkxzZW5mRm1a?=
 =?utf-8?B?RnRlRWdpdjMvQllYTzZUd3JUVGR6YUNnOVEzcXRTWk1jTlpsRE9uUmIvREVy?=
 =?utf-8?B?YjBZNWpaMnEwWjZOa3ZMYVo4OFZWenpSRGZHc1J6T1lOaG02Vjh0Vk9xSlBs?=
 =?utf-8?B?YXBSL2hqV1I0Vm0wZmR4Z1BtaFJaMmpVZWZaT1c5UEJPaDYxU09EbmxvK2U3?=
 =?utf-8?B?bHFCK1ZJanBBbDVkRGZjMXRVYWx2NU5KN09PN244Um1WMEUzYlZEZDBuQTRG?=
 =?utf-8?B?NkNRYmU2UnppMExvZlpHYkh3di9JckhQRmEybFQrMjgvaEtrdjI4VjIyczlL?=
 =?utf-8?B?SzlzMVFrMWM2aWNCTUJ0RE96Mk54ME5pMjg1aHRmRStsUkZkUjBISFZOVmJj?=
 =?utf-8?B?M0RxRVI3b3pNdlh2MDFZN0dqbDBpZXF3aEppckJCaGR1RnlQbXg1ckU5MGhB?=
 =?utf-8?B?UXRQY3lVTS93dkRjaWd4WmgzdXZmamUrd2NMandpb0hGSVJiSFVtaXh3VzZt?=
 =?utf-8?B?OUhEMjk2bk1hQmhOZUwrcXNtQ2xldjNvSUlxczc0RThsZmVzcDlPWWhTNC9I?=
 =?utf-8?B?Uk1OQVBpWkxaOU9WQ2pXU05aY05HZTdJdjV0MGVuTVVOVTg3a2xnV1dLc3l4?=
 =?utf-8?B?cXBOUWVPcDFQQklxNDFqV0ozeFNrOUZiZkh6Q0N4RHFWRmxSUmwrQUd3cjhr?=
 =?utf-8?B?bzh0NlU1a3RWNUgxalFxS1VieWtYVWRlbk1JdzBRWE1QMUlieHA5M1IwYVZr?=
 =?utf-8?B?MWc9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e813e42-58af-4dc6-3f18-08dac197f348
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 14:45:59.3260
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 53UEU6aBynW7lGLNT/3iHUXFQ5pDKdTSlNkH4XetPDC+RquFtkNHjxFta9f3tiPc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR15MB3103
X-Proofpoint-ORIG-GUID: 6EE86P_hRllApdPzRztQo4KxK5lYQWGr
X-Proofpoint-GUID: 6EE86P_hRllApdPzRztQo4KxK5lYQWGr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_11,2022-11-08_01,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/8/22 4:19 AM, Pu Lehui wrote:
> From: Pu Lehui <pulehui@huawei.com>
> 
> When cross-compiling test_verifier for 32-bit platforms, the casting error is shown below:
> 
> test_verifier.c:1263:27: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>   1263 |  info.xlated_prog_insns = (__u64)*buf;
>        |                           ^
> cc1: all warnings being treated as errors
> 
> Fix it by adding zero-extension for it.
> 
> Fixes: 933ff53191eb ("selftests/bpf: specify expected instructions in test_verifier tests")
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Acked-by: Yonghong Song <yhs@fb.com>