Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3719687rwb; Tue, 8 Nov 2022 07:41:25 -0800 (PST) X-Google-Smtp-Source: AMsMyM6L16f/2YADawi0aq8OYLbOBIDRJQ+F84VH7rmnR3ovfyVH1BvpDNEOug52fvZrSpHvB5fE X-Received: by 2002:a17:906:7843:b0:7ad:e82b:b635 with SMTP id p3-20020a170906784300b007ade82bb635mr42490804ejm.23.1667922085633; Tue, 08 Nov 2022 07:41:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667922085; cv=none; d=google.com; s=arc-20160816; b=oRqAYEap0h28ZUHwYPIB5HZEPt/7dJVEZybkWaNfIY4Gv+m79hqq+VF3Xg1rJuz+dF T7g48InwmUpF05s6aQj2TezfrPBRZMZ+kOP1TXX8O6R0h0BMoMZkCN1XhD+fIP3IqAsi 86FThU2Blr6v+bFzuI9cg0sExlrgw6k6QJ6VkUW/XVH7SbL6J8O8OCYdmCn1tsVghI3N FKmhMlF/aLqEUzbPuUC1CL0bGRXdweauICohwHDoAMe2U47FdYrIGSW8IrBqG51r/dbo tyBSWunaeZ+YDD2OmsiHe1tPuzqfIKo6CXxkna+OjiJrP9SXwd9PA71TF5gtE9xQMFi1 LE8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cTyRbf8SEAUHOM7AyizlE1qTZ4qxin4jT06zD+mSuqg=; b=h2yChHP4qdG6P16Yu6ofdJa0dnRzlNlmYnI6tWyrR1DC9U0dfLXYPZnOC4f01mVDX0 Pq0h/Rsx4tOb8qeYL0EPJxJlPQ38rcT36Fkc22gAKMYWFg6fBgOdJ1L6ByK13m73VQGv nB+vcxkZBRn0Ezm1Fj5j2rG7jz/4Q/tlnxnxc4+i3DL/a1mGTd37s8Fje0quNK3w+UKk dqj368snvBsTsOCmkcvlPi39lsPJPRswhMXR2NOeD7MkOUAZnivFfFL1fOGu0BMGsp2H 4Xc0oFJPBs9FAu4xzKig5jewg97S/8QguUUAy86eJwBm3ur0TnUndkpX+91agNY/ZIxv r4VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rHkE3wlH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t17-20020a056402525100b0045cc36d6d8fsi14782441edd.336.2022.11.08.07.41.04; Tue, 08 Nov 2022 07:41:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rHkE3wlH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234140AbiKHPXl (ORCPT + 91 others); Tue, 8 Nov 2022 10:23:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233665AbiKHPXi (ORCPT ); Tue, 8 Nov 2022 10:23:38 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16FF4167D4 for ; Tue, 8 Nov 2022 07:23:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A65716162D for ; Tue, 8 Nov 2022 15:23:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97869C433D6; Tue, 8 Nov 2022 15:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667921016; bh=uS0okb+qfQuarqze9+mm9LuFlTvjUVNK5qOFiOfm210=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rHkE3wlH5cFW/b5r68j3qWGrMqoa84JePsIEzElGK1iBRX13wlPfFql6WuKS4Ujxd reSeXGE+/v7PAKf4uk1wBfpGdmj1D/48hKUaLqqdRShpRi8g7xcs0UaCKhYhdMVNug FK4p2cwBzUEMrqarpycMMiuFbVRX1MjzVyHvAJbs= Date: Tue, 8 Nov 2022 16:23:32 +0100 From: Greg KH To: Jacob Bai Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to table.c/h Message-ID: References: <9bb563727915e3f3edd863837608336b99564462.1667723306.git.jacob.bai.au@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9bb563727915e3f3edd863837608336b99564462.1667723306.git.jacob.bai.au@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 06, 2022 at 07:31:17PM +1100, Jacob Bai wrote: > Same as other rtlwifi drivers, use table.c/h. You say what you do here, but not why. Why rename the file? What's wrong with the existing name? It's not causing any problems, right? thanks, greg k-h