Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3782059rwb; Tue, 8 Nov 2022 08:18:59 -0800 (PST) X-Google-Smtp-Source: AMsMyM4AINHx133BEH9pNcsxeIuoQngufIUvY2YY9ZhSqJMCO0CsBWfEEHTt0NCvUGKjwv/KFXzN X-Received: by 2002:a17:907:3f85:b0:733:3f0e:2f28 with SMTP id hr5-20020a1709073f8500b007333f0e2f28mr51446871ejc.376.1667924338419; Tue, 08 Nov 2022 08:18:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667924338; cv=none; d=google.com; s=arc-20160816; b=AYR3HBR4u6M+mqd5MOC2f3rKN9es95aeAyjoQeJeKLr+lc9b+Fr2tMwtvLdvfTOSup xVU9YXHFGARy0spX5hOzUqrtSF3R9K54IVRrrXh2PIRFOZpaLW7c10Vpw7DWwDq1g3Ht pKMA4TC94ppqmU20YLdeHrmP/cNBwr8GuMxZ4aiQ8Qzcexy3X/XUVpksLSN0H3uIxxZ3 twXVLwZSb7HlpVOt0RIf3vZwGJ9wjOJKZQglAm8uBh5q1KZcijsA86+yaXz2eo6SLTx0 wBUH2eg7Vqy9bPvOtZYlb/fxXaABnxD4PSPuDVRS9qDD0vPhvDQsIGeW68vJ7Qnp7/md IWKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=cdFdyfM+lBUegXKE0dyJKBMLRAxTqhmr8VSztQ41RO8=; b=LBm1WtOFXk/xdNC3M5Cr2OffzU9C/urg42Jm5GY9xpi5CLW+f7O7/nj7sjghnTbXKD ZpI6JRC9y0d1WfOA1ngDlQxX01CiPiB3xdP27b9/NpPbP6fjUaFYzeHGsQixkss0o9Ho RSpIZb/joEdM774DLO3uHS/KA9sLM2Dg9CWporPMmJItBzKwwClvMdYcAOVxfbpLja1g zDupSNQ9iDp2tD57KVVovexsEKt64jIRpqLYA/drg1g1Q34Ugkw1YB959XQiYME6Z0ai mFkWAUuWWyLN5ZF6gBCNT68gaxJ4sA/p2/DQbmLit1s4ySGyL0ngNWCDCz304r1wxxKb a95g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd14-20020a1709076e0e00b0073dcb2ec4d2si12752409ejc.889.2022.11.08.08.18.36; Tue, 08 Nov 2022 08:18:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234605AbiKHP7P (ORCPT + 91 others); Tue, 8 Nov 2022 10:59:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233640AbiKHP7N (ORCPT ); Tue, 8 Nov 2022 10:59:13 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 66CFA1A380; Tue, 8 Nov 2022 07:59:12 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E6E61FB; Tue, 8 Nov 2022 07:59:18 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F12263F73D; Tue, 8 Nov 2022 07:59:08 -0800 (PST) Date: Tue, 8 Nov 2022 15:59:06 +0000 From: Sudeep Holla To: Conor Dooley Cc: Pierre Gondois , linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Gavin Shan , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Jani Nikula , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 1/5] cacheinfo: Use riscv's init_cache_level() as generic OF implem Message-ID: <20221108155906.3pssiipdfrm55q56@bogus> References: <20221108110424.166896-1-pierre.gondois@arm.com> <20221108110424.166896-2-pierre.gondois@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2022 at 02:07:41PM +0000, Conor Dooley wrote: > On Tue, Nov 08, 2022 at 12:04:17PM +0100, Pierre Gondois wrote: > > Riscv's implementation of init_of_cache_level() is following > > heh, "Riscv" always looks a bit odd! > Code movement looks fine, nothing surface level is broken on RISC-V. > Reviewed-by: Conor Dooley > Thanks for the review and testing. I was planning to ask Pierre to cc you next time but you seem to have covered that for me :). -- Regards, Sudeep