Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3941749rwb; Tue, 8 Nov 2022 10:03:54 -0800 (PST) X-Google-Smtp-Source: AMsMyM5o4Mg6P0BtrcNfsOk5xRWdmH5xqftpmy92l5J24XKndYd1byW72XsntXKTN4v/B3fyCYr7 X-Received: by 2002:a05:6a00:1995:b0:56e:1fff:da75 with SMTP id d21-20020a056a00199500b0056e1fffda75mr34107501pfl.81.1667930633899; Tue, 08 Nov 2022 10:03:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667930633; cv=none; d=google.com; s=arc-20160816; b=IxE6myzGSwhWZzc/yPWJy58EemonDeAnCJwN51ahLxfpGQzdrZjpst1S0fMTJqSBIB mRTtVWw9u7hh+tOlYqkUaxtplgnkKIwrSN2g5mwEmMJw+eeYFjhKvNQcxQbwhF1empcQ m6LiVOuph/bsKrLaLZvNgl378boAl5uQE+NtnP5PKDneVC12kJelP0r8FopZuuqcUJkm Q+pPecsiGtK8XPkpV+at7Qn7hZPJVfItPkHo/qhKzp8twRNMbo0+Tzyn8aO1M56cY53h oJLjYZmmwIO/ccs83TdK03AZupGdT7BmoojWe0rLt0wc54VfCnBDdCEzd0SXV83+Q08G 6U2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GW/LR9vvq2HZZ2+kjoTPPKKfdPcSjunAG8TGEsul7P4=; b=ZKe8t15LHEMIIscEVS2NI3D4RSHxhyh0aX7Ta6Ctd1spP5dntaZrBsh3H0QkgXng4E 1UlPbbV81cqtviKs/9vGn0jmdHTSHopnbvWvuoHQm+eOJQO0H0uwJ2oHMHnooN6LpQRe jpjIip5m5WHt2j46PSAGvY+LayFUvO2G0c0MnfyuhPnOEzy63kRSohViJH+1ft1ERFmk OLCDUXgBqePAqba6HAkqO4mdpXWPdgRs2+E89oJYQtVX4A0tM7dLD6etWffiNbV8MOyM LR3mGRlkPewirJ+EgRiz7qzJx4oTUXdsZV71zJVt6ghuOmJNLNcCXoypvq9KbyOyggnM WmOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=BhnlnN82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w1-20020a170902d70100b0017a0d1d072dsi13330816ply.336.2022.11.08.10.03.41; Tue, 08 Nov 2022 10:03:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=BhnlnN82; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234619AbiKHRuL (ORCPT + 92 others); Tue, 8 Nov 2022 12:50:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234692AbiKHRuK (ORCPT ); Tue, 8 Nov 2022 12:50:10 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 068DCFC9 for ; Tue, 8 Nov 2022 09:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667929801; bh=+NOhY9cMPYMZoVEU1AbEPcrtIM+hVlOUBhjYh0sY7+I=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=BhnlnN821nRvoicXUe2C8HbodRGTjjFz8AemyVxzGlSgAPKXREkR93meXRpyYLXgC 227L29KDaR5MHZRMN8X9W5AzldckrTa4DvXxjdjmnaPNDbgz3hxKncwryCziJu8kl6 fEO6IDtN8F+TUL0X34Rw1kQq2oUwqKDbO/E5aaqc= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 8 Nov 2022 18:50:01 +0100 (CET) X-EA-Auth: OT8zaZpmWzh0aQdK0flkYBr9OxQaV++XHIQ5uECHuTZRg8ofv+M7kTKRMT+3r6H4njd1P/qZBDFa3NvpCjpHmdibuC5xTG2S Date: Tue, 8 Nov 2022 23:19:56 +0530 From: Deepak R Varma To: Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: rtl8723bs: Simplify underutilized 2D array to 1D array Message-ID: References: <4fb8d9783553d15a58e774d7137519d46e58ee3a.1667586648.git.drv@mailo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2022 at 04:19:41PM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 05, 2022 at 02:47:49PM +0530, Deepak R Varma wrote: > > On Sat, Nov 05, 2022 at 02:14:12PM +0530, Deepak R Varma wrote: > > Hello Greg, > > Upon further review of the structure, I observed that the member "bIQKDone" is > > also not used anywhere in the code and it can be removed as well. That cleanup > > will lead to replacing this entire structure by a simple one dimensional 'Value" > > array. > > > > Please suggest if I should make that change and send in a revision? > > Yes, that would be a better overall change. Hello Greg, The patch is resubmitted earlier with following subject: [PATCH v2] staging: rtl8723bs: replace underutilized struct by array variable Thank you, ./drv > > thanks, > > greg k-h >