Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3957884rwb; Tue, 8 Nov 2022 10:13:49 -0800 (PST) X-Google-Smtp-Source: AMsMyM5unVsfKNfD64F6GgfiYs0L8tEQlmxxZYolSSGT20TeOzaKfWJ01RtXkHRmjej1Uynvh88A X-Received: by 2002:a05:6a00:b82:b0:56c:d5bf:1019 with SMTP id g2-20020a056a000b8200b0056cd5bf1019mr57055792pfj.72.1667931228933; Tue, 08 Nov 2022 10:13:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667931228; cv=none; d=google.com; s=arc-20160816; b=wehqKYRPnqbkDo5Ol2nM5jtDotf+JjbGwO27hZAjfkb2TSr29zdR9XqxqGyNK7wS6u yG+RsuqxaLx8Yi2pQYnb9cnjL1AOoNvX+I8kjpIUVBZA0uGRV2LhVQecX5taVZ1DpSi9 W/t2y0RR0zRxiAXstaOEzx6mh8w1a8l5WH057Pg98nta4XgPgMMkWyIo38ttAIUyttca 0hAZKgWNA3RXDz9gQ0+BDldpp1W71/7//FBhsiO720a3SIblTclOc3x9cXxDy2HmOUx0 k8aQFOeLfq2DDmk8hz/98eqi3bEALpAEK4fV+8MzQQV9Ij4G+ZdhmZKt+fT4o1s2oOQK R82g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=srOBYBXjJ0LyLH8d270eQqxw6HUjH3xiNMOvx7A4gsY=; b=up+e0VpijBkWaO3REZJ0t5zOglCiizrhDNqmKm/2FsXwttuRZgc1h6WStGfS2tB7nI Hv40Rawotys/mbwtxF4hAXjJcuzb1mBOkMjoCuFt4kc6Eze2JtZJ7auI2Hb1F7gMNhar cGxfwsOJtdUhlXqhGHcNDgmV8cYG1GWvd5SImobLUTbQfo1f94Gg71npMjsTUHB2egAE RvSAc6rXSDG+yx/POe1hdIiOXMPjljw9dgGkLO5jFz41gSkw9zZKtgvi/BQM79FlrHKs iWT5RclFjFzAJyj7sLapmVEJ5sKZr94XwqnfS2rosX7AvyiU9cYbBDpspg9Y+Gn6UNMi kSIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eENReWR7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f4-20020a631004000000b004404162e5e0si13751270pgl.593.2022.11.08.10.13.37; Tue, 08 Nov 2022 10:13:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eENReWR7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233829AbiKHSAZ (ORCPT + 91 others); Tue, 8 Nov 2022 13:00:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234355AbiKHSAX (ORCPT ); Tue, 8 Nov 2022 13:00:23 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E1FC4298A for ; Tue, 8 Nov 2022 10:00:22 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id k5so14490653pjo.5 for ; Tue, 08 Nov 2022 10:00:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=srOBYBXjJ0LyLH8d270eQqxw6HUjH3xiNMOvx7A4gsY=; b=eENReWR7gzXXy1BAqG4WBmwK5FBnPlzeaSmQ7VyJQ6ab5Emvzcajwytz1OeD9nQw6B CljEKaLIYxRyNzkOqoDmiaCUOTNRyJred4Ed0aTA1PCqRPe9GF+4+LNex7NhRR4O13gO f3kGCD7CbeuIEkaBwAO3dkqMwPsAEJeZEEwk4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=srOBYBXjJ0LyLH8d270eQqxw6HUjH3xiNMOvx7A4gsY=; b=xfMjzvXD6al0aHQm0V4BlidBm2efCDWEtOvyYFSARYspIA4rgQbieQvzwYpCbvSC++ abMPM1lal3BpWi1H1ditult16SuqyvwmFgMmNxhSL29cUanL+w7MbNXosimQt6rofqwA coHTLi3300qEsqTCRyENNvDH8myZ9nw0xRbRvZP00pI2t8YM/bczJAJAVNy+qoH1B47/ VwobImsx1qQYj23lm6TRT7WfRqt3b9V8DEVa9CtmBL4/JS/Opg6xgcK7Vjj17+JDMEVg fN4R0ZU51WRJaxIESM7j/UholYXzYbWWxv0vnDg09VxCw8mMrCJYn/0zLgYLSsWonCxH ktXA== X-Gm-Message-State: ACrzQf1sPpqOfzCNKvkRZipFxj0+hQjyckkHx9XXJqMhTweVnyyHcvzg /LdZqWQI00LQPo12WcHg5Xs21g== X-Received: by 2002:a17:902:e5cc:b0:187:2b02:969d with SMTP id u12-20020a170902e5cc00b001872b02969dmr44540139plf.9.1667930421991; Tue, 08 Nov 2022 10:00:21 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h3-20020a63df43000000b0046fd180640asm6040904pgj.24.2022.11.08.10.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 10:00:21 -0800 (PST) From: Kees Cook To: nathan@kernel.org, Arnd Bergmann Cc: Kees Cook , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-arch@vger.kernel.org, xiafukun@huawei.com, ardb@kernel.org, zhaowenhui8@huawei.com Subject: Re: [PATCH] vmlinux.lds.h: Fix placement of '.data..decrypted' section Date: Tue, 8 Nov 2022 10:00:17 -0800 Message-Id: <166793041556.1591113.6967612003001783225.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221108174934.3384275-1-nathan@kernel.org> References: <20221108174934.3384275-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Nov 2022 10:49:34 -0700, Nathan Chancellor wrote: > Commit d4c639990036 ("vmlinux.lds.h: Avoid orphan section with !SMP") > fixed an orphan section warning by adding the '.data..decrypted' section > to the linker script under the PERCPU_DECRYPTED_SECTION define but that > placement introduced a panic with !SMP, as the percpu sections are not > instantiated with that configuration so attempting to access variables > defined with DEFINE_PER_CPU_DECRYPTED() will result in a page fault. > > [...] Applied to for-linus/hardening, thanks! [1/1] vmlinux.lds.h: Fix placement of '.data..decrypted' section https://git.kernel.org/kees/c/000f8870a47b -- Kees Cook