Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <Y2kxrerISWIxQsFO@nvidia.com> <20221108035232.87180-1-zhengqi.arch@bytedance.com>
In-Reply-To: <20221108035232.87180-1-zhengqi.arch@bytedance.com>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Wed, 9 Nov 2022 02:36:32 +0900
Message-ID: <CAC5umygzc=H-9dCa_pLoqodS4Qz90OVmQkrvFOCPv27514tP3A@mail.gmail.com>
Subject: Re: [PATCH v2] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr
To:     Qi Zheng <zhengqi.arch@bytedance.com>
Cc:     dvyukov@google.com, jgg@nvidia.com, willy@infradead.org,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2022=E5=B9=B411=E6=9C=888=E6=97=A5(=E7=81=AB) 12:52 Qi Zheng <zhengqi.arch@=
bytedance.com>:
>
> When we specify __GFP_NOWARN, we only expect that no warnings
> will be issued for current caller. But in the __should_failslab()
> and __should_fail_alloc_page(), the local GFP flags alter the
> global {failslab|fail_page_alloc}.attr, which is persistent and
> shared by all tasks. This is not what we expected, let's fix it.
>
> Cc: stable@vger.kernel.org
> Fixes: 3f913fc5f974 ("mm: fix missing handler for __GFP_NOWARN")
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> ---
>  v1: https://lore.kernel.org/lkml/20221107033109.59709-1-zhengqi.arch@byt=
edance.com/
>
>  Changelog in v1 -> v2:
>   - add comment for __should_failslab() and __should_fail_alloc_page()
>     (suggested by Jason)

Looks good.

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>