Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 08 Nov 2022 21:05:08 +0200
From:   Vadym Kochan <vadym.kochan@plvision.eu>
Subject: Re: [PATCH] mmc: sdhci-xenon: Fix 2G limitation on AC5 SoC
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Christoph Hellwig <hch@infradead.org>
Cc:     Robin Murphy <robin.murphy@arm.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Hu Ziji <huziji@marvell.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Elad Nachman <enachman@marvell.com>, iommu@lists.linux.dev,
        Mickey Rachamim <mickeyr@marvell.com>
In-Reply-To: <VI1P190MB031779C030CAED8026D53D1895259@VI1P190MB0317.EURP190.PROD.OUTLOOK.COM>
References: <20220808095237.GA15939@plvision.eu>
        <6c94411c-4847-526c-d929-c9523aa65c11@intel.com>
        <20220808122652.GA6599@plvision.eu>
        <3f96b382-aede-1f52-33cb-5f95715bdf59@intel.com>
        <3d16ebad-ea6c-555e-2481-ca5fb08a6c66@arm.com>
        <20220816205129.GA6438@plvision.eu>
        <94888b3b-8f54-367d-c6b4-5ebfeeafe4c4@arm.com>
        <20220817160730.GA17202@plvision.eu>
        <80d2538c-bac4-cc4f-85ae-352fcf86321d@arm.com>
        <20220818120740.GA21548@plvision.eu> <YwHOCHmKaf7yfgOD@infradead.org>
        <3b88438d-1bb0-e980-b4db-1f8663dc6042@arm.com>
        <VI1P190MB031779C030CAED8026D53D1895259@VI1P190MB0317.EURP190.PROD.OUTLOOK.COM>
Content-Type: text/plain
Message-ID: <VI1P190MB0317DC34760DFDE69F69A700953F9@VI1P190MB0317.EURP190.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aZNP+mbv7iZzj6TMjUZMmeIArr405bPayBcjH/GTleQn5IG7IJpFWIDc/kdC?=
 =?us-ascii?Q?tHdOgz/yohCj4aQmBn0YgDaIRoUahoDgzDAHlqimlYyqWFmWILnlNYpvaCPV?=
 =?us-ascii?Q?SHS/KlqaigYdYpwKOYgIpl6nuWsSWLnYcmhlddUzlKEqNjw01paKkYh3/ylH?=
 =?us-ascii?Q?PUlyXZ4F+OHEIgqsnNiDXp0B5SYWr5KgUml6ZTHtstG9cVLxMOU10lG+VsfL?=
 =?us-ascii?Q?xaaQBj0YgOP3NgjWkuWmGmERPAtWR6GMsE8A54X3eJBlKoSanf9glWBM18IM?=
 =?us-ascii?Q?aC+mSOd+suS1JrgwMtwZpTxqK7hm6QtH90qqMeqM0wLw3ZYiLGt2oyb+O5+z?=
 =?us-ascii?Q?Q2IRXrcdFPOGK9Bk55mt88SC895BCPuUIhYzSsv1iD20sndobZsbiVq6tGCx?=
 =?us-ascii?Q?Z+e8loAqRGIl2El61afZMdbjW6xkU9XagHDJJyYVWnCK9uBzKsZ8zUPWow1z?=
 =?us-ascii?Q?eOVEb/icw7WkxRi/f/TZ3zlHiVW3dcG5blXDoTEn+/YzdLPhD3dVAA+d7O+W?=
 =?us-ascii?Q?XVu5KyBukeGrH8AWuVu8IPtNqMG8zPATrakkuWL8WMXvICKua2iFUPvxjqli?=
 =?us-ascii?Q?NK03pKjC9zj90dRCqMs441YRxva7ODtNVtMsyO31+bXB93rnp/bkEdz+pW3v?=
 =?us-ascii?Q?vSH9uz6v3Df2PSf39nT5/To0HBlgQ8xrFtvTVjBRuK9kwAollvN9/RYQybDE?=
 =?us-ascii?Q?orvmmh68gxG1Rp4AOxKNtr3p16KWGbV5UZ2Wqe99mLJNtzTZ+pPZzhaWW9Ws?=
 =?us-ascii?Q?tanNIdY85ZucewJboZavn4EoHktUKiWrbCQ7FMyPW2EwTX8Nbr6paF/ral/P?=
 =?us-ascii?Q?2BRabdHj009tQXbCmdSCvBDzapwJi1xKtEUMh80t/VG7cTUQdvY/Q2w0N4T4?=
 =?us-ascii?Q?24qd2IwpbOqXPoyUXeRDJMWG5Ok62b5YQElh223jSAr+DJ9RSMi2WxMMcg18?=
 =?us-ascii?Q?ky622fEzRRyhiWIdsBU2BA8vdycoSiKwuytLUpOuXyKwPYFEGPDTPFNJtH5e?=
 =?us-ascii?Q?1W5+iEfvBZ8PDc7+DmUOkZV+fZ+3ihYo8sfyMFChTkgBLqg2oRsQSOFk2lN4?=
 =?us-ascii?Q?s8UurUkmO0vE1GGjFHPb28/crYpzQHFllPNrrTJ6ox3fsFmiT6ldfFLWBYnV?=
 =?us-ascii?Q?R22MEFDlBtSz1ZtRphr6v2n+eQv5O9E4FLpy9kD2hCPf4GH0woaJ0TzxnFsk?=
 =?us-ascii?Q?c3e3wlDKmRUn28mZLGg3oZR36fFurdqIs30eLHUOh4ju1CGZVDgyIymjkvaE?=
 =?us-ascii?Q?COCqnXgRMNotSyI9KhDMj2/DHD5ED8MLOMkswNntsTnsedkspsQcimoFB4Bx?=
 =?us-ascii?Q?IPGVehEnTKrPC3x/ybtQeV1x11+/Y+RIyJNiq6aVGVwTrWT1NMx2nQEM+Mul?=
 =?us-ascii?Q?LIzU0wbJjdq+JUqfrBblvOlnm9hmxGro9gVjPtH5IM1daXyjtG10QP9rLbur?=
 =?us-ascii?Q?u3Ox5Vpnmb7EVnLm89G/lIgGEvVJo+0CWn8c888/xgzrV5Gkm1XpLss7JJRy?=
 =?us-ascii?Q?MRYe37rCJCNW7gliZtcoqP/3nMaYToKy1WJecLP9yB57jQvS97Br3GPa/fds?=
 =?us-ascii?Q?gB8MHANJ82Gl7anf7ibtcAQto+4gK45cUg4XLVp5xXLHhNQh9wysujEzT4sK?=
 =?us-ascii?Q?jg=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 303431f7-2ed4-4ba1-ff60-08dac1bc2864
X-MS-Exchange-CrossTenant-AuthSource: VI1P190MB0317.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 19:05:11.1284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x6pmUZbP/0BtVgRSx1/8g8gdnDTVM5onwWkBQR6DaZfzYDqeh5qT+CDyXduSOhAeyWj0GTr1zIeVJElFNRm4SiQTOm0LKRKUAePerBWcGus=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P190MB0817
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Adrian,

On Thu, 13 Oct 2022 09:40:00 +0300, Vadym Kochan <vadym.kochan@plvision.eu> wrote:
> Hi Robin,
> 
> On Mon, 22 Aug 2022 11:06:43 +0100, Robin Murphy <robin.murphy@arm.com> wrote:
> > On 2022-08-21 07:17, Christoph Hellwig wrote:
> > > On Thu, Aug 18, 2022 at 03:07:40PM +0300, Vadym Kochan wrote:
> > >> It works with the following changes:
> > >>
> > >>      #1 dma-ranges = <0x0 0x0 0x2 0x0 0x0 0x80000000>;
> > >>
> > >>      #3 swiotlb="force"
> > >>
> > >> Is it OK to force the memory allocation from the start for the swiotlb ?
> > > 
> > > It should be ok, but isn't really optimal.
> > > 
> > > I wonder if we should just allow DT to specify the swiotlb buffer
> > > location.  Basically have yet another RESERVEDMEM_OF_DECLARE variant
> > > for it, which shouldn't be all that much work except for figuring
> > > out the interaction with the various kernel command line options.
> > 
> > We already have all the information we need in the DT (and ACPI), the 
> > arm64 init code just needs to do a better job of interpreting it 
> > properly. I'll see what I can come up with once I've finished what I'm 
> > currently tied up in.
> > 
> > Thanks,
> > Robin.
> 
> Sorry to disturb you, I just 'd like to know if you have
> some ideas to share or patches to test ?
> 
> Thank you!
> 

Since AC5X eMMC controller can fail to work on boards with >2GB memory,
and considering that the best fix may not be easy (as it requires arm64 infra changes),
so would it be OK to use PIO mode as temporary solution ?

I understand that arm64 changes might not be trivial and it might take significant
amount of time to implement considering this unusual case, I just think that better
to make eMMC working even if it will be slow.
 
Thanks,
Vadym