Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0fd9044b-d0c9-5d93-3d5d-8c6baaf695fd@amd.com>
Date:   Tue, 8 Nov 2022 14:45:21 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH] drm/amd/display: Amend descriptions within enum
 pipe_split_policy
To:     Carlos Bilbao <carlos.bilbao@amd.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com
Cc:     aric.cyr@amd.com, Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        daniel@ffwll.ch, alexander.deucher@amd.com, jun.lei@amd.com,
        airlied@gmail.com, christian.koenig@amd.com, bilbao@vt.edu
References: <20221107143715.279841-1-carlos.bilbao@amd.com>
Content-Language: en-US
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20221107143715.279841-1-carlos.bilbao@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWlsajIrTGlKaVFDa1V0VkswOTdKSXp5UFJGZC9qNWRNQ2lSZjVCQ255aFFj?=
 =?utf-8?B?SHl3WGVFdjFkMDNpT1J1Q1JWNEw3c25Gb1dWeHlsWXJXckdtcyt2WFByM0tp?=
 =?utf-8?B?UWZ3WnFTTUUxNWY2NnlNOUwyU29GS2RtWFpxTll4ODNmUWZnMW8zOTVsSVlq?=
 =?utf-8?B?SnBWTzdiRldMMURPSk43dE1aeGF5ZE5wRWVYU2hhWHd0SGJrMXZYd1FvVXpU?=
 =?utf-8?B?SHpleHlCY0FSdDl6VTZBOFlmejZpd1RUSDVheVQ1bDFZSXhnOXE4eTZNd3Zs?=
 =?utf-8?B?S3d6VThwMFFhYVdTZWZJRmo3TTJpaXNEM0VEcE94ZVJKaXNOcWlKTXg0QkFY?=
 =?utf-8?B?ZnNnenVGN0dmSzJ5TnY2dHBac1lPVXN2MGI4cm5iVmNvN3hjQVBvNEl6cVpn?=
 =?utf-8?B?cFN0RHZYOSs0QU1yVFYxSVFGaTBuWGpYZ1FWc1pqMXZzYjV6VGNNYnR0R0d4?=
 =?utf-8?B?ZXRrZXlrYzZkT2NwcnZzOEJqd1RqeW5OWThLa0VNQmU0ZDNYN2VCckZRWGRH?=
 =?utf-8?B?YnNOWllaK3BjUGNMV0F3TXJvd0p6SGVlUGtPYlJCS2g4Tm9NYStzemVaeUhO?=
 =?utf-8?B?SGtHdDh3RjN2VXZpZ0RlcHA1VjZKRjkzczdZU2tLcW9sUTVDZ2MyZkdEY3ZN?=
 =?utf-8?B?MFI0L0JrSnc5aDg1UDlRVmJONFNzVEluVnhjZUtsU3R1OVhkWjR6ZDlHQ1Fp?=
 =?utf-8?B?alI1OEtZOEsvRmN0Smx5aGo0TmZjQmtjNW5pVWdnZ0xkWEVXeHQyQ3IvRDBQ?=
 =?utf-8?B?V080SE5NUEV2RTl4OHljbUozSmdUVDlUZkdQZzFqaFpGVGlPQjRERGxXUDhu?=
 =?utf-8?B?ZzVnZ0YxYUdHcUZPNWlBZGp6STk3Z1ZSTjRhT3hSR1JIanlGUDU1aUVWWmVX?=
 =?utf-8?B?Uy9MU2JCczdFWGd0OTYvSzEzQ1lLeC9mVXRoTGYzYzJTUjBIVjJickVVQnA3?=
 =?utf-8?B?blhNTFFIcjZ1TVNtWDlUSVloVnZpSmxqbVlyTzJmNlExNGJXaFZUcjhZTGVQ?=
 =?utf-8?B?TlAwYWxRZmZIbytDS04vMVNscy9ETEM2WnBNVHBZVWNKSndSbGQzZzZnSXJF?=
 =?utf-8?B?dmhXMWpDT0hzOWtTanU0ZG5FZjBhK0FNQ2NoODg4NXhHSnNLaFI4VjAwc0dk?=
 =?utf-8?B?a0lCUTNUa3hXcmMrbCtMY1BQbnl0ZlJmNi9Xd3dxU2Y2TkVoMGtDMytLWWFN?=
 =?utf-8?B?aWZObFJKd25IS0UwZmk2R2g2RUc4UmVzZGlmTjhFZ0w0NzJnZU1BbjY2NUJ4?=
 =?utf-8?B?MDJmektoQi9ucVpYOFhnUDJZOUsreUI2Qm9VT2ZYRW9jaTcxcmxESFZ4dWk0?=
 =?utf-8?B?QThDWFVPc09rNk0yTzhIRGJ5YUV1dFFlb1FBanZSR01VOEpiOTF0RURkaG5z?=
 =?utf-8?B?OTg3RlVPV0ZFSkFhaFJ0T1NzTVU0SHowZnZ6RXN2clFJSGlQbElvYnRQdFJa?=
 =?utf-8?B?REJxZ291bmJyTHU3L1lZWnlzcG1LdlMwdGpESHo5MElDeHF2TjdyRGErb3lr?=
 =?utf-8?B?V2g4clc1OC9OR25PN25wdjRJRU50RFR0UnVFdWJpeTNGNlhtNDVBckpMYlpY?=
 =?utf-8?B?TkZNbmpqN2krVFU2SE9vMVZqRUNYb1FiM2xwNnFMd3RIaVcvUVFNVkhEQy9v?=
 =?utf-8?B?M3Z3RTlxN3lHOWlaZWkyTEhPN0Urd0kwVmNsV3FXeTBkbGxhQldabDRHWi9y?=
 =?utf-8?B?MVJrYlZCZVJPWjlnblUxbHdpajUvNU5WeWZ2U2VleXl0WUtiR20wYjFCNi90?=
 =?utf-8?B?bXZxeW5IdUxSeWNMN3Uzb3BiYkJPWmZ2dDdBRlFYUWpHcXNzeHVYMjdLckQ3?=
 =?utf-8?B?c0pSRzg3ZVlJOFZxaGRSbGNmbXZIcDk1SDBob09xajdqZW1EWS9US01FNTM4?=
 =?utf-8?B?MmlWdDhZMzgwb3pTazhUeGQxVENuSkpMTlNDa0NINWRtV0xmNmovRTAvb2pn?=
 =?utf-8?B?VmpoNkgxdVJ0dWRSOXowR055ZDRHY2prU1BYanNHWCttWHFxNy9MREthcHUy?=
 =?utf-8?B?SmZZV2psUnhXN2ZXM2lLdThlUU01QUdDTW0zeVBFdnlKSkNIYXBPRzlEM3RC?=
 =?utf-8?B?UG1HOU80UTg5SWVqVnhzNlhacjVSdHhjVTJHY1ZEWC9GL3hMOGo5V2Q1a1Jt?=
 =?utf-8?Q?2tHxrX40rHvx8H5HUOApxjqH7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c04a5bb-0ffd-4295-734f-08dac1c1c834
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2022 19:45:26.1044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8ApwxW6GCy+yd30TcIoFm6DchwRhEXE5wfI2dhLIAhmkpOHQtXYKMakBktaXAJ5lU8ppVYVdN/l0+Imk2CmJVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5319
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/22 09:37, Carlos Bilbao wrote:
> Correct descriptions of two last fields of enum pipe_split_policy, updating
> comments with proper field names.
> 
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dc.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
> index bfc5474c0f4c..277631a899d8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dc.h
> @@ -457,15 +457,16 @@ enum pipe_split_policy {
>  	MPC_SPLIT_DYNAMIC = 0,
>  
>  	/**
> -	 * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not
> +	 * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not
>  	 * try any sort of split optimization.
>  	 */
>  	MPC_SPLIT_AVOID = 1,
>  
>  	/**
> -	 * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize
> -	 * the pipe utilization when using a single display; if the user
> -	 * connects to a second display, DC will avoid pipe split.
> +	 * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try
> +	 * to optimize the pipe utilization when using a single display;
> +	 * if the user connects to a second display, DC will avoid pipe
> +	 * split.
>  	 */
>  	MPC_SPLIT_AVOID_MULT_DISP = 2,
>  };