Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Nov 2022 18:15:55 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Donglin Peng <dolinux.peng@gmail.com>
Cc:     peterz@infradead.org, adrian.hunter@intel.com,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf tools: exclude the include/perf/ directory
Message-ID: <Y2rHC5W1qi0PGwc2@kernel.org>
References: <20221103092704.173391-1-dolinux.peng@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221103092704.173391-1-dolinux.peng@gmail.com>
Precedence: bulk

Em Thu, Nov 03, 2022 at 02:27:04AM -0700, Donglin Peng escreveu:
> Commit 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the
> source tree") moved perf_dlfilters.h to the include/perf/ directory
> while include/perf is ignored because it has 'perf' in the name.
> Newly created files in the include/perf/ directory will be ignored.

Thanks, applied.

- Arnaldo

 
> Can check:
> 
> Before:
> $ touch tools/perf/include/perf/junk
> $ git status | grep junk
> $ git check-ignore -v tools/perf/include/perf/junk
> tools/perf/.gitignore:6:perf    tools/perf/include/perf/junk
> 
> After:
> $ git status | grep junk
> tools/perf/include/perf/junk
> $ git check-ignore -v tools/perf/include/perf/junk
> 
> Add !include/perf/ to perf's .gitignore file.
> 
> Fixes: 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the source tree")
> Signed-off-by: Donglin Peng <dolinux.peng@gmail.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> Changes in v2:
> - add 'Fixes:' tag in commit message
> - make commit message more clearer
> ---
>  tools/perf/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> index a653311d9693..fd7a6ff9e7aa 100644
> --- a/tools/perf/.gitignore
> +++ b/tools/perf/.gitignore
> @@ -4,6 +4,7 @@ PERF-GUI-VARS
>  PERF-VERSION-FILE
>  FEATURE-DUMP
>  perf
> +!include/perf/
>  perf-read-vdso32
>  perf-read-vdsox32
>  perf-help
> -- 
> 2.25.1

-- 

- Arnaldo