Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934551AbXHGPT5 (ORCPT ); Tue, 7 Aug 2007 11:19:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750854AbXHGPTt (ORCPT ); Tue, 7 Aug 2007 11:19:49 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:58710 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755949AbXHGPTs (ORCPT ); Tue, 7 Aug 2007 11:19:48 -0400 Date: Tue, 7 Aug 2007 10:19:45 -0500 From: "Serge E. Hallyn" To: James Morris Cc: "Serge E. Hallyn" , Andrew Morgan , Chris Wright , Andrew Morgan , casey@schaufler-ca.com, Andrew Morton , Stephen Smalley , KaiGai Kohei , linux-security-module@vger.kernel.org, lkml Subject: Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2) Message-ID: <20070807151945.GA4864@sergelap.austin.ibm.com> References: <20070806185231.GA21550@sergelap.austin.ibm.com> <20070807140827.GB8286@sergelap.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 23 Quoting James Morris (jmorris@namei.org): > On Tue, 7 Aug 2007, Serge E. Hallyn wrote: > > > Shall I resend without the LSM_NEED_LOCK, or do you still want a more > > fundamental change? > > > Removing the needlock is enough, the rest was just a query/suggestion. Ok - I'll explictly lock the i_mutex in fs/splice.c:generic_file_splice_write(). The ugliness there is that the mutex will always be taken - even if there is no xattr to be removed or even if CONFIG_SECURITY=n. I guess I'll do some perf runs and see what kind of impact that has. thanks, -serge - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/