Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Nov 2022 00:14:03 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     Fenghua Yu <fenghua.yu@intel.com>, Babu Moger <Babu.Moger@amd.com>,
        X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/resctrl: Move MSR defines into msr-index.h
Message-ID: <Y2riuwu6vfzA07ul@zn.tnic>
References: <20221106212923.20699-1-bp@alien8.de>
 <542c4313-3833-bcae-10ae-005084d96ea1@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <542c4313-3833-bcae-10ae-005084d96ea1@intel.com>
Precedence: bulk

On Tue, Nov 08, 2022 at 02:59:12PM -0800, Reinette Chatre wrote:
> Not an objection, just an observation: the above is a significant
> change for a patch with the x86/resctrl prefix.

Yeah, I felt it is a small-enough change not to warrant a separate
patch.

> Is it important to distinguish between Intel and AMD?

Yeah, look at the rest of that file.

> All but one (MSR_IA32_MBA_THRTL_BASE) of the register values
> under the "Intel" heading are also used by AMD.

This basically says that AMD is using Intel's MSRs. Which is fine.

I'll fix the multiple blank lines.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette