Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4461488rwb; Tue, 8 Nov 2022 17:59:44 -0800 (PST) X-Google-Smtp-Source: AMsMyM6C6ilkHJZRfmnc/aVU3OPxbHmsm2HbHCreh8159e8AOrc+LQhNK5HVfJL9zYknH09717Kz X-Received: by 2002:a65:5942:0:b0:46f:f741:8adc with SMTP id g2-20020a655942000000b0046ff7418adcmr34207932pgu.265.1667959183961; Tue, 08 Nov 2022 17:59:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667959183; cv=none; d=google.com; s=arc-20160816; b=Op1p991+EQYajK69FTOpB4Uenl+H5DJU0/RcG+MbiJ3J30fix2EeJlAn7gbuOvYu/m 36bp60S4k/yrxg5EmLZLsImpxptsj8stlgdtt0l4lM7/I3IbcEQ9Xx/P+hLkkcp4/rKw ECDTpXm30BQMFUo95BCM6LY5iFqhBDEad/5gpdAfC1Z4E90xXFWqg/I+4wZ8HRAJxa5c 8iBhFTWF1Q8pYOzeNw51s0+UNP6sOlOGh/DRHyc/tS8BJTxO76BOO/VYCCGkVCtZq4wT KryUziJtG8IQpPsqzwCs6saZhYYJphGPrGRu21st0mhoqV2sysce1/CfYpHmOtfygaj0 ifWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=VLIKqgwJ/shUrkwPl9fST0wdgdjFA7rlQw7f36KvTDI=; b=zBnrudg2ImBmOUo0exp5uLJwExoCwG1/OywdRW5VBUoWHiKCE+Rr3R5ksFW2L/CFTw SPnHnxhMXqJro9fql3m/6ffsCW2mgriR5eUN94grLEKfJyphb9Mfi/5g7cMeOOXa94qU hly3PR3GJKBZu9SDI94Ompp/ig5FZ5VL/6yXAk3UAVILZYYDyf1IFvaGti4m1SnXrJ91 UXHrtaxRKVPCnG5Tx3KnjHq9PvVXLI6f5knh39YaJgjf/xaaIkHcEXmU4bNNOT/OL9Cd xR3q9k+07+1aAltrZfPLM1DlHHs5Atm1/KJGk3mmTrttTueBifUbSt5JFsbfMvBfP5mR pQxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U3ePUuXm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k184-20020a6384c1000000b00461ffae7b37si16614914pgd.0.2022.11.08.17.59.31; Tue, 08 Nov 2022 17:59:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U3ePUuXm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbiKIBzh (ORCPT + 94 others); Tue, 8 Nov 2022 20:55:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbiKIBzg (ORCPT ); Tue, 8 Nov 2022 20:55:36 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB8E81F9E2; Tue, 8 Nov 2022 17:55:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C31AB81CE7; Wed, 9 Nov 2022 01:55:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81443C433C1; Wed, 9 Nov 2022 01:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667958933; bh=veYpa7FaRsry6Y/dznGkIf1wj51JZYkzA2/VjZdjWk8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U3ePUuXm8KJ0wbYI4jMIvw7AKFALf/YxRLPRbj3/XewK8+eKoK0G61vG4YQda288w bw7e4xPPaf4hhfZRYDknAAvOnVFShrtgYcTOqJmsR9wwzoXX5jv7hfY5ZQEM0FwfFY nzmqBMIOt5iqudcAZBNbwPmH84AGw1s47iZm0KLZSyuUnb/0qves4RXtka+VSIU9lc RvzvHV2eLISdu827ghwWsJqjdO0VWSECVJyc8W3EeLwO9nMzPdgoKrjxLARUWBpJut wgUuPmfjigVp2mRy63r+kbLbandUi27wD9VE94xNerWAtYwJP2mAOlx3IA3fZGb1TJ 7a4CvAM3DJNow== Date: Tue, 8 Nov 2022 17:55:31 -0800 From: Jakub Kicinski To: Michael Sit Wei Hong Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Voon Weifeng , Tan Tee Min , Zulkifli Muhammad Husaini , Gan Yi Fang Subject: Re: [PATCH net 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices Message-ID: <20221108175531.1a7c16a6@kernel.org> In-Reply-To: <20221108101218.612499-1-michael.wei.hong.sit@intel.com> References: <20221108101218.612499-1-michael.wei.hong.sit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Nov 2022 18:12:18 +0800 Michael Sit Wei Hong wrote: > Current driver code will read device tree node information, > and set default values if there is no info provided. > > This is not done in non-OF devices leading to SGMII fifo depths being > set to the smallest size. > > This patch sets the value to the default value of the PHY as stated in the > PHY datasheet. We need a Fixes tag, which commit should have contained this code?