Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <115c2f0d-3adb-cbf4-9047-32eb0b461341@intel.com>
Date:   Tue, 8 Nov 2022 17:57:58 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 02/14] platform/x86/intel/ifs: return a more
 appropriate Error code
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-3-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-3-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3ozd0E1VVZUb3RHRHpPYnNYMklPaDhkU1ltbEJKU0RTbmt5Q2NRMEVQUUxs?=
 =?utf-8?B?a1pOTXB1STFPN0lwb2RKcmJQdzA3RjRWV3RaSU5od05rUE1IN2JnVnh3TlNF?=
 =?utf-8?B?eGZOWTZFcnBVSkpwa283MVFPYmxVeW53cUtHK0FHYisxalVXVlZLdVlhQnUy?=
 =?utf-8?B?ZGw4aExTQU0yQnpkMGxFSEZEQkhucGZOMW1jYjBaaEJrMTl0UzJyU0todExU?=
 =?utf-8?B?K1djVlBjOTJxNnVkelNWZGlIdGNCN0hrV0pwMnYzUllJbzlNRzFuc0tCM0Vv?=
 =?utf-8?B?MHB0Um5EOWJ5S013S2YybExiejYvNlpYckZUOWJLWXZoREl3Ymo1OTRHRm0x?=
 =?utf-8?B?ek9QUHpyMHFxc3ZteWExVHdRR0xCSHN5SlhkaVNhZEMwWXRFbFlQTjc3Q3M0?=
 =?utf-8?B?R1VXTDRIRVpDVlRLQk9kbU5ablBEaHpycmo1ODU1N0g1cGlQenM2WStKa3pY?=
 =?utf-8?B?dzRZekNnMyt3bWdUS1FxcTRxM1k4aVFVaUJZSVFVbE5vd0s4WC93NXZwa2JK?=
 =?utf-8?B?N251WVNZVEgwME1ocXVyUEMySGM3TXBTREdOdy9RMTNWTGtrTU9xSVZLZG1h?=
 =?utf-8?B?UzErNjhFTmVTbEVXM1EraVFlZERvdWtPcUJVQy9sRnM0NzF1MndFY2xnRHZa?=
 =?utf-8?B?OFhMb3EyUkNsZlBjSWVsQkloWGFaTHp3SnV2QlNzT3RzM2pUL2x5NmpnTHoz?=
 =?utf-8?B?elVBZ1p0WnJyYmJYTitUaUVDVjZBeERhL1R0Q0h5bW04NEswZUFXSDVMZmd6?=
 =?utf-8?B?TTBOVmxiaHlNWE5vZWZOanpkSlA4eU5EZVFvVE1VVHFsMmdNck40UjJhT0E2?=
 =?utf-8?B?MzRtM1Q2ZTVTMTB2Vzg4ODg0NzVaK1I3ckcvMVdGSDF0cUdLN2s2NjM5RzFO?=
 =?utf-8?B?ZXZVNkVFcDh5K3cxY3BoalRjMkNOWDdlWU92bzJHSVF1aTJwaHRJTjFNenVZ?=
 =?utf-8?B?M1Jtb2JBUmtjcTFRd014TEJ3SzdwbzNoNjVrZUhUblNhNVpiZW5zTVZ0dXYw?=
 =?utf-8?B?YWFRZU00RFJvZlNGRnlVWmpGZHlITlI0SWF0cUR3d0RtMFgwWllMU0E5MTVh?=
 =?utf-8?B?Nk1wOHRPNlVrbVV3bXp4SEpaWUppSzQwRU1SWDdCbXlYa2ZGUEFROTFZTFZ6?=
 =?utf-8?B?QUtmRFo4OFFHWnRSWXBPcnhsdGlaWVE0amNiRmErZlBJanUxNHJuL2h2VGFl?=
 =?utf-8?B?eG9YRnBEb3VuRERqRHhvbjRUSS9jUXFlRGRDZm83TmI0VU5TWG5SVkViOVZq?=
 =?utf-8?B?SkU3OWF6V0lqcFRvRzNwS045V0RnekQ2U29pd0l5VUthQlYySFNGV09HcjUv?=
 =?utf-8?B?aXU0RXlWNUxoNmFYWGJUemY5MEpIQ1dsdkorUVNvVUZya3NwTWJYTWRXS3U1?=
 =?utf-8?B?QWpJQlpLempvYmRrWm1wMnk0UW1LeFM3YnpjWkVSVTFtQklwdktZbm5NMTJz?=
 =?utf-8?B?NzBObTUwcmQrZUZ3M2tnRE41cmc1eEN0V3o2dDdEcm1ReVRMMmNjbW1XbW4z?=
 =?utf-8?B?T3ZLM1JvZndZbktPQldEcmlHWFc2QTJXNHVUY0pFQkgyaVBRTW0ycTNwVm5U?=
 =?utf-8?B?amxvNC9WTmpsVWJqeEpyWldJZGsrMEhVbUUveVBrU21hdHVTMUw3NURVUXNY?=
 =?utf-8?B?UWlXT01QNjkwYkNFMlpoZEdrd1ZwV005N1FLS1dBdFVRd2ozb2pVRVVDQzNO?=
 =?utf-8?B?R2dxKzVFNVJqaVpPY0t2MXNHRG1CYXlhSG44V1NNYmtuK1hLRHN2bnhEclp0?=
 =?utf-8?B?VzRzZHlxNlprSS8zOUpSa2U2a3ZmWjdBa3YvY1QwaURrMzFPbG1SZUV5c1lt?=
 =?utf-8?B?b1lTRE44dTk3Y0xjYW1SbzlkTzZHR3d1SVJVRGxsU0paeXAwc2hiY2dhVkd3?=
 =?utf-8?B?TllYS2xCYkJYWG5HdGl2WjcySnNtNkpJL2NJYXM2QVhTS1pvTCs3Yk1hbkxY?=
 =?utf-8?B?dGpWN0NHUFFsVkFjZ1k3RXlGSlRSVUFQRzJMVzRBTHM4TEdBTDNWd2w3MlNF?=
 =?utf-8?B?eEU0bkkvVzVtT0pGZHo5M25rVm91TC9CQlZUR2VNbHJOTGl1cU1LYVBFcStv?=
 =?utf-8?B?VVR2dm9VMjJlZHZ3RzdRZUpsMjJTRnBvU0VGWW02bmhUUmdQZC93MDJHQ1hF?=
 =?utf-8?B?NFNVdmhPTCtHSldPUXZlajMxelduYktNREpTTnpxU0VhYklGa296c1dYNWk4?=
 =?utf-8?B?ZGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ed9d9f9-e42b-4b25-8959-08dac1f5d512
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3322.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 01:58:01.5225
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2P1dGMh2LXiFL2vav8FUWcCo3BJhNlfOtyKrPk/aDvk4I0dgtuoOEdbnHxrWGwDrkW1W1t3ICiS4oFi64G8VzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7335
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

A nit:

s/return/Return

It might be better to just say:

platform/x86/intel/ifs: Return appropriate error code

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> scan_chunks_sanity_check() returns -ENOMEM if it encounters
> an error while copying IFS test image from memory to Secure Memory.
> 
> Return -EIO in this scenario, as it is more appropriate.
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>