Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3a2f83e0-9ce5-ee6b-2b70-a7e94f4b7de7@intel.com>
Date:   Tue, 8 Nov 2022 17:59:07 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 03/14] platform/x86/intel/ifs: Remove image loading
 during init
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-4-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-4-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3JMWUIyU3dUalVnUTNYWWdaL1BacWgxTFZrcnU4YmtWZmMwVTJMQ2YrRHVm?=
 =?utf-8?B?Q2J1NUlwWmkveHpMNk51UFhZbzc0MkJERDdZWTE2Wi9YTDVYa0g0ZWRTZkJM?=
 =?utf-8?B?NWo2aGd4UzdNaGV3cHNVNXo4SS9oRVBZTHlhUGJCbEJ5Y0xYZHJyTDJ2Sjhj?=
 =?utf-8?B?TUZwdTd2Q1Rha21ia0JxYk40ellaTllaL3JETG9CVmdMSkZqV2Vzb1FyZmFK?=
 =?utf-8?B?UFJHbHdRa21EYmhiVnQycUVTNUYvekh6bVZ6TjBCUU1GUDNZS0hVeWhBdm1k?=
 =?utf-8?B?QTNzalduVjcwWUhseVB3TFprRk1xRGpsUWtuc0JkWWlqSkkvZlo2MGtNNmlx?=
 =?utf-8?B?a1RNREtGK09hOHovS3pib2VENDFCVTlSYUpZcHErN0R6SDBqNDFqQ3M4NUVx?=
 =?utf-8?B?dU5hV1RycnViNkFiYnlDUFcya25FVEhrUU1JYmhjUkNmRS9UaVkrQ09VZzVn?=
 =?utf-8?B?cGFTM1VSNDJBeVVadmE3S1Z6VUpPYTVZQ2t1WXJKYS80bG9oZ2sxUzY3Ykh6?=
 =?utf-8?B?NVJLRm52QWJGYTJtTFZzSG1nWkRuYTBOTVVyR1V3U3VFdFpEeXpFSmhidGpZ?=
 =?utf-8?B?b1FZcSs0RjFHbVN5VzhtSEhzT1U3VFVpVzNYY0l3LzFOUGtSRWZGYnZXVnVQ?=
 =?utf-8?B?VDRBUDdxcUhheGQ3UXV5akxGb09adW9KZUVoV3RFQ1NqMWhKZ2Y5K2pRdjVD?=
 =?utf-8?B?VjZSbDkvSWhUMWxKU203UEpmTHJ4d3p6SGhZSWJoeDZGWUJJeXBQUmVBcytU?=
 =?utf-8?B?N094cEEwaEtVWGkzOGVmaVluWmplMERWOXV5N0k5WFFROHlGSThqUzZOWFpn?=
 =?utf-8?B?ZnVnVFNia241K1JsKzd5RWtDT0djK3pkVk1qQ3JUS1lDU2E3ZVo5TnJ0Q01w?=
 =?utf-8?B?N2dUWENCb0U5RExxYllZcUZHcEoreXRINkRmTzZNYlZLOTRHa0QxSlVOOEdl?=
 =?utf-8?B?NUU3SmJZWmMrcmdUQ3Q5YWJyOVlWd1p0YTRXR21JcVBpdzBiOVRuL3RqOGdX?=
 =?utf-8?B?bGQ5YmpqSFVtQ2NmM2R0Q3RuUGZGQVBNaExSVHZzTjEwTlRDYi9ySE1HM2Na?=
 =?utf-8?B?NmFHS1ozMnJXQ3BNWXk4TmdPYXhxL2JmZ1E3V3BnQk4wWGYxVzk4TEE5VVVz?=
 =?utf-8?B?a2hEUG5ya1JiRFVTRW8ybS9vNUFSek5VdEFmQlU4R3FUV29jUjVsejVpUmJi?=
 =?utf-8?B?SkJpUjI5aDFGS3NmRGtMRkJWc2s5UDJxQ3JnbWtJd3NuQWFIckFzMUMzcGZK?=
 =?utf-8?B?d0IxUHVsRWVwTnR6ZUkvWjU0cXZwb0Qwd3dHWjhhY3VsTzB5M1VyeDlDcmph?=
 =?utf-8?B?UG10SUhXeGZ2NXRoUWhENVVvS2RCL082eUN1SnN6NWx2YW54ZysyaS9ZNFpT?=
 =?utf-8?B?L1ErNG5IN0dHSkxLZW00WlE2ZFRTMEhkb3V4VlBlamJxNnBtSkRlVHNMZWlH?=
 =?utf-8?B?dWV3OVRzU3J3cml2eFgvdzZ3MW9VVFkzZ3pXWGR2ejZSa2FsUFpwMStYU00w?=
 =?utf-8?B?TkxGRmMzVHEvakJwUDJCZTdWemNtMlhXYWpiQTlxbTZtT0o1dUtMSE1VbmJr?=
 =?utf-8?B?VXFkZFF5dHpkYVdwUitQWjRhU09zTEM0Ykt5dEx3bndqV1U0bktRZG90bE4y?=
 =?utf-8?B?YTJVUmZ0d2hxelBvakR2b2ZWOUxUU2dtTmVGT05VN2k1MDd4cG5vQTFXbHRm?=
 =?utf-8?B?dGp0Mlg2WGJuRHpqTFJxSlZkdWcwSSt1bmtrN05uc1ZseGZyWWlZeXJkYmVJ?=
 =?utf-8?B?RkNyYXNXZlc0SFg1cVBsald5bWU0dDdXWHJXTDZncTg3RnRXWTRhZDdOalE2?=
 =?utf-8?B?RWwwWk91MmRiRi9tcUkvYllSZjBjVHVYVlF1SGhaMHZpWFh0N051UzgvaEJL?=
 =?utf-8?B?TGdMeGp6ME1aTGFsdStDUnhodzkvVk5PY2V3UHRJNk01aEZ4bVV2K1krSnAr?=
 =?utf-8?B?SUN3ZHl4Q0c5dDJnNENEU2xUYzVrcmltZTJ6MUZCbTRKeTlBUzREV2JydFVG?=
 =?utf-8?B?N1dWSlN4TmNTSHhmZERrTWFSK1NyTXNWZGwySHN4SnBoeFhuYVdwUm14YkF2?=
 =?utf-8?B?NHlXWEQ1ME5SLzFWOHJ1WmUzbG1NazZJcUo0cUFyQno1MlBpVTd2RWZTdklr?=
 =?utf-8?Q?7IRiT2TRL+u4hyS6Jxps/veCv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f58b7ac-8395-4a2c-e68b-08dac1f5fdcb
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3322.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 01:59:09.7368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yz5ZvDim+fZNgWDDamVTjjxP0K2g4tcrKIb3I5AVh4NqB/cNI7Evca0rXotee94RTD7vVgKXKnK4Q2dGkBDh3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7335
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> IFS test image is unnecessarily loaded during driver initialization.
> Drop image loading during ifs_init() and improve module load time.
> With this change, user has to load one when starting the tests.
> 
> As a consequence, make ifs_sem static as it is only used within sysfs.c
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>