Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <167af652-b36d-e06e-b6ad-f89ee30385b4@intel.com>
Date:   Tue, 8 Nov 2022 18:06:30 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 04/14] x86/microcode/intel: Expose
 find_matching_signature() for IFS
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-5-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-5-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MS9Zcm5JRGdaMHFGbDBOYUFQWVJ0YmpXbzB4RW5zZnFWSmpWejRybTAxeC9G?=
 =?utf-8?B?TmhwUmIyZDhiOHlOMmxQQ1M5VnRqRjdmQSs5d3JKSjFldjhyUHcxMzcrRGZQ?=
 =?utf-8?B?K2xTakV1aVJSMWwxY05yRmVWN3o3bU1CRHZhSm9HOEZDYjNObS9HVTdiOEs2?=
 =?utf-8?B?QURRdXgwQnBMRi9hVG5CSzU3M3UwRW00UHdwN0RKajVrL0F1dlJVenYwUmZr?=
 =?utf-8?B?N3I4Z0JHVkNDbzlFVHAwTVRuTmQzR2FNRFk0eHhSWTc1c2l0VnZrUkZjZU5I?=
 =?utf-8?B?d2dUcWRaYzdwcmNPM2hxa0l5ZVQxUDV0WUVjR0RoSkVPMVNmR2MvdTUvZHVR?=
 =?utf-8?B?c1k2ak50b1VkOC9IWmZOZjlzTmJxci9FbnlodmhLTG1uNGNnakdJR2xPYzMr?=
 =?utf-8?B?b0J5RG5ZZXppWnFGOGlvaEcwcVFWeFJzdGhJZzFLQytzVkkyYnE3Sms4NVdS?=
 =?utf-8?B?MndyMVdsRTdBWEFvRlN0b29sYi9RclBBOUE4RDd4aVRIM1U0d0xaVEcxaGpQ?=
 =?utf-8?B?cVFFRFljUmh2T0RwZHVkbXgzNThaNnlhN1FDY3h0c3lrOGFzdWRnaWh1TVNl?=
 =?utf-8?B?ZWhvdTlRYUJPYkIrLzJES1V2bjUrRExuNUdYMG1QdFlObm9EY0hZSUNCY1Qy?=
 =?utf-8?B?M2RNZ2FmL2VFSW9oWENDcjB2UGlWQm1ZYUt4ZWZOK3pOZWpPY0lQeklyRmRL?=
 =?utf-8?B?eEd3SFpIL3REVEUvU3J1MkcxODlkWjgrQmZ4dEVlQkZhYkMyL0pvdHkyR1ht?=
 =?utf-8?B?VU1pL2xBbHpaMHBDZjRZSHJrbDB1ck1FU01vQUk4TXhhUktzU211c1BHQnJL?=
 =?utf-8?B?Tndmamt4VmU2V05rNjVaeUxyd2U3K2VOQnd3UUhNd2YxaGtJc2swdWRCdHd1?=
 =?utf-8?B?ZmpmaGxTdHNpK0RRcGtpaXZPVlJaS1hUUnR2L1Y3L1liODNyWHhWeXlYdnQy?=
 =?utf-8?B?dTNBeHk2YnBFY2Eyc2pSVCtJZTVpRUd2NjhvUXlYK3kvN0g0S0FCOFFxNlZU?=
 =?utf-8?B?UEVUSXl3bnBjVXpOZUtFU1dtYlB6SEJzeTVUMTU4bXJZUk1RaEFCR0xlZFUw?=
 =?utf-8?B?ZlYvQW9mbjNKV3dRdTBhRmoyeU82NmttdmNiWm9yT3dVVE1tYTlwdDNIdFVJ?=
 =?utf-8?B?MVFUb0ZPSEM3QU93VERnYXFtMTdORWprbXdvd203bzR2L0k4TDVWdWsxWUJt?=
 =?utf-8?B?QVRJMm52V1V3RFRlbnptUDIyNHMrWnJLMERCenRGWFNXWWR5L3ZCK0V3cUFs?=
 =?utf-8?B?bzFpQ3pZdVlXTkdwa1dLbk1RSS9hTS9KVEN5ekZGL1VQYjgremYzMUt0eStz?=
 =?utf-8?B?Z2lOZWJWalZ3Vm5yQXdrZ2s3Zi91TCtRZEY3bWhncGNud0VyT3N6b3JZMksw?=
 =?utf-8?B?N1d6cS9tR0RHYkFRUitEU0xiaFBXSkh4SFU2c3dnYVZldTFlRWdCT3J5N242?=
 =?utf-8?B?S0xBM2p2Tm1kMmhiK1hDV1gxRy9KNG04b2NRNFFoYjVqRkQzbHQvS0ZTT0wx?=
 =?utf-8?B?eFRBODByREFxSjdRUnNLU2Rhb2VlVmVRNUk2d2lLT1BoM2VjUmVxNmtmMkJ6?=
 =?utf-8?B?clZyYmlsV0M1dHVaS3VycG56anRodWRTY09LZUVjOUxBR2JEK2VaZTE3Q2xY?=
 =?utf-8?B?L2poTTMvSVFST3FxclA5Vk5XRWxvL3IzbnVNVEUyNnU0TU9taG5JZThkM2dQ?=
 =?utf-8?B?UWhWK2FJZ1YySTNHeVFuRTlJMjdqbkVLbVIxR0RwM2syaUh3YjRQTnpoeEdF?=
 =?utf-8?B?VkJNTllaSnRCYTQrMkl0UXhHNXBOUUN0bXZ6NzIwalBoNUZRYUtBbFFaRWpI?=
 =?utf-8?B?dTVSTFIwMzFocXg4SWFFays5YjBvN3MxZ3VrYjZiNnNVVFRPZmI2emJERHVC?=
 =?utf-8?B?eGF2aXhQOWc4b2U4bUNXNE1iMVpTRXpjdGR0YkdCcjZrY21VZ2ZKL2pWKzNY?=
 =?utf-8?B?bUtsMHNYWThvbjVnT3hlTEtyK3ZNQWF4WExzVy9UVHZ4ckVmTW1Icm84c2Vi?=
 =?utf-8?B?UEJvN1MwQnRJa3F0TjNka3dYZFBXMndoT1QzVElWODBvbjFKLyt1MXltUTFt?=
 =?utf-8?B?YzR3UlBaeW9QQXRHSVY3bHRnZGI5Y0ZWL3NqK3pMMktGZU83UGxscVlTRy9C?=
 =?utf-8?B?QzU2Um1zK2plT1MrSzNISzUyTjRRSForNDl1U1Z3RnlhN1FrMUx1ZThrNmtq?=
 =?utf-8?B?cmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f8312563-0b23-4525-fdb0-08dac1f706a0
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3322.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 02:06:36.8485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MCzgOXnkYd+Q4BO1yzFthQCy3FPhQ4R3InadeU+IGw2ZMmyAsh0j3MWRzh4S8KZLK39bJpPFVz76VFx3Zj7tHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4920
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> IFS uses 'scan test images' provided by Intel that can be regarded as
> firmware. IFS test image carries microcode header with extended signature
> table.
> 
> Expose find_matching_signature() for verifying if the test image
> header or the extended signature table indicate whether an IFS test image
> is fit to run on a system. Move the function to cpu/intel.c and
> add intel_ prefix to the function name.
> 
> No functional change
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>