Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <445aea20-5626-6d95-db90-ff086283272a@intel.com>
Date:   Tue, 8 Nov 2022 19:06:42 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 07/14] x86/microcode/intel: Use a reserved field for
 metasize
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-8-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-8-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3NFRXljWjRPR2FWNWVpM3lhc2lXdVNVN2RoZnY4d09pNnRvSlFSSW9jZHRp?=
 =?utf-8?B?b0dPSmg5eUh6L2RSdUNPN3E4SHJlQWdmakI5SFNzbXNOZTFrbGJvd3hvK0ta?=
 =?utf-8?B?ZDJlck0yQVJDNUI4d0w4WncrR2VjWXowRXpJelBMak1CTFg0TERBVUFxQXNU?=
 =?utf-8?B?OVk4NFczeUlzYUptZFBIQVZodVBzM21HNFFSMkpPa2VxTVhQSHBkenNNQkVp?=
 =?utf-8?B?RkJZZjE1L0YrK2xvVFJjUnBZSWlYR2NIY3Z0V3JTc1Q0SnM5eWhpZTc0dEx0?=
 =?utf-8?B?RE5XUHJnNkRWUUhHeGkzWFdISW5vaXdIRTBCZ2FETmxveW5hNFJJanhOcDUv?=
 =?utf-8?B?L1NhSXRTdGtxTW5mWnl0b3lHSWFBMTJ2SG5XWlcranBjWFVrK2dwOXhtakQ5?=
 =?utf-8?B?dHRhVW9VNkhBS0MxODRtTi9HZkdNbTNXVmtoTnBDMmM2YmlBNTBSK05ESFBQ?=
 =?utf-8?B?SmZXK3JSelBLWEZFT3Fhc0Y0RmxzRUFhK0o5Rm5KdEUxQmgrLzdWMVJhNnMy?=
 =?utf-8?B?Unp0QVZVSnhSNCs1Y0h2RVIrTWsyai9NRDJ2ZHdHV0cvU0ZyRHRiMXVsM1V2?=
 =?utf-8?B?M3gxOXVWQXRtWUdmeklHcXZtelJZaWFTNnMvMEFia2FqeEppNEU2Y2twRFAz?=
 =?utf-8?B?aEw2UzFFVjFPUEo1Z2QraDZQMDZuRnNHWVdrRkIxNDFENWF6K3gxb0J4amMy?=
 =?utf-8?B?UVZNYnM3d3FQOUpCUC8zNFgzUXY3VXdQSnRQY1kzYmVhUXdMcWhGclluN3ZK?=
 =?utf-8?B?U3QzQkkwOXczaTkveUdPcFFXeDlmL3UyZmJiOS9EVlhTUmJKbStuWmdVSys3?=
 =?utf-8?B?SmxGdExuMytsRThBZlRxcG5XTFNqakFBQWgzaW01REdXVUR3WUliM0FtaS96?=
 =?utf-8?B?TWpmWEc2cmIzYzExMnhuODJpWVJsTWhHb0I5ZXROUEw1d2E3bTZZNm5Gb0pz?=
 =?utf-8?B?YVh6bXlJL1hEUHN5WkRJbFdRN2xsQmJhbTRiQUJka3R4alA4YW5IZ1pzZUxo?=
 =?utf-8?B?KzgxUHkydHdETTF4OG81L25majYybVdLK25SZ1R2ZFYvZnM5OHBxMjZaakNt?=
 =?utf-8?B?aWtEUFhiSXR4L0FIbHREcWtaRHBpZDBhZE5Md0Z5Tytjb2ZaQ1hIZllOVlJh?=
 =?utf-8?B?QjQ1RWZMa2NNUTJDYUZjR2RSb3NicU9INjkvREFweHBEaExQamhSbjVJL2NC?=
 =?utf-8?B?ekJ1SFg5alV4bG0ySUk4TUFPbkxKMm5zaXpSQnZ5V0FXenVyK01RK1hsTytz?=
 =?utf-8?B?aE1HbGtaYmZjVFpaNlVVZnpyTElXbXNuejBlYkx2dDUrVExHRllKM2RBdS8z?=
 =?utf-8?B?SHVJZEZOUmZzeVJvVVRTYUYwZDd0SlMrcE9JdTRUemtvREd5Q3p2bDlOb2I2?=
 =?utf-8?B?YysrNVpqNkJhTkRQcEZNLzZ0TmpMdm9GZTRFMWFvOUV2SVNDbytoNlpGU2RP?=
 =?utf-8?B?a3JGU1U1RFdLQ1Vkc0w2YXZFQWtSSzRvYmNUZEoxM0JWejFiMTBlTGxNV3Jv?=
 =?utf-8?B?ZnB3djJDNTRBbi9nTHlKQmVWV3NQd01ZRjRWcW5Xek9MZmhDd2FOOGNtdmpa?=
 =?utf-8?B?U0F4R2dBRldOaElFMitRbTdjamJpcE5MMkxyRmhOVGVuZWZoOGNLUThFQ2E3?=
 =?utf-8?B?VFEzUklzQmJHakIzQkRtT0RzRUtGZmlZeXpONi9VYlVPZ2NjRXVISWg2RE82?=
 =?utf-8?B?TEgzVldQeFRIcWVKMEgySTU4dGdaajB3aDliTHJ3ZjNmOXo5dTJUbFVERkpt?=
 =?utf-8?B?TzZuRlcweERCRUF1eGczWW4razcwRUlGdEZjVXIvSEFaeHlsWG94c29jOFI2?=
 =?utf-8?B?R2ZDc2Q0T21xWHVKOXlYNHNiUHgxWlZEbS9OLzJSZkM5VXNIYkkyWlNUNFJR?=
 =?utf-8?B?aHdyVi9xYUJoaE9rNGc3a2ZPVWJyeUdjVVRwbENva3ZNYmNkdFg4VnUvVDBy?=
 =?utf-8?B?enJFaUVXWnRhb3dhUGgyUTdhSEdzZ2pFTTdXejZYNWE5M0RiRGVZSkx3MG5P?=
 =?utf-8?B?WFNZdnlCT1loVkZ6T2dQajhvUFpnNXc3ZmF6L0dueThSSU1ueHplREdYSDcv?=
 =?utf-8?B?MVJ1TnRVU0RTbmswb242WEZuc1lBZzlRVXlBYzUweGJmZkZoWG4xL3JzbkJY?=
 =?utf-8?B?QjBkS3g0b0VmNVZTY2ZQZnNpdlhHS0wxZnBLTUJFT2VtZjl3RlFGa3lYckhH?=
 =?utf-8?B?TXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 345c72f5-e2fc-42e3-f381-08dac1ff6e58
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 03:06:44.6302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uBdwwU78ZQ7uGpPUoabobZ8bHJECyW4GGXCWGS3XqDkkXF/68vCIT3V1s/J3IlwdLOmZqxj+Kco/Ufg9r8coFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5665
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> Intel is using microcode file format for IFS test images too.
> 
> IFS test images use one of the existing reserved fields in microcode
> header to indicate the size of the region in the file allocated for
> metadata structures.
> 
> In prepration for this, rename first of the existing reserved fields
> in microcode header to metasize. In subsequent patches IFS specific

Nit:
s/In subsequent patches/Upcoming

> code will make use of this field while parsing IFS images.
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>