Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <86c46504-f769-1187-2aba-5b8b58654b33@intel.com>
Date:   Tue, 8 Nov 2022 19:03:54 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 06/14] x86/microcode/intel: Expose
 microcode_sanity_check()
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-7-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-7-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVRCUU1NeWZBbEQ2eENvZU05VWpHaEZGOUNzTGh2Z3JhbHZSQ1A2VHphRW8z?=
 =?utf-8?B?UFQzRzdnMDY3T3NhNm9LTkc0M3E3RjdWNUhlMzM4cEpVdUM2OGwvb2F0MUVj?=
 =?utf-8?B?ZTBIODdlTjJoYkt2MFhIM1dTWXF1K0Q4anFHdytoMGlIWWN3MGRLMEQ4dGZ0?=
 =?utf-8?B?SkZZbHJPeTdjQ2dCbW1ocGdHaEp0OThnOFJKL0x6MGhEeTh4elZQZEw1RnVR?=
 =?utf-8?B?Z0N2dGFmRkV6UmxNVTBKNm45ZTJFdkgrZTJKVUJ0RUtYQm9qczFKZzJNNGZq?=
 =?utf-8?B?Sm56UjVLOFR0a0h3RTFSaFdKb3RhWnpodFBJMnU3VlpRRXVCSWVmRFQ1NjlW?=
 =?utf-8?B?Y2FKcVM3OGp6NW5uV1N6ck9UU0JNeW1UK0NyKzRmQ1FBQ3g3UnNTYW9raWhj?=
 =?utf-8?B?NlFBWEdjc0FYWWhPZUxhMjJCMDVuNXB3d0pCNVhRbWpLMEJmUHU1ZGRPdHpD?=
 =?utf-8?B?MlVYdkhsUGVxcFNtcjdONVhJZnZvaUlLT1BiMEZsUXhONWI0TjEyR3cyTHJl?=
 =?utf-8?B?M3V4VHppWUpiMXhBRmt5bE5TOHVFblVIVk9yaDJwOFUyYjRYeG0yaW9OeStG?=
 =?utf-8?B?WU0wczVWUDNqYUFUUEI1TGJPN3Zlei93UmZaY1YrN0I2dVQ0RGZqRHpiZ0dk?=
 =?utf-8?B?UTN3WksveVp4dTVVVFJ0RDlRM2ZJc2o3Um1CSjY0TmNBdDdyK2szOCs4Rjlh?=
 =?utf-8?B?aFA5MElWRngrdU0wQUswZ2pxNENhOXVMa2E1Y1NGLzk5WngzeWVQTG5VWmRH?=
 =?utf-8?B?c28vK1EzQnNTd1M4MG1Sa3FuRFkxeXZyUFpQS3VpNVc1cU90SWlCaDdoYy9J?=
 =?utf-8?B?UFRzb0dXbndXc1VVNmZYNHJic2NtRXJRTHFRSzlvL2ZYOUgwQmF5YXNjRkJy?=
 =?utf-8?B?NSt4T1NtV0JxQVRFMElBNTRSczZ3azQraCtoUUd1bkVUYzB0Z1AxWFNwcWFK?=
 =?utf-8?B?NmI2WEhGR1BTOHIxNjhlZmhUNnVCdUtLc3lwTWJpN01QMFBtNGNPdCtuUnJK?=
 =?utf-8?B?L1c5OU1zcytFbmlsUVh0RVNsZzF5dk1jK2dRNTRDR0dBRWJsTmdIc3gxWXlL?=
 =?utf-8?B?Ui83QklUeTh1UDV3WUFKT09BY21tV2RwbFZWb015d0sxZnd4UUh2RGM3dk91?=
 =?utf-8?B?QXBsbUJ3UGxiYkN3ZnAyckd0aVF2ajJLcGxQbzk1SzVyLytUTXhTQnkrd0R4?=
 =?utf-8?B?bjhHdjVValRCdXQrV3FxK0VNajkzcTR5M1JqTHljYlBXVXgwcXBqZmtxL1V6?=
 =?utf-8?B?V2c1aDNUaU8xREoyaEVoNUhlczlzVTZJSGRsajRiRU8xV01Vd3N0cU5qeFJo?=
 =?utf-8?B?T3lXR1NsSjRSWk9UMjZxSHdkUVN6L0dPRmxkUEFxaCt1SFc3M1E1cWVLTmlv?=
 =?utf-8?B?ZzNuU0dsNHZxSTVGTklwWlFGTFNFSXF4RWk1VVJNUkdvUUhKaVowWkVFTTJM?=
 =?utf-8?B?T0hwemFkb3JvTU1ocmo5M2xoVmR5NUJKWUtwM3VaL3ZTRllXNUtUL3FOK0xI?=
 =?utf-8?B?MWk1dDgwRyszdzdwSStQZW80RXBkMVovM2M2S2xkdGsvNjBoWVUrOVVxNVZK?=
 =?utf-8?B?dFJicGhaZTg2ekxHUW5JYTFvbEJuSkx2cWdGTWhsU0hVUWZvN0ZLZnUzMWZo?=
 =?utf-8?B?SWpFQ3JlVkhzMnpSZEFmQk04bTBybmlrU011NWMvb1p0a0YwMWh6MlYxb1N1?=
 =?utf-8?B?bEhodXJwRXBRNjJEWDNveWNOUi91OEcvSk1GYm5yWThqbkZkRjNmM1J1Y2la?=
 =?utf-8?B?VEUxRXdLUkMzVkt3MnNpQ1kzdW9GR1Z6SHI0SWMzcnJiNUFodFdKaHVsVUsz?=
 =?utf-8?B?SDVuUUFTNnJVaWNUTHh4SmhLYWtIdCs0dnRRWFhBcWdHMWd6YWhIMWhYUnVv?=
 =?utf-8?B?ZE9vS21yV2g5WDNZR0p1OVhna2Z3S1p6SE53OFZ1YjJsemM3UjdVU3dZZG04?=
 =?utf-8?B?aVZDWTJITGdCTlB6cklEazN5UUVpWVprUEs0OWVsYUZPM3pHWWplK1hVU0lD?=
 =?utf-8?B?amtOUVpIZDNoTUVEa3ZDUlVwRDgyNGVFRmpKbDJhYkduZHVGUmlMclloR3ZP?=
 =?utf-8?B?VTRYaHlFa3A5R0lDb01BdWROSTRvd2RvZkMxaW5wd2RGdlVZSmRnUWg0Y0Y4?=
 =?utf-8?B?SjhuSUQwblcrTDBmMHNhMmFyaVRDeXZlbWVuNVBoNjF2dzhRdHYyRnVPRmk5?=
 =?utf-8?B?SHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a706645-632f-489f-7502-08dac1ff0a84
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 03:03:56.9401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ezoXdG8qTPo/L1QANnmQmfjnRTDu5pRvh/PJ0FpxPPWil70EWjSizJSVk9V6paJzNlKolicOffPQoahrBZgGTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5665
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> IFS test image carries the same microcode header as regular Intel
> microcode blobs. Microcode blobs  use header version of 1,
> whereas IFS test images will use header version of 2.
> 
> microcode_sanity_check() can be used by IFS driver to perform
> sanity check of the IFS test images too.
> 
> Refactor header version as a parameter, move it to cpu/intel.c
> and expose this function. Qualify the function name with intel.
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

...

> +	if (data_size + MC_HEADER_SIZE > total_size) {
> +		if (print_err)
> +			pr_err("Error: invalid/unknown microcode update format.\n");
> +		return -EINVAL;
> +	}
> +

The wording for the "bad file size" print seems to have changed during 
the move. Any specific reason for this?

> -	if (data_size + MC_HEADER_SIZE > total_size) {
> -		if (print_err)
> -			pr_err("Error: bad microcode data file size.\n");
> -		return -EINVAL;
> -	}
> -

Other than that,

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>