Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <501caac0-57f1-7db2-b030-b6d4f13ab3ca@intel.com>
Date:   Tue, 8 Nov 2022 19:29:58 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v2 06/14] x86/microcode/intel: Expose
 microcode_sanity_check()
Content-Language: en-US
To:     Sohil Mehta <sohil.mehta@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-7-jithu.joseph@intel.com>
 <86c46504-f769-1187-2aba-5b8b58654b33@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <86c46504-f769-1187-2aba-5b8b58654b33@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekRITGNidG0yVGF2YWNzTG5EaWg4WnV6cUpwYUc5TzBoVkJCMi9ra2hYOGtN?=
 =?utf-8?B?ZGdpcVR6QTVZU3dvTi8xb0JkSmNRbUxqMEc1ZEpISk5ERlNRbThhU0RPT3NM?=
 =?utf-8?B?cnpYMUxIb1dNZzIyUnpqekVnbWRuREZGa0N5M05IQWNqTjNRZGViYUs1M2N0?=
 =?utf-8?B?eTdVTjhuanpnUWEvemp0Y3hqVHEwNlZLYXNHWlNvQjBDK3dtZnl3WEllS3dL?=
 =?utf-8?B?L3R2MjlnaUVPeEQwZ2pqZ01CSWR2cE5KSkh1ZTZSWlVhTys1SzRBbTc5dk1J?=
 =?utf-8?B?bEttV25vb0d6S25zdFhuL2xLaitnSnhWQVczd1YwbWxieE1MOEpMb2x5RUNk?=
 =?utf-8?B?RVNPeVUxdlRJUXYrYlJtTitLRzhpV2NlbllEZWtCUHlySmVIdVVSWlEwcEpP?=
 =?utf-8?B?TWxUR3FsVk0weGxGMTJDcXRSY2p2SElrN1ZIVXZPVWRDVzJLQ1VSNGI1SU1u?=
 =?utf-8?B?YUhhYkJMMC8vdk1rSGpSSTAxSUxHaXZSbHNrQjFzclROc1ZsRkI2dG5KSVov?=
 =?utf-8?B?VHoyeFZseEM1dWNxVVBHbzY2Z3pvNGlERS9wNktvVXY0ZjZ1VUtEOXFxSW5z?=
 =?utf-8?B?R1FXMllQVzR5c3BEZDE0WFhYZVlmTFdIb1VZU0V5QnVjNDZlMjZMTDBML05o?=
 =?utf-8?B?K0tpcWNZZVJKUzhuTCtJeVdFcWlWbnZUOS9GejllNXR6MjgzMzE0SWVhT2l4?=
 =?utf-8?B?M2ZIdHNMbXg1eHJDS0tFdWZsNEFjZDhDb3RKQW9GWjJmZHJFeDljTjZNMld1?=
 =?utf-8?B?M01OK2lyRGMvVUhQOUVIZEFycVVkREN3TEhKdzVyZUxXOFNrQmJHQ3AvVHZx?=
 =?utf-8?B?MXRORU1PNWVuOFh3aW1tZTE5NlZvVDZTSW9SNjYvSm5PRVpZWDJBR0RNNTh2?=
 =?utf-8?B?YkJzVWJ1Qkt4dnJ4cGE3bm1EYzdHUlJhdjZmU25sRFlWVjFZSDNZWXdvY1NM?=
 =?utf-8?B?em81YXFpRHJ5RVFtZ1FxOTlqZHRrbi9oOWtONEVPbE9IdUI0Ynl5YkNnUS9t?=
 =?utf-8?B?NWJiekh2eEN5dEVkeHliZ0owcGZ2VjlORWFDSzd1ZXZqUXFpS0lqRzJOQUJu?=
 =?utf-8?B?SEV3UTVNT0g2VHlqaERsYkltTFZ5a1FYTjljWUw1aUtnS21GdGQyejBISVJm?=
 =?utf-8?B?L1VJSWVUTmplbnRES1JDTzgvaitxbGdnZ2YxVGJueVdRejNSSWhQQTBuWXly?=
 =?utf-8?B?VWFXRVVjM3JTY1dMVkVjWkV2cUg1aUVsMno1cG5mbVdlWjAxK3o4cEc2d2E5?=
 =?utf-8?B?ZTJmdjhCNXNSNlpvZnhNZHc2NGxtMGNsaXRoL1hTOFVUVi9yVzJVWFpKTFRy?=
 =?utf-8?B?S2R1Vk9iWFBLbUtSUnZaSU9qMms0Q1Y5Tkh0akFvUkgvVmNOSXhvUkNpQjZp?=
 =?utf-8?B?a25WNVR2U1F5WDdoa1A0MTdZUHI3UEJaSXQxN3NmMUc0bVcyZEt3eVB5akVk?=
 =?utf-8?B?aHVQcWJUV2hWUjNZdk9aMXh1WmpIQnJ6clV5cnZFbXAxRUtnamFDZDN2ekNJ?=
 =?utf-8?B?eEc1MmF2WnQxZGxNaU9nRjA3eWZlQlBKVUxJRS9xcUhUQ2E2NUtlQTc0WFZP?=
 =?utf-8?B?U0tCcUhsRzd0TFQ0bDZLUHlmY1k5QmlnUE9Ec3p5TFFaRUp2S1VCRWdzS0Rj?=
 =?utf-8?B?dWtBTStnSjlYTmcvQ2FTRTRiS1dURW5YSlo2TDk1dHpXc2t6aXY2RlhTQ2tH?=
 =?utf-8?B?R2FZL3lvN0F6TkhXc25vc2d4Rk1LMjhGamdyY3JIdlJWdVY0elAwMWpLZldi?=
 =?utf-8?B?NFFUMVJpdWUxdCtONkR3ejYrRDBldllnWkI1UXo5Mk93NStMaWU2V0tQekN4?=
 =?utf-8?B?eDhKamhjOHB4dm5Qak4wd0o4QStEY2dLSkZwcVVqT0xteTNLaEFxeG1ibzkv?=
 =?utf-8?B?ekZRbnlMdTRBZ0owazJ1TVpxT0d1KzUrWlQrek9ueW02cjlmMEs1NS9zekdK?=
 =?utf-8?B?K1RZekg1a2R1enhka2V1NWtwanJoVkpNQTkrZ1EwaEl3RDBGdVowZk4rRE9s?=
 =?utf-8?B?ZWU1aE10eHBuRU5BL0hLMnM4ak5kdEZRWERBZ1YzY25XYkd0Z2dOREYrc2Qv?=
 =?utf-8?B?bmxLb2RTVGN4Q0VQN3RjN2pDZTJOaFN2K092eEVFY2NhTTlOVFZreGlUMzhs?=
 =?utf-8?B?M2dUUzEyTXdzK3lLa1puNVM2QzliUFVKUFQ5ZHJ0TWVCUXNLMC9CWEo4TCtF?=
 =?utf-8?B?aWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dbe8d697-615c-4ea2-1a0e-08dac202af75
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 03:30:01.7006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AHFMaIU56jdDFecEeYPbYGHj7fKlsT46rzVNF6GEFs+Z++sM5Rd3YFclm4tTA23Gm/CoJr9/sVlEGP1DBoWvNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4594
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/8/2022 7:03 PM, Sohil Mehta wrote:
> On 11/7/2022 2:53 PM, Jithu Joseph wrote:
>> IFS test image carries the same microcode header as regular Intel
>> microcode blobs. Microcode blobs  use header version of 1,
>> whereas IFS test images will use header version of 2.
>>
>> microcode_sanity_check() can be used by IFS driver to perform
>> sanity check of the IFS test images too.
>>
>> Refactor header version as a parameter, move it to cpu/intel.c
>> and expose this function. Qualify the function name with intel.
>>
>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
> 
> ...
> 
>> +    if (data_size + MC_HEADER_SIZE > total_size) {
>> +        if (print_err)
>> +            pr_err("Error: invalid/unknown microcode update format.\n");
>> +        return -EINVAL;
>> +    }
>> +
> 
> The wording for the "bad file size" print seems to have changed during the move. Any specific reason for this?

Thanks again Sohil for reviewing.
Only the next print, associated with the version check was meant to be modified. 
Looks like I mistakenly updated the one above also.
I will await all comments and correct this in the next revision.

> 
>> -    if (data_size + MC_HEADER_SIZE > total_size) {
>> -        if (print_err)
>> -            pr_err("Error: bad microcode data file size.\n");
>> -        return -EINVAL;
>> -    }
>> -
> 
> Other than that,
> 
> Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

Jithu