Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1af04fc9-3207-d9aa-4464-cdb14b983997@intel.com>
Date:   Tue, 8 Nov 2022 19:29:56 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v2 09/14] platform/x86/intel/ifs: Use generic microcode
 headers and functions
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221107225323.2733518-1-jithu.joseph@intel.com>
 <20221107225323.2733518-10-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221107225323.2733518-10-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGZhMHhuTzRjTW40a3VQb0txUHFsL3FnakQ3aGd4dytnTVFxYkpyZTU5R21M?=
 =?utf-8?B?QWhiK011UndGdXkwS2xnZFdRR09lYWtlN1ZXa2sraVdjc2ExN0U2TkZWK0pI?=
 =?utf-8?B?NCtSZWY1aFlCbi9WeGozUjltdXVkZllrZzQ5WVhtZFRQbC9sMmdzaDVJMHhM?=
 =?utf-8?B?eVFHTUcwRmk0Wm5KQlhlMUtGU3BaRHVreVFGbmhJUU5Yc0NBNStKMjJ5WjRQ?=
 =?utf-8?B?QmNYZFB3TldSU25Hbi9TWXlMUHR5MmZEMXFacUVwSFhPVElXaEczR2lXbGhC?=
 =?utf-8?B?NGNPbjFaZmprY0RKN29QQm8vcGx5M0VmYjd2VFZ5b21TSUx6amw5M0N1TEVp?=
 =?utf-8?B?WitPL3ptZThBZjVNS0ZkNGJnV21keDAyeFh0Ly9vU2JvVGl0QUUvN0lkWElk?=
 =?utf-8?B?ZWNqbks3SUFybHZSUzJwQ3Z3NDdvaThqY09nZVhGQTAvNUR3azNneGIzd0cw?=
 =?utf-8?B?K2lKbVlSWFBFc2xnRHVFSmxsRFZ2MWNaSWZ0MGhRakFzeWFZRkdZclRiVVNM?=
 =?utf-8?B?aFhtNjM0R1hPY2ZkcHl2c1JwelJsTy9TQjVIQkFoYTgzZUtXazArMnNMNnBN?=
 =?utf-8?B?R3lYeXZJR2VNd3BIWCt4QTdxS0I0Ym1YalhObTRwSWRkUFV1Ti9wRUVqamRv?=
 =?utf-8?B?MG1SUSttb0J1NVNtb3l3ckV0Tm90OFplU3g2VFp5OVZzVXpPaEVnTVdLV01V?=
 =?utf-8?B?STQ1dUF5UVJKWmVGTGxLTnZjdXBkL0JLQUd4ejZDL1JzYTlJdVVncFZjd2pI?=
 =?utf-8?B?Mk5Mc2psS3ZsdTV4U2lML0NCMXJzSGVEdGd5alg0K3VoSWo2Nm1tbC9HbWo2?=
 =?utf-8?B?RCs4V2swWTNUSTRBQnMrRC94LzZseFhwOHVDOTYxb0FCblNPNW1VbGNtTHBz?=
 =?utf-8?B?V0wvSFZ1SVZQUEtBUHc3Mkl5NHVtZnRvZEVkdDB6TGJrRWMwbFBXUm1SYmt6?=
 =?utf-8?B?THhReDJBczNrMEJhREdqUFVlWlA2SW13bG1mbjBPckNjQ0RPNTVEazVRaXRO?=
 =?utf-8?B?elUrSHR4NW5xSEpicEJrMkdTK0RJYzkybkk0a1d4SGllVEJwSkRUMWxHTDJM?=
 =?utf-8?B?VTFxOEYvZVBpeDY2THdLMG5BSTFzUmp4ZnRXd2t5QWY2R3c2ZFV4empycEhl?=
 =?utf-8?B?dlpRb2pRektEOHVrQlB4alRQMElzQkNRaHpGS3RJbjBiVVFCSTQyNGpYNlVG?=
 =?utf-8?B?aWlMTm9SSTl0TWxIRTB0c0VUcmY3YUZocDhZUU1BR1IvcWx2NEIvZE9QUjJo?=
 =?utf-8?B?QzlwYWdUYVVieFlHcUlOVHQ5ck42VTg0WmlMbk5iVC90RmhRN3FaVVZPSmFh?=
 =?utf-8?B?emowVGk1UWFwbU1IalVrbVpXZ0kvUkoxOEhkMG8wRFVXTjNhY3R4TlRiU29y?=
 =?utf-8?B?SkFSZTVJRnpic0Z5NWNPS09URldndkJJb1ZJZm1jMXBCMjV6Mkk4WlhVaTcv?=
 =?utf-8?B?YWFaSld6US83R3lKZ2QwclV3NTg4Z2Fqc212a3RmSk9oeUpjeWcxcW5xYTY0?=
 =?utf-8?B?M2MyM2tleGdLV05DR1VLbnIwdVh5ZHY0RnpIdlF5NzVOdkMxRzh4ODBXR1pJ?=
 =?utf-8?B?VXZBZEVQY0NjNi9CR1BmQjRwL2tEQ0JUekxJN0N4WGYzdm43TnlnMmQwanhv?=
 =?utf-8?B?dHMyUStpTi9NS1NYQ0NPeHdCeElaMjRzTUdCa2hpY0ZZRlc3Nzk5Slk5MG1C?=
 =?utf-8?B?QytPOVcwRnQyNkwxWEVPVm1uemtudnlBUW9LT2t4T3lFSWU5S1IwNlYrZFFB?=
 =?utf-8?B?cU8wVGwxS3lRYU9KZW04Q3VtTW5PdmErNklvV004NnhxTkNTdnhSamI2ZmRG?=
 =?utf-8?B?S1NXK3BXZDd0M1JUZUdac2t3L1FCSUlRM3pEUm1STTllbDlvR3NXaFNqemor?=
 =?utf-8?B?UmorOTBtclIweVd6SnVvdzlLaU5weE5hQ3VYcm9HWjdSWldKNHZudzFDbE5Y?=
 =?utf-8?B?cW5qSWxXVG1aSFVTQVVJWkRiRERFdTVYMnJkbnFPelRKdEZ4WTVSU0p5Z0hm?=
 =?utf-8?B?cFR2OXptNTRlTzF5bFJkaCs3clFCaG95VGVtQ0RPRUtVMitsZy92Z2hsVnZT?=
 =?utf-8?B?SlUvOGpCd3R1cTlXMFhUc1VDU1dOVDVndVJYdUJqekhWeGxpNDZCMHVyVmdT?=
 =?utf-8?B?RmJMVlpiaHFnMzlCRTVvb1VtSThham10c2pqdGo4c1dRVXZJczJBSlZiZzVx?=
 =?utf-8?B?S0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 24c12404-8a27-4dd0-0929-08dac202ad15
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 03:29:57.7937
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yww7Gx/Rm08tUT1ddkpA4Sd8lFMhEV90MMlMqTVLhNbOF4FxdyE4UWKwelH1Qo5cDWIrhIMsnT6YInHljKa+Yw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6528
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/7/2022 2:53 PM, Jithu Joseph wrote:
> Existing implementation (broken) of IFS used a header format (for IFS
> test images) which was very similar to microcode format, but didn’t
> accommodate extended signatures. This meant same IFS test image had to
> be duplicated for different steppings and the validation code in the
> driver was only looking at the primary header parameters. Going forward
> IFS test image headers has been tweaked to become fully compatible with
> microcode format.
> 
> Newer IFS test image headers will use  microcode_header_intel->hdrver = 2,
> so as to distinguish it from microcode images and older IFS test images.
> 
> In light of the above, use struct microcode_header_intel directly in
> IFS driver instead of duplicating into a separate ifs_header structure.
> Further use existing microcode_sanity_check() and find_matching_signature()
> directly instead of implementing separate ones within the driver.
> 
> More IFS specific checks will be added subsequently.
> 
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>