Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Aakarsh Jain" <aakarsh.jain@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Cc:     <andrzej.hajda@intel.com>, <mchehab@kernel.org>,
        <hverkuil-cisco@xs4all.nl>, <ezequiel@vanguardiasur.com.ar>,
        <jernej.skrabec@gmail.com>, <benjamin.gaignard@collabora.com>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <stanimir.varbanov@linaro.org>, <dillon.minfei@gmail.com>,
        <david.plowman@raspberrypi.com>, <mark.rutland@arm.com>,
        <robh+dt@kernel.org>, <krzk+dt@kernel.org>, <andi@etezian.org>,
        <alim.akhtar@samsung.com>, <aswani.reddy@samsung.com>,
        <pankaj.dubey@samsung.com>, <smitha.t@samsung.com>
In-Reply-To: <f4ca26c6-6c03-b7e7-3d5e-f6bc42c3a785@linaro.org>
Subject: RE: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware
 for Exynos 3250 SOC
Date:   Wed, 9 Nov 2022 09:32:25 +0530
Message-ID: <000001d8f3f0$165e5090$431af1b0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIVsoyS1LfNYjvTRsU3iIkRJvur6ALOAibeAe9RDWYBPCmjzAG0npdKAqjgM0StacB8gA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221102130602.48969-1-aakarsh.jain@samsung.com>
        <CGME20221102125813epcas5p40a38f17a267276ff8b2bc5861b5d450d@epcas5p4.samsung.com>
        <20221102130602.48969-2-aakarsh.jain@samsung.com>
        <c55d29d2-a70a-f2ae-b605-1c63051202bf@linaro.org>
        <aadbb452-506d-89cc-28d9-497369c0018e@samsung.com>
        <f4ca26c6-6c03-b7e7-3d5e-f6bc42c3a785@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 03 November 2022 18:16
> To: Marek Szyprowski <m.szyprowski=40samsung.com>; Aakarsh Jain
> <aakarsh.jain=40samsung.com>; linux-arm-kernel=40lists.infradead.org; lin=
ux-
> media=40vger.kernel.org; linux-kernel=40vger.kernel.org;
> devicetree=40vger.kernel.org
> Cc: andrzej.hajda=40intel.com; mchehab=40kernel.org; hverkuil-cisco=40xs4=
all.nl;
> ezequiel=40vanguardiasur.com.ar; jernej.skrabec=40gmail.com;
> benjamin.gaignard=40collabora.com; krzysztof.kozlowski+dt=40linaro.org;
> stanimir.varbanov=40linaro.org; dillon.minfei=40gmail.com;
> david.plowman=40raspberrypi.com; mark.rutland=40arm.com;
> robh+dt=40kernel.org; krzk+dt=40kernel.org; andi=40etezian.org;
> alim.akhtar=40samsung.com; aswani.reddy=40samsung.com;
> pankaj.dubey=40samsung.com; smitha.t=40samsung.com
> Subject: Re: =5BPATCH 2/3=5D media: s5p-mfc:Add variant data for MFC v7
> hardware for Exynos 3250 SOC
>=20
> On 03/11/2022 08:44, Marek Szyprowski wrote:
> > On 03.11.2022 13:35, Krzysztof Kozlowski wrote:
> >> On 02/11/2022 09:06, Aakarsh Jain wrote:
> >>> commit =225441e9dafdfc6dc40fa=22 which adds mfc v7 support for
> >> Please run scripts/checkpatch.pl and fix reported warnings.
> >>
As I didn't see any checkpatch warnings from the above commit message.
Anyway I fixed all checkpatch warnings from drivers/media/platform/samsung/=
s5p-mfc/s5p_mfc.c and posted 3 patches for the same.
https://patchwork.kernel.org/project/linux-media/patch/20221109035348.69026=
-1-aakarsh.jain=40samsung.com/

> >>> Exynos3250 and used the same compatible string as used by
> >>> Exynos5240 but both the IPs are a bit different in terms of IP
> >>> clock.
> >>> Lets add variant driver data based on the new compatible string
> >>> =22samsung,exynos3250-mfc=22 for Exynos3250 SoC.
> >> Aren't you just missing the clock on Exynos3250?
> >
> > Nope, the Exynos3250 variant indeed has only one clock and the driver
> > code simply ignored the -ENOENT error while getting the clocks, see
> > the code in drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c, so it
> > worked fine even without it.
> >
> > IMHO it is a good idea to clean this up.
>=20
> OK, then please make the new compatible followed by old.
>=20
> Best regards,
> Krzysztof


Thanks for the review.