Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp49254rwb; Tue, 8 Nov 2022 22:08:43 -0800 (PST) X-Google-Smtp-Source: AMsMyM4iRZ2HUNQNh8gVHi9Hecxf4YACxOXdL9KhtTmHLfNeWqE3jKzy5fNbTjVOfRkrqsWTBSm5 X-Received: by 2002:a17:907:6ea9:b0:794:8b93:2e44 with SMTP id sh41-20020a1709076ea900b007948b932e44mr56865073ejc.407.1667974122860; Tue, 08 Nov 2022 22:08:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667974122; cv=none; d=google.com; s=arc-20160816; b=N0R0jP7xVTF9HjuLvkFHnHVi/BleKwzEhm07m2Hlwa8QihBreW3rGSt2p97QZMh56e bab1fh+matEDlKh/eqSyeR3WaHWNEepsIPqFZVYYv/YCjv8NwfpyXgZznaVre5rGzCCZ a0UkJ+L2SJ4/F0G0sWvaLwzCI2/LhGM/cNaGpYsTk+G1hu8Y3uoNIPQDjZ1EDWNiHYTw e+/c+7cBoXA65NmxB7GFCIEGHzSoJVJQBdPLYoJ3YrXAqaQ35Jm2f6reRMBvsEuvAhpq XqcaPx7Nxfdoy2x6kSw5QgYoWpWHB+YBEGUcyjes8WjzaRNiY2bhc5L2I2RXppTNxuwa 0qmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=pH5n86V2vlwlF9aXOB/jdhykuMPZm9xt1mr1n2dpOHg=; b=Bp4dveW4jkc4CEHa0EiTrjLJXbCCVG3jmWSUA5n5UgJO6VFPzNPUlOMVApYpbVkR6W KxbxgMcvlqxRwqZuknyiKKQw5dV4Qy1Mo18vApbu2UOLATvnOQvA0Wumpn5xqZcQ6bsa Kznw8EUh9IjeGfMZhCJW4zpHq5nSzrfHjPShRbwdH5rGcmg+2qTk2OvtYVvpLxuD7U2F Rd1atmYW3Xli2U/v4mTH0EmgtDwy6VINpUAkRZ3xFGFDhclpereSSj6L2CP1mQHJI9eY jqBE2DJygYNJDBTRTMYDFwhPJHinaHe8qc3Jxx4fkbqwgP1dd/RhKqFK2s+8abBXanZI bt1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ELM5sQOh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw3-20020a170906478300b007707c67f523si14845726ejc.335.2022.11.08.22.08.20; Tue, 08 Nov 2022 22:08:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ELM5sQOh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229470AbiKIF44 (ORCPT + 93 others); Wed, 9 Nov 2022 00:56:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiKIF4y (ORCPT ); Wed, 9 Nov 2022 00:56:54 -0500 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1872B1EC5A for ; Tue, 8 Nov 2022 21:56:54 -0800 (PST) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-333a4a5d495so153282187b3.10 for ; Tue, 08 Nov 2022 21:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pH5n86V2vlwlF9aXOB/jdhykuMPZm9xt1mr1n2dpOHg=; b=ELM5sQOhvtk7Le0mgzSHPBbF3z96SUAiq8PK0ajfCWmpIb1cdD654rA1m9qnx7RqKV zSFmZ/fExpnUlyO5cyzCR8zog9DOcSY/EGbTY/lFK/VP8AnviZsGFo0/lardO+V/ovjs lMQBPG8dYDBxfMxrtLi8c/APvSA2bzQ2/nq0jIArn/ojKNikHAMbeWVcfK/7MIyxbtoz f4Yq/f5dz8eQym+tIVb80tStykSnAwEIsOytmvIAMXW8XOViOv7tijopd1r8pDqbhWjZ p35qEjhM/aGhIVhUIf8J2yZXLxxIBbdHn8lDbS1ZEGx6DHc7MxOqsT8RpVN1S7klqbGW 3l8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pH5n86V2vlwlF9aXOB/jdhykuMPZm9xt1mr1n2dpOHg=; b=5PVsOu1uAmmuLYMKLeGjMtZp43+pKwlK4IQ2u63MAK1i92c4fdJelLwffAHKmWxZCZ Jy1bRjjc+vjbgjiUDkn/1dsFrb/vtDEm78OiVdY3kAuXRCKirV3qfOn4Vnd4XfDDTQQG a+CTT3nXshjnSe5Go23STkZa6dgPV837eMvNe6VoUOh346pwZe7KzFnUO524qerHXNDx UXVSFZGfPKnVFoIPWVdufZfCj7GunEkt39rFkdqy7In+fVmvNONjWefmt9m+6yw07W7C b6LmOhAo/h5971ECk17BiIpJDk4GvieQ4Pe2esDD/gcH5pB6XJ8L9qRDzK5UDW30ixOt jEUQ== X-Gm-Message-State: ACrzQf2sB3tjMFwLbBM2EucSg73A5nzHvcj11b7buenFhpXHXLIjSZqS Z/qI3npPI9ZIGGUtDFWAR+yat4H3jtmYWqBXd8YC9A== X-Received: by 2002:a81:7585:0:b0:368:28bd:9932 with SMTP id q127-20020a817585000000b0036828bd9932mr54776947ywc.332.1667973413067; Tue, 08 Nov 2022 21:56:53 -0800 (PST) MIME-Version: 1.0 References: <20221108123320.GA59373@debian> In-Reply-To: <20221108123320.GA59373@debian> From: Eric Dumazet Date: Tue, 8 Nov 2022 21:56:42 -0800 Message-ID: Subject: Re: [PATCH net-next v2] gro: avoid checking for a failed search To: Richard Gobert Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, lixiaoyan@google.com, alexanderduyck@fb.com, steffen.klassert@secunet.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 8, 2022 at 4:34 AM Richard Gobert wrote: > > After searching for a protocol handler in dev_gro_receive, checking for > failure is redundant. Skip the failure code after finding the > corresponding handler. > > Suggested-by: Eric Dumazet > Signed-off-by: Richard Gobert > --- Reviewed-by: Eric Dumazet