Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp81232rwb; Tue, 8 Nov 2022 22:42:45 -0800 (PST) X-Google-Smtp-Source: AMsMyM7femkzYNUzfZex4IKhDrO0DeToQcqHS1wFw4B/IXTHL6J3B+8rxdd5Vj+RSyCVh9onX0GX X-Received: by 2002:a17:902:c14d:b0:187:337b:ad9c with SMTP id 13-20020a170902c14d00b00187337bad9cmr45564705plj.35.1667976165706; Tue, 08 Nov 2022 22:42:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667976165; cv=none; d=google.com; s=arc-20160816; b=Rnw9F1c7UR3VcdUYISnt8c/NPnyt+dMF9D+2ywFy8S5OS4smczvpETfuxgh6KhXbVg fhk+I5QPFU2d4YkwsUZJxdMM89zOMQRx6hfKqSpA9FsJPJqmPIyZVPvr901+JaxHvI3R Zjbk7L1K3XG3wQj3siFegkiZDWc74h+h+cVsgzX51WyxV6o5uDgf3IJdGheNFfGDkPxH m9xEyySd4jmb5HTVYI3Wqg65YmwPqEGlx+fdg617/3g/h2NXy5GsopD3g5ZV9h01UJbM 30ol7OL2faisGytrtEst03p+DrBvr7YNPmVsVmRtZoN4xcstloiLo6HguixVj1wxK7N9 GDOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=wYJT4SSAWZ3yO4LbgN35yeFQWA0Xc1NaS26FOMl7Nt8=; b=FIxL64v+ZJB/EdgPq59/b2n9a7MGe0b68jLL0Ws91wtwm+D2zAyM1htiwo7cD2U+ly oLKOAbckcJLdvhpp3NtRqLgV1V8w0f2zdRAalA07WFf7l6BWWGOVWdPbvLFSevOSO5KR xwp/QAkNJ895yIrM8DsPW/H9QkT2PqXZfiHCWPg2T9+6/uSSjORQBAR/eStLCrVwqRTB yp0mtfXWud5g0iFEGKiwAmdSNPHYnzX2By7Z6S6cUuEZ88BJESSyhURT9WKRqmVHOXY1 3M24G8dzxGzA0yqPsB677uKYwlP3b4jyiCicbmOrCY6bX14CXwhHEvWNLkThOTVXGmy9 qjQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nh17-20020a17090b365100b00212f86579f8si467033pjb.111.2022.11.08.22.42.34; Tue, 08 Nov 2022 22:42:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbiKIGUz (ORCPT + 93 others); Wed, 9 Nov 2022 01:20:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbiKIGUu (ORCPT ); Wed, 9 Nov 2022 01:20:50 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 331D8193CC; Tue, 8 Nov 2022 22:20:47 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 1613B68AFE; Wed, 9 Nov 2022 07:20:43 +0100 (CET) Date: Wed, 9 Nov 2022 07:20:42 +0100 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Gerd Bayer , Jens Axboe , Sagi Grimberg , Niklas Schnelle , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: nvme-pci: NULL pointer dereference in nvme_dev_disable() on linux-next Message-ID: <20221109062042.GB10528@lst.de> References: <20221108074846.GA22674@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 08, 2022 at 10:23:31AM -0700, Keith Busch wrote: > This looks good to go. I vote apply for 6.1, and we should consider > merging your larger refactor for 6.2 after more test/review. The problem doesn't exist yet in 6.1, it is caused by the recent quiesce rework.