Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp152752rwb; Wed, 9 Nov 2022 00:02:32 -0800 (PST) X-Google-Smtp-Source: AMsMyM65LmV/geF9LigepjuHT9iIwhjX2mKuwiw2W6+ku1yaR6wL4Nm0Iweq5CRsdQwpiimzFblD X-Received: by 2002:a17:906:fe45:b0:791:9624:9e9f with SMTP id wz5-20020a170906fe4500b0079196249e9fmr56489182ejb.86.1667980952203; Wed, 09 Nov 2022 00:02:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667980952; cv=none; d=google.com; s=arc-20160816; b=p23vb12zrPO1U155P/axogWJ+Wf8jUMmo4sEklk/z6Z4gcMkLDlew0p8TzwuZjiTQt oOlSQt9oBKsVBP5jzOTHmd4YJcocvyZhbHbzSMGd7FnhiqbSv6b/jW7I2HktSq+o326w But6J/5tCUJyRspi/ei5zGRMgTpv3YG8e7EaZ+M7AFrL7JM6GuUxbig9/GOSztmuLpCm imr7R6woq2xxGQdWHKJlOTa3edUlte5YV5f9KOqJOVClU8Zm1lS1fhQtvkQsm0+3bBya 52/y6mHtmxcCofFXAfLEGCEFSajS4xL1X8ZUrwybIgSOOmSacrqyZy/cGijiYdKt0izl 4KtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/Yt0xNTwg8RTyo1Soz6rCJVqk/VtllR1FlLGVa5FbBU=; b=w85G9KDZtr3VIzrSR+k41CTj9H9m3ddm2HdWjvdbMctXSsozlduTsuMqEt4j+GEtF0 M+/g4JqiPpVY5fMm6mzCkSzJ+1rIzRI5oiGtn4gjMFLvDceAlRwx9Vt0ogoxi+aWvDZb VT2reiJYnCfyOu1/tG4b1CGh1LmIAVC1g0UkQytLprR3rLfytsDAFZFCGn3Mu5sI+kfI QZ3FwfqpqUcHhuHjkw+FvXASytmqOpGeF5Bx2RdW+5PGUT7dYLlFH+zxWo0BredisoNq TUKFI8aL+dmS0idG3gWMpufXm5Z3ZNzslTQbTYS5tQ8DVM399+6xre4tYa1KReGhbTDt KN3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xh14-20020a170906da8e00b0078e063fc787si16327647ejb.433.2022.11.09.00.01.58; Wed, 09 Nov 2022 00:02:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbiKIGvm (ORCPT + 93 others); Wed, 9 Nov 2022 01:51:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbiKIGvk (ORCPT ); Wed, 9 Nov 2022 01:51:40 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1519A18B35; Tue, 8 Nov 2022 22:51:37 -0800 (PST) Received: from dggpeml500021.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N6bGR3nbszHvkH; Wed, 9 Nov 2022 14:51:11 +0800 (CST) Received: from dggpeml500003.china.huawei.com (7.185.36.200) by dggpeml500021.china.huawei.com (7.185.36.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 14:51:36 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500003.china.huawei.com (7.185.36.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 14:51:35 +0800 From: Yu Liao To: , CC: , , , Subject: [PATCH v1 0/2] rtc: fix race condition between uie enable and rtc set time Date: Wed, 9 Nov 2022 14:41:45 +0800 Message-ID: <20221109064147.1836133-1-liaoyu15@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500003.china.huawei.com (7.185.36.200) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,HK_RANDOM_ENVFROM, HK_RANDOM_FROM,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch series fixes two issues in rtc_set_time caused by race conditions: - rtc_timer_do_work will loop for a while when setting rtc time in the future with uie enabled. - RTC_UIE_OFF does not work when RTC_UIE_OFF and RTC_SET_TIME are running in parallel. Patch #1 extracts lockless version from rtc_update_irq_enable, and patch #2 addresses the race condition issue. Changlog: rfc -> V1: 1. fix smatch warnings reported by Dan Carpenter and kernel test robot: rtc_set_time() warn: inconsistent returns '&rtc->ops_lock'. Yu Liao (2): rtc: add lockless rtc_update_irq_enable rtc: fix race condition in rtc_set_time() drivers/rtc/interface.c | 43 ++++++++++++++++++++++++----------------- 1 file changed, 25 insertions(+), 18 deletions(-) -- 2.25.1