Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead
Mime-Version: 1.0
Message-Id: <06c4f370-715d-4c66-ad43-143b652af5ff@app.fastmail.com>
In-Reply-To: <20221108232228.1177199-1-nfraprado@collabora.com>
References: <20221108232228.1177199-1-nfraprado@collabora.com>
Date:   Wed, 09 Nov 2022 08:28:50 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     =?UTF-8?Q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= 
        <nfraprado@collabora.com>,
        "Matthias Brugger" <matthias.bgg@gmail.com>
Cc:     kernel@collabora.com,
        "AngeloGioacchino Del Regno" 
        <angelogioacchino.delregno@collabora.com>,
        "Bjorn Andersson" <andersson@kernel.org>,
        "Catalin Marinas" <catalin.marinas@arm.com>,
        "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Shawn Guo" <shawnguo@kernel.org>, "Vinod Koul" <vkoul@kernel.org>,
        "Will Deacon" <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for
 mt8183-kukui-jacuzzi-juniper
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 9, 2022, at 00:22, N=C3=ADcolas F. R. A. Prado wrote:
> mt8183-kukui-jacuzzi-juniper is one of the devices set up to run tests
> on KernelCI, but several of its drivers are currently disabled in the
> defconfig. This series enables all the missing kconfigs on the defconf=
ig
> to get everything probing on that machine so that it can be fully test=
ed
> by KernelCI.

The changes all look fine, but I would recommend not separating it
out into 13 patches when you are doing just one thing here.=20

As a general rule, if you keep saying the same things in each
patch description, it is usually an indication that they should
be combined. Similarly, if you find describing unrelated changes
("also, ..."), that would be an indication that patches should
be split up.

> Given that all kconfigs added in the series are to enable support for a
> MediaTek platform, it seems reasonable for it to be applied through the
> MediaTek tree, but the commits themselves are independent (apart from
> MTK_CMDQ and MTK_SVS) and could be applied separately.

Agreed, merging this through the Mediatek tree is the preferred way.

     Arnd