Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp190607rwb; Wed, 9 Nov 2022 00:44:00 -0800 (PST) X-Google-Smtp-Source: AMsMyM77CkuSRteGDsoPxY59xdn8fl1yvV4LoC50pxSW6H58Bk8iulYpkfpq29bNjvfUYNsmAIuS X-Received: by 2002:a17:906:eecb:b0:73c:5c85:142b with SMTP id wu11-20020a170906eecb00b0073c5c85142bmr56786462ejb.433.1667983440278; Wed, 09 Nov 2022 00:44:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667983440; cv=none; d=google.com; s=arc-20160816; b=tVY7lxLsd8aoNuEG9HU9wZMxloCKVfDCGBMerLg3XW9wuFlsAQ0ZbrBsVxRDy8f4lp XTygkWGCExg3GZt/hMBAIGHN9ZEbY0swHChpkuS2tjXPXt/wDI2yqzzHBWSVwxSCQras YutCZsfmqxhWDLZILRSlU83Us7zfI83LhmCz/AfiyCvRn6Cx+19peE4m4dDpmXjtsXpJ VfYrjc7gvdBP2P2PLFU90nZWCq3+OBydBV1w6fagGKmPtjpIiqAdCGKn4N5kwpu6zqnj 0iRS9GlxO2zdMnWr0AOrdXWN8soJhGp2kOH6tQQJMZ/siqPNtGdFTsG9MkxOMjlhEmke frhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1aYtp8rKKFj6AMeEh8TgKPoMz3+QrQuPeMrc+lG2dC4=; b=rijbJ0nALH5eYp631C+NLl+FrgMb6COpoPxF/9iEn89bgmIPGwgnoTzjZSyjEveHOg pjcwZUK+2rcuuYpK20kw+iaDwBsk2hWYtgsNCIq0aaQFbadgi/M7gMOSoennNImS2AhK bPUcQlgUx1w96StC4N/o0hdeeMizTknCH34kgVGTyRpEGCcUbT7BQBGJlhcd3R5hIkBT oBg7gGpd/ZcurhfTBtJEHM09tz55Q7P09BE4jVt8PJtbLNJRHl9XSjelWkMoXxlPjPvc daa7BcGWVpv9uUvVQuK7W14lvkXN1JLN5XdK0Lu29mpUXIZ8xdhw28V8KdPX4UWeSKuD 7NYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CgVAeDwH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv22-20020a17090760d600b007ae8a4b03d7si2158927ejc.973.2022.11.09.00.43.38; Wed, 09 Nov 2022 00:44:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CgVAeDwH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbiKIIXx (ORCPT + 93 others); Wed, 9 Nov 2022 03:23:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbiKIIXu (ORCPT ); Wed, 9 Nov 2022 03:23:50 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95F8F5FD6 for ; Wed, 9 Nov 2022 00:23:49 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id p16so10277745wmc.3 for ; Wed, 09 Nov 2022 00:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1aYtp8rKKFj6AMeEh8TgKPoMz3+QrQuPeMrc+lG2dC4=; b=CgVAeDwHGGqjX9pPwdf50j6laHJDZQEpjWOLA+xKGBUAg7h+8blHA3XYE+A4H6hy1I +1dKSYtKGZUuAl+U9Z0WfHgdyBZUvv9EzmvnG1ytRtExRhNWemLhbSmYN7VfeAGhepYx U7rN1/9hE5+K+sGZigDzLFL7ujbKcztqQxkyIAxYSeQCEq2CWvKXsIfVZ+dzQwytVxHm /enmgz1Fm6oegStPmknZqLuUrCtU4jyv1J+g+ubkBgU15W01xBdlc31YPr08Z+nBt3Mh umPmuVYBzhjNej5bjPy6kldig6wZnM02W4P2ZIMdQO5MXwK4fBQcYQSJ9CeltH8XObBN aWPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1aYtp8rKKFj6AMeEh8TgKPoMz3+QrQuPeMrc+lG2dC4=; b=5i1m/jtKBXjDVdFjm2AXPhjntUm8WMx9mPVOH4rblDEFzuFTQINYKzosMRvK31oOaw 2/gjToQN3/Pu5l02Vj7ZucGmFpcWaH3iloA4b+kD9KIdB/1S+TGUM0bmEPHoWkUVhFna UExB3FyrNmRiCC/uYlHTBtlna+tp+kznAq7nQf/h5sMTeJe7hFJ9Oou6fZQzJR2eFlh5 UtHriPcrylvS2/UH0EFBUssOItUf4RrQOktaSG1lbSQm9ytJ6L2kFdqqdsh05nYYgClg eOBHCq5+5wf8jtn6wrX/dvj26UVZw2GNHGT1CSkfA3Qb/o4XxFABmHb4ilg+L5BDp9g4 GJOg== X-Gm-Message-State: ACrzQf2Yhb3JGesLoYGH0ugRVWLYy0lNjzbBmqU5/TbYgaugBmJlgB8a K2rbyF31Xs1PWa9mJoiJXZWHTw== X-Received: by 2002:a7b:c7d1:0:b0:3cf:6b10:ca8d with SMTP id z17-20020a7bc7d1000000b003cf6b10ca8dmr873390wmk.44.1667982228087; Wed, 09 Nov 2022 00:23:48 -0800 (PST) Received: from ash.lan ([167.98.0.196]) by smtp.gmail.com with ESMTPSA id h1-20020adffd41000000b0022da3977ec5sm12408609wrs.113.2022.11.09.00.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 00:23:47 -0800 (PST) Date: Wed, 9 Nov 2022 08:23:46 +0000 From: Daniel Thompson To: John Ogness Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Jason Wessel , Douglas Anderson , Greg Kroah-Hartman , Jiri Slaby , kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org Subject: Re: [PATCH printk v3 12/40] tty: serial: kgdboc: document console_lock usage Message-ID: <20221109082346.2jtw2i6asli5qohk@ash.lan> References: <20221107141638.3790965-1-john.ogness@linutronix.de> <20221107141638.3790965-13-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221107141638.3790965-13-john.ogness@linutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2022 at 03:22:10PM +0106, John Ogness wrote: > kgdboc_earlycon_init() uses the console_lock to ensure that no consoles > are unregistered until the kgdboc_earlycon is setup. This is necessary > because the trapping of the exit() callback assumes that the exit() > callback is not called before the trap is setup. > > Explicitly document this non-typical console_lock usage. > > Signed-off-by: John Ogness > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Douglas Anderson Reviewed-by: Daniel Thompson Daniel.