Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp221648rwb; Wed, 9 Nov 2022 01:17:06 -0800 (PST) X-Google-Smtp-Source: AMsMyM7a+vYZlOh9sNlLpBVCZECVe9PDxupOYdyzx9ld1nr6fa8gpv5vBkzqg+E5jW8ib/+hHYJC X-Received: by 2002:a17:902:daca:b0:188:5136:c230 with SMTP id q10-20020a170902daca00b001885136c230mr34567182plx.157.1667985426546; Wed, 09 Nov 2022 01:17:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667985426; cv=none; d=google.com; s=arc-20160816; b=pBevgxG2Nmeduwd9iC71jes/GHJYcwy0z2//JeX22OdvbJAtgcYuXVvKH2MdyUESCt IphJo4/A48gdZaT3ZRYDlTMrpFWCYD8fiz2VSUKjbhEiX1K1n8vNREpqjyNDAnNSJ8wi 8273dfvsNAqrgQEC5p4AyduGb5DMluuWnNPqoi+rYE1HoGIc0tc1/oxuA0wcbx499EZL y+f8bncWCVbzJRyAXEzs1iEJOZHBakGI3FeQ/N1iQwCic6d/acI5ZjRlx3F8sRWZwZ2v 6gi/9jiuuS6HI85pkiJKXpLsDFpSLNl9CMh4W8bCXC2i0W5KGnzRAnZ6w+MiJqHCva1W /IYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=YiuJrETfRsCM+L6rNuInfN99euGQ4SmAPdH0IhHPMoQ=; b=USElp0/dqsccnyuTl62NR/EqO2x8RkR2oOlqG8fg1UVnQqTg7sjarV8+rLK2CrBdBA HUlqUP1S4g24VFdWEz20a7K3CBH7kcP/mD2aHpeLebVQNW5w85toIKRtgQ+qkdNeiuC9 F2Qj06YD5BGPIk4Pd+fhiKSlpcv3HOimF7DOEO4WiQfQ+LZs/yIHDynYyGLbNTX/oFKU iXOxCSg4XLXWgpIBdr/USvsSJzHrbg/z6WKfgsGJJmb3zWo9cn0KAAS4+SCUhb2eyTYj +MfTFW0SUq7qLfGxmDnoapJ9EIrfsHlrra6ka1J+chZsJaJyqJzP4+8Z+7C17HhtvROg oYpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fLZKy9C4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a170903124b00b001783af487d1si20383829plh.533.2022.11.09.01.16.52; Wed, 09 Nov 2022 01:17:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fLZKy9C4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbiKIInD (ORCPT + 94 others); Wed, 9 Nov 2022 03:43:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbiKIInC (ORCPT ); Wed, 9 Nov 2022 03:43:02 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B96183A8; Wed, 9 Nov 2022 00:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667983381; x=1699519381; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IDum+SM6k0OVKgwCIgzv/T0+eZZYscX/FC4l1QYdbtA=; b=fLZKy9C4A/h6fe/S9IIHCfqZIUSpjCUWA7sY59J4QZPaHu14b4tJsNx1 Beia76wBgzipwpKT2H1D7mBd8CioKZv2yi97cFZYDkWIdDJv/k+q+lb1w Vic/jQE/b06akiib3KGDhnJnBh76fmBKMvvH82Dh4JviNVl5+BZAWFIun +LqF2oRQmSjARE/mlT/6i82uFJ8RJBNldkQBEonaGv/cqaeLxxKhUixP/ 4QHTlCJFQbABNw6HYUUFgpxVqpkUIXi6XlveaeaA4ymTwOsEDL7F8Bm+s yD7qerwjeykkpVrv05hov/x+e22CDbUgxSclX9HqdVCtrdIO3KeJ5ws45 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="308544190" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="308544190" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 00:43:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="631182813" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="631182813" Received: from skxmcp01.bj.intel.com ([10.240.193.86]) by orsmga007.jf.intel.com with ESMTP; 09 Nov 2022 00:42:58 -0800 From: Yu Zhang To: pbonzini@redhat.com, seanjc@google.com, kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] Cleanup VMFUNC handling in KVM. Date: Wed, 9 Nov 2022 15:54:11 +0800 Message-Id: <20221109075413.1405803-1-yu.c.zhang@linux.intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since VMFUNC is not supported for non-nested guests, and executing VMFUNC can cause a #UD directly, if the “enable VM functions” VM-execution control is 0, KVM can just disable it in VM-exectution control, instead of taking pains to trap it and emulate the #UD for L1 guests. Also, simplified the process of setting SECONDARY_EXEC_ENABLE_VMFUNC for nested VMX MSR configurations. Change log: ========== v1->v2 - Split the patch into two pieces. - Use KVM_BUG_ON() for unexpected VM Exits. - Comments changes. - Commit message changes, trying to better illustrate the reason. Yu Zhang (2): KVM: VMX: Do not trap VMFUNC instructions for L1 guests. KVM: nVMX: Simplify the setting of SECONDARY_EXEC_ENABLE_VMFUNC for nested. arch/x86/kvm/vmx/nested.c | 26 ++++++++++---------------- arch/x86/kvm/vmx/vmx.c | 7 ++++++- 2 files changed, 16 insertions(+), 17 deletions(-) -- 2.17.1