Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Nov 2022 16:09:01 +0800
From:   Chester Lin <clin@suse.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        Rob Herring <robh@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jan Petrous <jan.petrous@nxp.com>, netdev@vger.kernel.org,
        s32@nxp.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Matthias Brugger <mbrugger@suse.com>,
        Chester Lin <clin@suse.com>
Subject: Re: [PATCH 2/5] dt-bindings: net: add schema for NXP S32CC dwmac
 glue driver
Message-ID: <Y2tgHYT+rV1+fxTm@linux-8mug>
References: <20221031101052.14956-1-clin@suse.com>
 <20221031101052.14956-3-clin@suse.com>
 <20221102155515.GA3959603-robh@kernel.org>
 <2a7ebef4-77cc-1c26-ec6d-86db5ee5a94b@suse.de>
 <Y2Q7KtYkvpRz76tn@lunn.ch>
 <Y2T5/w8CvZH5ZlE2@linux-8mug>
 <Y2UT4yIqk0pV6FHA@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y2UT4yIqk0pV6FHA@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3DuYdI/+KOdCNk7DNgMxL4a33ZRhtfGkgdMX4aVPIFf0+M3f1TGjkjeYuBhv?=
 =?us-ascii?Q?JlKm8wrgeq7HoTOeL+im2G/pGLNn+H9i0/bP8ux/NwrE4K8IU69SL7AfXUV8?=
 =?us-ascii?Q?qJT0UGm3WOAo/d3oo9G2/PweVjUzOXpJIj9M6YiCU3CzXrIzUkGSrZn8JY3v?=
 =?us-ascii?Q?z4qvheJFunQl+SoMVzEmnaLBYgSAruppswHv2OJIG0pVf950oLpwoT28jjfu?=
 =?us-ascii?Q?U1s/XQ0GbrJIimMBek6mwCRNWJN/5ftinD/HOHVzXC79Fm7JKDS0xLweiilP?=
 =?us-ascii?Q?gcFYIOn+QVfc1nkLqa+dzFg2Iwsm0oEVJav2bI+mj8W7QRjyQm5MKDPu5+jx?=
 =?us-ascii?Q?rZohgaeuw3K2NUgAQEnqnVnMPOKj+4ZBsPJYrMye2IbNUCbRudIeoAn9j+Sz?=
 =?us-ascii?Q?ulrMtxFJdORuKr05kofamZbQD7TkNP3ax0R2e8dzbytwE1QyZ83DPq5BXUco?=
 =?us-ascii?Q?MPnjGZlLr1LfSt16vtUg+nidMTw1Y12tKblLUeGiCY/PKeMnGIeKr/qe5IPF?=
 =?us-ascii?Q?MiZlah8lfd2zIt/E0H9JVPunCI60EAy5lVuPgl0yRo23W3UwrxAUsGLLBWEp?=
 =?us-ascii?Q?Yt9PxygmyjuUpCS5XlvMQZ9McfsIQ0s4sF2POrURUagsL1JPixonBht6XfvX?=
 =?us-ascii?Q?OJwmwzzh18iFuJQN0Z50FVvwP/TEYDimg60PCbMwOq6OBgPTSG6eILagnrMi?=
 =?us-ascii?Q?x0TNF6UQaJsyXT/XsyNmrrTipqojNNgGCgbLghhsWO/XCJL5l0rZ9yJRaC/p?=
 =?us-ascii?Q?Q43tGhZX5VA6WVg2U7KcAb1gzEhNNTcphNm90FDgXy5PsjQL9AgjdZaRyWr1?=
 =?us-ascii?Q?hMW55Hm2tpMzz0Sl/4aL5u209PnYErvt0dJIgj1c/Zt25ZpgSop9rht2G1eF?=
 =?us-ascii?Q?HE9MDBSu06ugotiajSTzZsRjjP1+n0mCjl/8d5Zx8QXWx/y1srpopDbh13Xa?=
 =?us-ascii?Q?wQPSCauW7t3IL/S6RxJKfsUwmZAI52bmXbxOmFifng4EJSf23QoBneaEEoTu?=
 =?us-ascii?Q?FFIQkVQ6U23TfQt2yYSW4KAySATMxyZ0Ac3ScLinMSgebLSXv7B6V70oOn5t?=
 =?us-ascii?Q?Ko3fWoARZln4RN2m74SCfAQSg3lUJCA2KvtOsztjI8IPMmtMNLlJuXq8tK9B?=
 =?us-ascii?Q?gAM20vQRskhM7N2dzoSayHswj6T4YfSu8ruCzpZflmD1OMOuMfF3UO//7BDa?=
 =?us-ascii?Q?wswR8GZRAK2AlyAi5RwWyEkRbuQiEeNFewIgk/3IMz0RA6KaAHSCVYwcWUet?=
 =?us-ascii?Q?B3CUn9nRzYLoShA77ycV39+nEfdWf8WwSSMmr8HYPXT4AFj2s+ZNIlVH+h8O?=
 =?us-ascii?Q?HiA97exo0sYWzFbiqG1qDlm04eTQiQnADWz/fB1eoRqqL5nlwJFOFbofIgea?=
 =?us-ascii?Q?zPbVEAzwF0bqlcXWKJj8TrHpw+RI0Sydpf9mhyrjdl7vgXmFriM6D0cjIbAm?=
 =?us-ascii?Q?LoEGXvT+XevYJIJ7C6EMySdZpAad9tkXTTfihYvepn4mRHVV0skllRkbNKOY?=
 =?us-ascii?Q?rNGOS76vo3UCTU4da10OR1lWvTAeJFkFb89Keg5Tqein1Z/As3HTbwPN1pgZ?=
 =?us-ascii?Q?VzOwXWxkcCqb7QXVbR4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26108198-e30e-407f-48b3-08dac229b3df
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 08:09:19.6048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bRyAJlfA4bgzJC37PO+ctqunKmphpaC8JyjEncIx3QGMVZgvpU1eNBSkjsOE2VaB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8323
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

On Fri, Nov 04, 2022 at 02:30:11PM +0100, Andrew Lunn wrote:
> > Here I just focus on GMAC since there are other LAN interfaces that S32 family
> > uses [e.g. PFE]. According to the public GMACSUBSYS ref manual rev2[1] provided
> > on NXP website, theoretically GMAC can run SGMII in 1000Mbps and 2500Mbps so I
> > assume that supporting 1000BASE-X could be achievable. I'm not sure if any S32
> > board variant might have SFP ports but RJ-45 [1000BASE-T] should be the major
> > type used on S32G-EVB and S32G-RDB2.
> 
> SGMII at 2500Mbps does not exist. Lots of people get this wrong. It
> will be 2500Base-X.
> 

Thanks for your correction.

> Does the clock need to change in order to support 2500Base-X? If i

Since I'm not a hardware designer from NXP and I can't find any board that
S32G2 CPUs could integrate SFP, so I am not able to tell how the clock could
be configured while supporting 2500Base-X.

> understand you correctly, Linux does not control the clocks, and so
> cannot change the clocks? So that probably means you cannot actually

To be more precise, the SCMI clock protocol in ATF [ARM Trusted Firmware]
doesn't design any interface to get/set parents of a clock so that re-parenting
clocks via the SCMI clk driver [clk-scmi.c] in Linux Kernel is impossible
for this case. That means, if any board design allows run-time swap on different
phys, the dedicated clks which represent each phy-mode are required in order
to trigger clock re-parenting in ATF since different phy connections would
need different clock sources.

> support 2500Base-X? Once you have Linux actually controlling the
> hardware, you can then make use of an SFP or a copper PHY which
> supports 2.5G. The PHY will swap its host side between SGMII and
> 2500Base-X depending on what the line side negotiates, 1000Base-T or
> 2500Base-T. The MAC driver then needs to change its configuration to
> suite.
> 
> 	Andrew