Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "hare@suse.de" <hare@suse.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v1 0/2] UFS Advanced RPMB
Thread-Topic: [RFC PATCH v1 0/2] UFS Advanced RPMB
Thread-Index: AQHY8qpuI/QP6FW+6keQsjCzPOix+q42QKMg
Date:   Wed, 9 Nov 2022 08:18:54 +0000
Message-ID: <DM6PR04MB6575F12BAAB0883DA91EFC5DFC3E9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221107131038.201724-1-beanhuo@iokpp.de>
In-Reply-To: <20221107131038.201724-1-beanhuo@iokpp.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?k8/tTtldFZiEsQhBv12uZOUWmdSKZ9wOHUlYPWO/5uv5hodJZxzVxYfw1nm6?=
 =?us-ascii?Q?99VyqAG26cwQpIefBlMirbVUtb2gBpdQ+myY4ko7pyJGW1PEQx9GwqoNMO2d?=
 =?us-ascii?Q?oQaV0L6OqRzLtzK116ZyByD044LGGHAigmfqcayO/tOVT47V/LhZU8G2NK/7?=
 =?us-ascii?Q?vr3eEyYD75SezFN2BRRDtgM7OI6jsCM1jSXBwVkPfmeT2b51+czh7XkXfw5a?=
 =?us-ascii?Q?XAcgIg73cIE8A7gk6aoA/nM02EwwMnCFo10ApxU1iRYjYfzHosoR15Er/w+i?=
 =?us-ascii?Q?Fq9k9fJ9EmBOmBoli77l704n+K++o7YQd3flWXvtEiGRzjQ7YeQf52+ws+lG?=
 =?us-ascii?Q?XtHUxDGo8I4D9ASRWFkl0OppMlwYWT/MwgGZEOgcbSuJKhj3gIno0NaEzhsM?=
 =?us-ascii?Q?rxbyYaKktEpyVv9TldhzGZ6M6HkjX02nOYqP1yRehbKUOyXUFi7zY7qyrz0y?=
 =?us-ascii?Q?rw4Gmopj6BbuQ1GkqS4wjSUt7w4HoihZWWlyV6j6jBdaIdoUriEg137T9Tpv?=
 =?us-ascii?Q?LyIqx+c4o2PB6ZKTBvDkbXJUXMhcJ0kIPklgOY/hpn1zkTtADQSFLnTpmrBN?=
 =?us-ascii?Q?Br5rRAUTaFMd1r0vwxbKZgSkME1Ubpoq8dTcpZM9IccT2Xfgp4DgPCRkiK4v?=
 =?us-ascii?Q?i02mIE9oo4fEO6v22jTAe+1R6cBrH8hnMD1EvVe1ZZVIeK4EppWTlil7U14t?=
 =?us-ascii?Q?1lq2UEJOojYyVb8xuis6mSlFeY9IuuWXyXBOgH9pB47cQkLrKMtv5wz/64D7?=
 =?us-ascii?Q?jdo/MQzZ1TfCQSTXTr1X8Ot2v4H9zG+3mep3s01A1ZG6kq4jfCJ7Kkk2r1y7?=
 =?us-ascii?Q?XqP63h2cMJnjRKzmjRuxXDC7ux1YfHxvU6dmQucW/RWiRGC/QaVIC6f/AGoY?=
 =?us-ascii?Q?3iF5PSPztXs9ed2gtaJLiz5YNZQJudbNEaOfRT2DbuDqOCdaslQNVhQFDdi5?=
 =?us-ascii?Q?swQ4p7cEfFuSvFM6Xx9ZvE4a/T2+4CmgW7/o3yRcGnzTCQA0dbbvTDC4vytU?=
 =?us-ascii?Q?4t0cTZwaJmEdQ+m2nh5Bbto1mDXfNc1XF9+HhbKKN4B0dYa7sBdoDWqkR+xm?=
 =?us-ascii?Q?97HizKKEMH3dtw0azSB2yakq+8vzRmyAvM0CVDe3+YSGXUAqroY27SSsiHnC?=
 =?us-ascii?Q?FZ2q2UPiVSyV3Bo1nqBK+cEz2rxtEEE6OEa+xnjF46D5o2q8kdjxxT7qS6fs?=
 =?us-ascii?Q?E4GZF6UGQ7nuxonwM82Ff/TTzfI4+DV3sBlrSbOag/zbPz1PeOsx6xWph4z/?=
 =?us-ascii?Q?pTpsefmKQL8A8OshGLbo4G8S+A+kUF+dA0JichL/6+XqOioZypDWIs7AqLZB?=
 =?us-ascii?Q?RsJesVXq1WqQHt6fAWMy4PGtDbNE5ME96sod+NfthqI4L1z73eKa7LgMh9Js?=
 =?us-ascii?Q?x5St30QbAnci6BexX+Xi8fOlH6yDTnnIZGz0s8AFh5PndnGWlGsV+t24vkOt?=
 =?us-ascii?Q?n5qJIw9Ilndk6u6pmjSvMlWdmoZe65AU9ddrmcx9fgtrnCDXjx5N7qFOkMNz?=
 =?us-ascii?Q?BlZEOgskEDquu+yOsG/OrBo8oxIu+WP0zezGhkWnHm7qar7OXF9YWq9sBc8P?=
 =?us-ascii?Q?wkFvSU/uoLOdv3KYxT5gShZfCBjrDoqfuXDQnGAs?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca243dcd-ed24-44ba-634e-08dac22b0ac5
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 08:18:54.6125
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jRFjss2i7vPH8xyOz1o6CuWfSMuOlkZFRlWOwW38mYK6k1ZFcvn8ffZVlEp6/ZTN/dCJdjD7r8SMNMTyj/tEjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7350
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> In UFS 4.0, it introduced advanced RPMB, which can significantly improve
> RPMB's command performance, enhancing its atomic operation. We don't
> know which implementation will please everyone, mark this advanced RPMB
> patch as RFC. Any suggestions to make the patch a master patch are welcom=
e.
>=20
> Based on suggestions and feedback from Hannes Reinecke and Bart, we can
> use job_bsg->request and job_bsg->reply to pass EHS packets without chang=
ing
> the BSG V4 structure and BSG core. So we push RFC patch just to start
> Advanced RPMB mainlining
I concur with this approach.
The current limitations that the new spec imposes,
e.g. putting confidential data in a construct that lives in the ufs-driver,
practically gives no other alternative but ufs-bsg.

If no one else object, maybe you can leave out the rfc from the next versio=
n.

Thanks,
Avri

>=20
> Bean Huo (2):
>   ufs: core: Advanced RPMB detection
>   ufs: core: Add advanced RPMB support in ufs_bsg
>=20
>  drivers/ufs/core/ufs_bsg.c       | 115 +++++++++++++---------
>  drivers/ufs/core/ufshcd.c        | 161 ++++++++++++++++++++++++-------
>  include/uapi/scsi/scsi_bsg_ufs.h |  30 +++++-
>  include/ufs/ufs.h                |   3 +
>  include/ufs/ufshcd.h             |   5 +
>  5 files changed, 233 insertions(+), 81 deletions(-)
>=20
> --
> 2.25.1