Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9690b4e-30a7-75be-5492-98206c3ccd99@linaro.org>
Date:   Wed, 9 Nov 2022 10:08:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for
 mt8183-kukui-jacuzzi-juniper
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>,
        =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     kernel@collabora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Mark Brown <broonie@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>, Vinod Koul <vkoul@kernel.org>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221108232228.1177199-1-nfraprado@collabora.com>
 <06c4f370-715d-4c66-ad43-143b652af5ff@app.fastmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <06c4f370-715d-4c66-ad43-143b652af5ff@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 09/11/2022 08:28, Arnd Bergmann wrote:
> On Wed, Nov 9, 2022, at 00:22, Nícolas F. R. A. Prado wrote:
>> mt8183-kukui-jacuzzi-juniper is one of the devices set up to run tests
>> on KernelCI, but several of its drivers are currently disabled in the
>> defconfig. This series enables all the missing kconfigs on the defconfig
>> to get everything probing on that machine so that it can be fully tested
>> by KernelCI.
> 
> The changes all look fine, but I would recommend not separating it
> out into 13 patches when you are doing just one thing here. 
> 
> As a general rule, if you keep saying the same things in each
> patch description, it is usually an indication that they should
> be combined. Similarly, if you find describing unrelated changes
> ("also, ..."), that would be an indication that patches should
> be split up.

I agree. Descriptions you wrote are useful - they explain why you are
doing it - but it got all really too detailed, just for defconfigs. One
commit per one symbol is a bit too much...

Best regards,
Krzysztof