Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH 1/2] tty: serial: fsl_lpuart: only enable Idle Line Interrupt for non-dma case
Date:   Wed,  9 Nov 2022 18:45:14 +0800
Message-Id: <20221109104515.17266-2-sherry.sun@nxp.com>
In-Reply-To: <20221109104515.17266-1-sherry.sun@nxp.com>
References: <20221109104515.17266-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IIqyeZr7oQ6qIgZUUf9NEbEw10rElc2AZWeJnUPy6/KYg0C10usMs2is/vSa?=
 =?us-ascii?Q?IaVef5E6zgIOQGjpyGGJOKa7NKdsv2DVPk1JLHkh15ZjpHhkv1vaY5lZPxzG?=
 =?us-ascii?Q?Gz/LAa4SMVbflxcJjmsj/3NxaGf+oTZGL5afsJopm1YpyoUUhX4umoGcRfZo?=
 =?us-ascii?Q?LJ5ZIZV3z67hrMAjsOpCrK5skNMwpxymj8CD4IDDcjIksNSutZzPGEgA4Dyy?=
 =?us-ascii?Q?ZvfyQqxzmFMsVUklXtibjZlABhIQ2IstHJzgyZUaAVyttQr5l1P6LjECnsqM?=
 =?us-ascii?Q?x7y1epAmDuc2Yl68z1KPoJhb+0gEOibnM/kiwEZG+hsUqdbpiorwkAQMN+oG?=
 =?us-ascii?Q?2uWkLuIP//J5qltzPla6zGcKW5GxXtI0pAgFk3KpeOWZruZmMxFCPOjFH+hG?=
 =?us-ascii?Q?+u8JtDVGHssOhlR4KUB5LhgkauuMeKZCLjzUKT4AN37MwOubHMZnAC/fgRYY?=
 =?us-ascii?Q?VcCaYmYPoEOZGd3+6sS+YUIYPcwnLunzS7htCfoG2K7vI+7HDdqEfvMqnpzx?=
 =?us-ascii?Q?cKTx0aPqh6GSF8H9cLswX31KKr4+1DmHUavPj1Lt+gnOsm2333CNIBG34FCF?=
 =?us-ascii?Q?H7acsb6dmongXZJOdjkGptYuf2800nRadszRbENTKdS+hRVmqtMPmhaGE1cP?=
 =?us-ascii?Q?Sa0lkRki3K/wZHGTCZ4dZi3JfEohX+DE0r5IKmNAww23RY7VP18SG++DCQV/?=
 =?us-ascii?Q?58Hn1UsdKsZgRNium3J8z020lw448uSmM0ST+jUftcrRRPELpw4Boe66d+wx?=
 =?us-ascii?Q?yfdVOHEe2YVhfO7WDZ/VCAgsuCc5G0sU2ZC0giAps5O32aFqCE/E/KaE1MsA?=
 =?us-ascii?Q?t4SCbi/BqbJiZ2oHyaYac9Mb2dx9Ph91RouYL3i3dJ/45LF+/5cUxhGk5MAa?=
 =?us-ascii?Q?CsJyA+aODO3K4GIw3M/VVh2lppIBNsQQZ5Gk2mwaf8qQVtwZ1Y2lE+aUYzAC?=
 =?us-ascii?Q?koaMAub7SU2rxX9lG4+9aTgbajPCU4xgeMmk64Hrb2pWr8YE10Ck7Csryjaw?=
 =?us-ascii?Q?nNLmJ0wBvUkbHuPhdiCFvfW1/ThcVA0Q0xN1t2EePlRPkes41j7RhFsv/r8w?=
 =?us-ascii?Q?DSGA8czrRqiG5gVFHYmHcjCd2+d/SKSWt5fqOeEa8xZtlJxgOZL4znfMKPje?=
 =?us-ascii?Q?FQX3E9zD6g2ofFORbDrHY06OIiBTRjRGdP6TJVkEVD2uDqkYMO/+CGheEVoq?=
 =?us-ascii?Q?Qjf9Z4J/DhjatzeiJaSJgwpGMgvdwRz3ms0iIPkoVBk+3nmObyO1xkFg8LgU?=
 =?us-ascii?Q?+KN+Sd63Hz1+YsIX10JMtvCVQ4wfDniNkhF29ARAhDak23zi0jQdiyfYj2SA?=
 =?us-ascii?Q?pmmDD/vw2KTOGnEPQL44DcfdXjnCEK3J/X8ovATFXaOqZ385D47T1EZ6lzMj?=
 =?us-ascii?Q?zRzDDCJ5zs6+9rmnDv29yRkRsKmyTPH/hZ8CQXv8oNA0+JQjeQRejEJm2T9h?=
 =?us-ascii?Q?a98CyO0NpH/6TpwvgAukkyd+ZFRokehvuKdrRFeDPiz73DIKl9MzjBHfxoyR?=
 =?us-ascii?Q?ngrq+WKFqcaris3/jdeIVMh3NXcaIjU5pjssjieklSP86GCqsc4Qcq+/dfqH?=
 =?us-ascii?Q?/D0s4iDFoFK3C5JAYPVfVKx7TxV6OXYy2fWUiLBM?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16cd4161-2c8a-402a-e928-08dac23fbd08
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 10:47:03.8583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XSH5PoonnVg4wWEg6mNs+ALfSm+dUCtJwWLIS4D9ilSEwBjRKhOgeiKfNgGc0LF+5KAEDY2z/9yczNSz/AdVIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8974
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For the lpuart driver, the Idle Line Interrupt Enable now is only needed
for the CPU mode, so enable the UARTCTRL_ILIE at the correct place, and
clear it when shutdown.

Also need to configure the suitable UARTCTRL_IDLECFG, now the value is
0x7, represent 128 idle characters will trigger the Idle Line Interrupt.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index bd685491eead..f5a0a14fa366 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -179,7 +179,7 @@
 #define UARTCTRL_SBK		0x00010000
 #define UARTCTRL_MA1IE		0x00008000
 #define UARTCTRL_MA2IE		0x00004000
-#define UARTCTRL_IDLECFG	0x00000100
+#define UARTCTRL_IDLECFG_OFF   8
 #define UARTCTRL_LOOPS		0x00000080
 #define UARTCTRL_DOZEEN		0x00000040
 #define UARTCTRL_RSRC		0x00000020
@@ -230,6 +230,8 @@
 #define GLOBAL_RST_MIN_US	20
 #define GLOBAL_RST_MAX_US	40
 
+#define UARTCTRL_IDLECFG	0x7
+
 /* Rx DMA timeout in ms, which is used to calculate Rx ring buffer size */
 #define DMA_RX_TIMEOUT		(10)
 
@@ -1506,7 +1508,7 @@ static void lpuart32_setup_watermark(struct lpuart_port *sport)
 	ctrl = lpuart32_read(&sport->port, UARTCTRL);
 	ctrl_saved = ctrl;
 	ctrl &= ~(UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_TE |
-			UARTCTRL_RIE | UARTCTRL_RE);
+			UARTCTRL_RIE | UARTCTRL_RE | UARTCTRL_ILIE);
 	lpuart32_write(&sport->port, ctrl, UARTCTRL);
 
 	/* enable FIFO mode */
@@ -1530,7 +1532,8 @@ static void lpuart32_setup_watermark_enable(struct lpuart_port *sport)
 	lpuart32_setup_watermark(sport);
 
 	temp = lpuart32_read(&sport->port, UARTCTRL);
-	temp |= UARTCTRL_RE | UARTCTRL_TE | UARTCTRL_ILIE;
+	temp |= UARTCTRL_RE | UARTCTRL_TE;
+	temp |= UARTCTRL_IDLECFG << UARTCTRL_IDLECFG_OFF;
 	lpuart32_write(&sport->port, temp, UARTCTRL);
 }
 
@@ -1669,7 +1672,7 @@ static void lpuart32_configure(struct lpuart_port *sport)
 	}
 	temp = lpuart32_read(&sport->port, UARTCTRL);
 	if (!sport->lpuart_dma_rx_use)
-		temp |= UARTCTRL_RIE;
+		temp |= UARTCTRL_RIE | UARTCTRL_ILIE;
 	if (!sport->lpuart_dma_tx_use)
 		temp |= UARTCTRL_TIE;
 	lpuart32_write(&sport->port, temp, UARTCTRL);
@@ -1770,7 +1773,7 @@ static void lpuart32_shutdown(struct uart_port *port)
 
 	/* disable Rx/Tx and interrupts */
 	temp = lpuart32_read(port, UARTCTRL);
-	temp &= ~(UARTCTRL_TE | UARTCTRL_RE |
+	temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE |
 			UARTCTRL_TIE | UARTCTRL_TCIE | UARTCTRL_RIE);
 	lpuart32_write(port, temp, UARTCTRL);
 
-- 
2.17.1